Time  Nick       Message
08:08 erle       const std::regex r("<title.*?>(.*?)</title.*?>");
08:08 erle       time for zalgo text lol
08:17 pgimeno    can't help being reminded of https://stackoverflow.com/questions/1732348/regex-match-open-tags-except-xhtml-self-contained-tags#1732454
08:30 rubenwardy Yeah I don't support that pr
08:31 rubenwardy The implementation uses regex to parse html, which is bad, and the feature feels scope creepy
10:36 MTDiscord  <grorp> I agree. Also, the feature doesn't seem useful to me: You can just open the URL in your browser if you want to know the title. That also makes it more explicit that you reveal your IP.
10:40 sfan5      yeah, giving it an initial review was a mistake
10:42 [MTMatrix] <localhost> I see only one mitigation: make mod replace links to proxied (web-proxy) links
10:43 erle       why is this not a CSM anyway
10:45 erle       so i am seeing this: httpfetch_sync(fetch_request, fetch_result); // sync because this is not the main thread
10:45 erle       what exactly will be blocked if the link goes to a slowloris page?
10:46 erle       like, which part of the engine is going to stall here?
10:46 erle       oh wait, slowloris is client, not server
10:47 erle       i think every code that retrieves titles should at least be tested against this kind of thing https://irc-bot-science.clsr.net/
10:47 erle       i mean stuff like https://irc-bot-science.clsr.net/long is PROBABLY going to happen given the presence of absolutely vile users on some servers
10:49 erle       anyway, what part of the engine ends up sync blocked here? i don't know
10:51 rubenwardy looks like it creates a new thread for it
10:54 erle       but where?
10:55 rubenwardy https://github.com/minetest/minetest/pull/13724/files#diff-c2b3d8046dce7af2ffbe3406b7a978425f31505d49bba6b65b0e90af90f9e3eaR702
10:55 erle       ah thx!
17:00 srifqi     hello. since it is almost release, can we have string/translation update?
19:17 erle       when is release
19:31 Pexin      < erle> why is this not a CSM anyway
19:32 Pexin      erle: if I understand the question, the answer is the same reason the clickable weblinks isn't a csm. csm doesn't have access to screen coords/mouse input
19:35 Pexin      or cURL, and a bunch of other stuff
19:39 erle       Pexin did you look if it can be done in dragonfire?
19:40 Pexin      noe
19:40 Pexin      also it's been like 2 years since, so I don't remember much anymore