Time  Nick        Message
17:43 appguru     Hi. Would any core dev happen to have the time to review one (1) line of code? https://github.com/minetest/minetest/pull/13638#discussion_r1248124242
17:48 appguru     wsor: do your triager permissions suffice to move the Minetest Game issue to the engine?
17:49 * celeron55 is taking a quick look
17:49 wsor        nope, try Zughy[m]
17:49 wsor        or c55 🤷
17:53 celeron55   it would require digging up the mapping of api functions to network packets to fully understand what's going on and what the intention of the obviously wrong -1 was
17:54 celeron55   NO_ANIM is definitely obviously better than -1
17:55 celeron55   hmm...
17:58 celeron55   isn't this where the problem actually occurs, once the value is -1? https://github.com/minetest/minetest/blob/cbc0fce6cacf5cbdabbfcf9a96cbf2e5bcd6a40d/src/client/content_cao.cpp#L1091
18:01 celeron55   maybe not. the animation logic isn't very easy to follow
18:04 celeron55   the naming is silly also. isn't NO_ANIM the idle animation?
18:07 Desour      NO stands for natural organism idling simulation
18:08 Desour      so, do we finally get a way to make sam sit reliably? nice!
18:16 celeron55   well, i'll just say if that one line fix seems to work by testing and doesn't seem to break other animation changes it's ok