Time Nick Message 15:01 rubenwardy merging #13482 in 10 15:01 ShadowBot https://github.com/minetest/minetest/issues/13482 -- Add min/max protocol version to `minetest.get_version()` by BuckarooBanzay 15:07 MTDiscord Oh, does that affect the serverlist? We really need a way to SET the min/max protocol version 15:09 MTDiscord Having a server on the serverlist that says it supports versions 37 through 42 is kind of crappy when the game only supports 39 through 42 and basically has to kick people after the fact. 15:13 Krock huh? it takes the minimum version from both sides anyway 15:13 Krock * common maximal version 15:14 MTDiscord If a client only supports whatever up to 38, then they would see my server on the list because minetest advertises that they have 37 and 38 in common, even though they can't actually play because the game requires 39. 15:15 Krock in that case you should enforce strict protocol version checking 15:16 rubenwardy no, this is just an API 15:16 MTDiscord No, strict protocol version checking only sets it to 42. 15:16 MTDiscord The current settings only allow min 37 or min 42, I have no way to set it to min 39. 15:17 Krock perhaps open an issue about that if there's not yet one about it? 15:17 MTDiscord Okay, I'll take a look. 15:17 Krock I suppose this could be solved by the game's minetest.conf setting which could then be used for protocol version checking 15:18 rubenwardy min/max minetest version in the .conf is the server version, not the client version 15:19 rubenwardy oh minetest.conf 15:19 rubenwardy yeah, can add min_protocol_version and then games can add to the game.conf 15:19 rubenwardy *minetest.conf 15:21 MTDiscord If we could get that to propagate to server advertisements or whatever so that clients can filter out servers they wouldn't be able to connect to anyway, that would probably make the experience better 15:21 Krock that's already reported to the server list. it's just a matter of changing the broadcast parameter based on said mientest.conf possibility 15:22 Krock still, that's not related to the PR in case you think that 15:24 MTDiscord I didn't find anything (though, wow, there's a lot of "protocol version" related issues to dig through) so https://github.com/minetest/minetest/issues/13483 15:25 Krock there's a feature request template. how come this didn't work? 15:26 MTDiscord Hmm, I think I've noticed that those templates don't seem to work when I use GH's "New Issue" Button -> Login -> Issue Editor flow. 15:26 MTDiscord could be a GH bug 15:26 Krock possibly. 15:27 MTDiscord Sometimes I see templates, sometimes I don't, and I hadn't really put much thought into what causes it to be one way or another before, but that's one variable that I know changes a fair bit.