Time Nick Message 13:49 Guest54 Krock hmmm, maybe that particle spammer test code should be in devtest? or not? 13:58 Krock context? 14:00 Guest54 Krock there is a command here https://github.com/minetest/minetest/issues/13199 for the testing of tweening properties, maybe it should be in devtest? 14:00 Guest54 as a kind of regression test 14:01 Krock possibly yes 14:02 Krock in combination with others to also serve as a code example. I think the lua_api.txt makes it quite hard to grasp the syntax for a specific particle spawner 15:15 sfan5 is everyone available to do the release today? 15:17 rubenwardy Yes 15:21 Krock I'd be around. I'd merge #13374 in a few minutes if that's okay 15:21 sfan5 I was thinking we merge #13374, I import the translations and then we can go 15:21 rubenwardy ShadowBot! 15:21 Krock seems to have connectivity issues.... 15:22 Krock merging 15:24 Krock go ahead with the translation update 15:24 sfan5 pushing http://sprunge.us/kIV3El?diff after you've merged 15:24 Krock ah.. the build tasks that are currently broken 15:25 Guest54 sfan5 that FIXME should probably have at least some context on why it was added, not? 15:26 Guest54 like if it is in the commit message it's ok ig 15:26 sfan5 maybe 15:26 Guest54 but anyone reading this would be confused 15:29 Guest54 sfan5 are you maintaining the nekomimi.pw host? 15:30 sfan5 yes, why? 15:31 sfan5 will do weblate import now 15:38 sfan5 commits here https://github.com/minetest/minetest/compare/ci 15:40 Krock shorter than expected 15:42 Guest54 sfan5 because https://github.com/minetest/irrlicht/blob/master/scripts/ci-build-mingw.sh downloads from there and https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-3857 exists 15:42 Guest54 > libpng_version=1.6.37 15:42 Guest54 > A flaw was found in libpng 1.6.38. A crafted PNG image can lead to a segmentation fault and denial of service in png_setup_paeth_row() function. 15:42 sfan5 updating the libraries is on my todo list for after release 15:43 Guest54 wouldn't it be a good idea to do it *before* if there is a known crash? 15:43 Krock why? it's the servers who run it anyway 15:43 Krock and they don't want to crash clients 15:43 Guest54 current libpng is  1.6.39 15:43 Guest54 well as long as nothing writes PNGs with paeth predictor serverside … appguru do you do that? 15:44 Krock (by "run it anyway" I mean the distribution of potentially faulty PNG data) 15:44 sfan5 Guest54: it would be but I don't plan to 15:44 appguru no I don't lol 15:44 Guest54 well then skinsdb remains 15:45 appguru just tell mod authors to first validate their PNGs using modlib ^^ 15:46 Guest54 or, say, uploading a PNG that has some paeth mess to cdb, whatever. i thought changing the version number is an easy task, but if sfan5 does not want to do it, i guess there is more to it than changing a single line. 15:47 sfan5 (there is more to it) 15:49 Guest54 well than that's a good justification, i just wanted to make you aware of it 15:49 Guest54 (the CVE, that is) 15:53 sfan5 pushing weblate to master 15:53 Krock 👍 15:59 sfan5 ok so technically we can start now 15:59 sfan5 I guess this means I will prepre 15:59 sfan5 *prepare the windows builds (oops) 16:00 Krock perfect. thank you. 16:02 sfan5 rubenwardy: do I need to increase version code by 2 or 4? 16:02 Krock (I think it's by 2) 16:02 rubenwardy I can't remember because we use android bundles now 16:02 rubenwardy it's either by 4 or 1 16:02 sfan5 🤔 16:02 rubenwardy we now support x86, so it's no longer 2 16:03 Krock oh 16:03 rubenwardy I think the code assumes different version codes for different binaries, so +4 16:03 rubenwardy I reckon we could make it so we only need +1 though 16:03 sfan5 I'll check google play to see which codes we have already used 16:03 sfan5 assume it'll let me 16:03 sfan5 assuming* 16:04 sfan5 hmm nah 16:04 Krock that needs documentation in https://dev.minetest.net/Releasing_Minetest#Build_and_publish_Android_APK or the bump script 16:05 Krock > increments versionCode in build/android/build.gradle by 2 16:05 Krock yet that seems to be outdated 16:07 sfan5 I did +4 now 16:11 sfan5 will merge game#3019 beforehand 16:13 sfan5 and game#3022 16:13 Krock is game#3022 urgent too? 16:13 Krock okay good 16:14 sfan5 almost missed that 16:19 sfan5 hmm just went through the MTG issues and it could use some attention 16:20 Guest54 since i bet the question will be asked after release anyway – any idea when https://play.google.com/store/apps/details?id=net.minetest.minetest will return? 16:23 sfan5 windows builds uploaded, afk now 30m 16:58 sfan5 dynamic shadows or automatic exposure seem to be leaking memory, I can easily bring the 32-bit build to crash by flying around a bunch 16:58 sfan5 2023-04-08 18:55:43: ERROR[Emerge-0]: /home/stefan/mt-build/build/32/minetest/src/emerge.cpp:2f4: run: A 16:58 sfan5 fatal error occurred: std::bad_alloc 16:58 Krock only in 32-bit? 16:59 Krock https://github.com/minetest/minetest/blob/master/src/emerge.cpp#L756 referenced line 17:00 sfan5 alternatively the allocation size is wrong, memory usage at time to crash is barely above 1GB 17:00 sfan5 could be that the process runs out of virtual address space for other reasons 17:03 sfan5 client_mapblock_limit = 2000 does not prevent this so this suggests there's an actual bug 17:03 sfan5 ping @x2048 17:05 sfan5 anyway I don't think we should delay the release for this 17:05 Krock 32-bit are quite rare nowadays 17:06 Krock still, it should be fixed soon 17:09 sfan5 here's the settings at least https://paste.debian.net/1276768/ 17:10 sfan5 okay, should we proceed? 17:10 sfan5 hm I guess I should test on real windows, not wine 17:11 Krock I can do that if you don't have one at hand rn 17:11 sfan5 no need 17:26 rubenwardy release post: https://github.com/minetest/blog/pull/79 17:26 rubenwardy needs more images and sources for long-range performance 17:26 Guest54 how do you compile for x86 on amd64 anyway? cmake -DCMAKE_CXX_FLAGS='-fsanitize=address -march=i386' . on an amd64 machine gives me an “irrlicht header version mismatch” error, which seems … wrong? 17:26 rubenwardy for cmake, you want to use a toolchain file to set the right triple 17:26 rubenwardy to cross compile 17:26 Guest54 more accurately, “IrrlichtMt revision number mismatches between CMake and headers.” 17:26 Guest54 thanks, i did not know 17:26 sfan5 hmm can't reproduce on a whim here but also totally different hardware 17:26 sfan5 (the oom bug on win32) 17:26 Krock could as well be a bug in Wine 17:26 rubenwardy checks out. Wine makes me bloated as well 17:26 Guest54 what if you use leaksanitizer, does it complain? 17:29 sfan5 I will push the release commit, tags and branches then unless there's anything else? 17:30 rubenwardy 🚀 17:30 Krock I don't see anything. It there were something important, it should be contained in the milestone anyway 17:30 Krock but that's all done 17:31 Desour 🎉 17:33 sfan5 done, MTG tagged too 17:35 sfan5 will update the website next and then do the forum post 17:35 Krock updating changelog... 17:38 Krock done 17:39 sfan5 suggestions for features to highlight in forum post? 17:39 Krock https://irc.minetest.net/minetest-dev/2023-03-05#i_6060498 17:40 Krock also postprocessing: bloom, dynamic exposure etc. 17:40 rubenwardy release post: https://github.com/minetest/blog/pull/79 17:40 rubenwardy See list in release candidate post as well 17:43 rubenwardy https://forum.minetest.net/viewtopic.php?f=18&t=29249 17:43 Desour the on_mapblocks_changed callback might also be worth mentioning 17:46 sfan5 also we no longer ship devtest 17:46 sfan5 just wanted to mention it, probably not worth highlighting 17:46 Guest54 well, kinda. is devtest on cdb? 17:47 MTDiscord yes, it's on CDB now 17:47 Guest54 btw, the line in the changelog “Add zstd compression support (more efficient map saving) (20kdc)” is wrong, the change was about minetest.compress() algorithms. 17:47 MTDiscord https://content.minetest.net/packages/Minetest/devtest/ 17:47 rubenwardy It is, but violates mod name rules so probably shouldn't be on cdb 17:48 Guest54 devtest_game when 17:48 rubenwardy Official game has special status I guess 17:49 rubenwardy It's less problematic being on cdb than being bundled by default 17:55 MTDiscord anyways, made a release of CDB devtest for 5.7.0 based on the latest master. it says 5.7-dev but I assume it will change when ruben updates the minetest version list on CDB 17:56 Guest54 hmm, it will still stay in minetest git repo, will it? 17:56 MTDiscord yes 17:57 MTDiscord it's staying in the git repo, and staying for RUN_IN_PLACE builds for development 17:57 MTDiscord it won't be installed by default but there is a cmake flag if you really want to still install it 18:00 sfan5 with that out of the way 18:00 sfan5 merging #13216, #13273, #13280 in 15m 18:23 sfan5 (done) 21:15 pgimeno https://github.com/minetest/minetest/pull/13216 -- Remove fast faces by numberZero 21:16 pgimeno https://github.com/minetest/minetest/pull/13273 -- Get rid of wgettext by Desour 21:16 pgimeno https://github.com/minetest/minetest/pull/13280 -- [no squash] Drop ENABLE_GLES by sfan5 21:16 pgimeno #13216, #13273, #13280 21:16 ShadowBot https://github.com/minetest/minetest/issues/13216 -- Remove fast faces by numberZero 21:16 ShadowBot https://github.com/minetest/minetest/issues/13273 -- Get rid of wgettext by Desour 21:16 ShadowBot https://github.com/minetest/minetest/issues/13280 -- [no squash] Drop ENABLE_GLES by sfan5 21:16 pgimeno hah 21:16 rubenwardy you're my #1 21:16 ShadowBot https://github.com/minetest/minetest/issues/1 -- GlowStone code by anonymousAwesome 21:16 rubenwardy not you shadowbot 21:17 pgimeno I've disabled it already :)