Time Nick Message 00:13 Zughy[m] meeting notice posted (next Sunday) 01:57 lhofhansl sfan5: If you're still around... Have a quick look at #13256... It's a quick addendum for #13255 for large viewing_ranges. 01:57 pgimeno https://github.com/minetest/minetest/pull/13256 -- Check if client has a block even if the server has unloaded it. by lhofhansl 01:57 pgimeno https://github.com/minetest/minetest/pull/13255 -- Don't expire blocks visible to the client. by lhofhansl 16:48 sfan5 can we get some approvals on #13245, #13243 16:48 pgimeno https://github.com/minetest/minetest/pull/13245 -- [no squash] Fix task ordering and more in Gradle Android build by sfan5 16:48 pgimeno https://github.com/minetest/minetest/pull/13243 -- Drop dependency on IrrCompileConfig by numberZero 17:00 lhofhansl We need to either revert #13255 or merge #13256. 17:00 pgimeno https://github.com/minetest/minetest/pull/13255 -- Don't expire blocks visible to the client. by lhofhansl 17:00 pgimeno https://github.com/minetest/minetest/pull/13256 -- Check if client has a block even if the server has unloaded it. by lhofhansl 17:17 kilbith that's exactly why we need to wait and think a bit more prior merging something 17:18 kilbith I know merging your PRs can cause you to secrete some dopamine but that's not always a smart move 17:18 kilbith (Lars, in all friendship ;) 17:20 lhofhansl Not helpful. We do that all the time. git makes revert easy. Or we fix forward. 17:20 lhofhansl This is another four line change for a corner case. 17:24 sfan5 more like a fix for a fix 17:40 lhofhansl I file a brainstorming issue for the serverside for large viewing_ranges. There are a bunch of more things we can do. 17:57 lhofhansl Ok. Merged. 18:10 lhofhansl Also #13259 I just filed. It add a log line that measure the time it took the server to update/send the complete map to the client. For large viewing_ranges this can be minutes... And hence the default server_unload_unused_data_timeout (29s) gets in the way of that. 18:10 pgimeno https://github.com/minetest/minetest/pull/13259 -- Measure server map send time. by lhofhansl 18:13 lhofhansl (and don't mind my spelling :) ) 18:55 sfan5 is there some kind of trend putting a full stop at the end of commit titles 18:58 MTDiscord wonders why he followed the rules as best he could in his first PR 19:27 lhofhansl sfan5: Referring to my commit(s)? Should I not do that? Fine either way. 19:27 sfan5 yes yours 19:28 sfan5 I don't think we have a rule for/against it but without would be more consistent with the rest 19:28 lhofhansl Noted. 19:30 lhofhansl Check out #13260. Put some numbers on it. 19:30 pgimeno https://github.com/minetest/minetest/pull/13260 -- Reduce server CPU consumed by occlusion culling. by lhofhansl 19:30 lhofhansl (And I'll remove the trailing . if/when this is merged) 22:47 rubenwardy merging #12367 in 10 22:47 pgimeno https://github.com/minetest/minetest/pull/12367 -- Add minetest.get_player_window_information() by rubenwardy 22:51 MTDiscord That is awesome! 23:08 sfan5 reminder: can we get some approvals on #13245, #13243 23:08 pgimeno https://github.com/minetest/minetest/pull/13245 -- [no squash] Fix task ordering and more in Gradle Android build by sfan5 23:08 pgimeno https://github.com/minetest/minetest/pull/13243 -- Drop dependency on IrrCompileConfig by numberZero