Time  Nick           Message
07:26 sfan5          schwarzwald[m]: I say we can worry about this when it all works
07:26 sfan5          generally in source/Irrlicht/
11:46 schwarzwald[m] sfan5: Ok, it's in source/lib/ for now but agreed, we can move it easily later
11:47 schwarzwald[m] What we can't change so easily is the tests I'd like to add. I started with Catch2 because Minetest already uses it. Looking ahead to when we combine Minetest and Irrlicht, so we won't have yet another test library.
11:48 schwarzwald[m] Issue is, turns out Catch2 is kind of slow to compile on my computer. In fact, it even takes longer to compile one Catch2 unit test on CI than multiple Irrlicht source files.
11:49 schwarzwald[m] I'm a little worried about the future.
11:50 jwmhjwmh       Merging #12626, #12790, and #12869 in 5m.
11:50 ShadowBot      https://github.com/minetest/minetest/issues/12626 -- LocalPlayer: Fix sneaking on nodes with large collisionboxes by SmallJoker
11:50 ShadowBot      https://github.com/minetest/minetest/issues/12790 -- Take geographic distance into account for server list ordering by sfan5
11:50 ShadowBot      https://github.com/minetest/minetest/issues/12869 -- [NO SQUASH] Fix lua_api.txt typos and en_US/en_GB inconsistency by Abdou-31
11:58 sfan5          I had hoped for more coredev feedback before merging that but we'll see
11:58 sfan5          not like we can't tweak it afterwards
17:27 sfan5          oh yeah now I know why I didn't want that merged yet, there's a tiny bug in it
17:45 rubenwardy     !tell jwmhjwmh a core dev's approval on their own PR isn't automatic, you should probably wait
17:45 ShadowBot      rubenwardy: OK.
17:45 rubenwardy     Also worth adding things like known bugs to the todo
17:47 sfan5          I forgot :s
17:51 Krock          there were bugs in that PR?
18:05 sfan5          pushing http://sprunge.us/NoS9Yn?diff in 5m
18:09 Krock          > if ping < 400 then
18:09 Krock          > -- If ping is over 400ms
18:09 Krock          doesn't feel right
18:12 sfan5          I can reword that if you want
18:12 Krock          if you can come up with something that's more intuitive and while you're at it.. sure, that would be great :)
18:12 Pexin          "only do the estimate if.."
18:15 sfan5          -- If ping is under 400ms replace it with our own estimate,
18:15 sfan5          -- we assume the server has latency issues anyway otherwise
18:15 sfan5          s/we // sounds even better in fact
18:15 sfan5          or maybe not, whatever
18:19 Krock          👍
20:32 Eze14Mu        Dice what a ****
22:07 jwmhjwmh       rubenwardy: Sorry, I guess I got carried away.