Time Nick Message 10:12 sfan5 @savilli if you make a PR importing Irrlicht into Minetest it would be rejected 10:12 sfan5 see https://github.com/minetest/irrlicht/issues/107 for what needs doing first 14:26 MTDiscord sfan5: But wouldn't it be easier to get rid of irrlicht containers if you need to commit to one repo instead of two at the same time? 14:26 MTDiscord Also why is core::array checked? It still exists and brings problems. 15:06 sfan5 what kind of problems? 15:08 MTDiscord Like https://github.com/minetest/irrlicht/pull/128 15:10 MTDiscord It would be nice to change its constructor at least 15:11 sfan5 that is a bug uncovered by refactoring, if you do bigger changes (e.g. replace core::array entirely) the likelihood of additional bugs like this is even higher 15:13 sfan5 anyway I think getting rid of non-STL types is a good goal, I'll be more precise in the roadmap 15:14 sfan5 re "isn't it easier to commit to one repo than two?" absolutely, but the Irrlicht code should be nearly completely cleaned up before importing it, not after 15:16 MTDiscord Okay, imagine I want to get rid of core::array. What would be my pipeline considering I need to change minetest/src/irrlicht_changes/ as well? 15:18 sfan5 (you need to touch other code in minetest too, not just irrlicht_changes) 15:19 sfan5 the process is: 1) changes made in irrlicht 2) irr revision increased 3) changes made in mt 4) mt made to require the new revision 15:19 sfan5 alternatively we could switch to a submodule because that is what we're poorly emulating this way 15:21 MTDiscord But wouldn't minetest be unbuildable between 1 and 3? 15:22 sfan5 yes 15:22 sfan5 releases have a fixed irrlichtmt revision they support so that's no concern 15:23 MTDiscord What about CI tests? 15:23 MTDiscord Unittests in PRs wouldn't work 15:24 sfan5 they also use a fixed revision 15:25 MTDiscord misc/irrlichtmt_tag.txt ? 15:26 MTDiscord Yeah, looks like we've just reinvented submodules 15:27 MTDiscord Okay, thanks 17:08 sfan5 when is the meeting again? 17:08 Desour according to the rubenwardy from the past, it's at 19:00 UTC https://irc.minetest.net/minetest-dev/2022-07-31#i_6002639 17:09 rubenwardy Wasn't it moved an hour earlier? 17:09 rubenwardy I won't be available tonight 17:09 rubenwardy Yeah, 18:00 UTC 17:10 rubenwardy (50 minutes) 17:11 rubenwardy Krock can't attend either 17:11 Desour it would be useful if you'd write precise meeting times down somewhere, i.e. at the wiki, btw. 17:38 rubenwardy Would be good to have a bot to remind on the day as well 18:00 sfan5 . 18:05 sfan5 well doesn't look like I need to hold a meeting with myself 18:06 sfan5 unless hmmmm, nore, nrz, ShadowNinja, sofar, @x2048 or celeron55 happen to be here 18:08 MTDiscord I am here 18:10 sfan5 let me check the notes then 18:10 sfan5 > Add some bugs to the 5.6.1 milestone? (Proposal: each core dev pick one and adds it) 18:10 sfan5 I think the milestone has good coverage already, but if you have any regressions feel free to add them 18:12 sfan5 > Two years have passed since the first roadmap brainstorm: create another one to then follow after 5.7? Also to gather feedback 18:12 MTDiscord I'd like to add #12692, since it visibly improves performance when shadows are on. 18:12 sfan5 I'm generally in favor of this 18:12 ShadowBot https://github.com/minetest/minetest/issues/12692 -- Limit force shadow update to urgent blocks by x2048 18:12 sfan5 adding 12692 sounds good to me 18:13 sfan5 I'm likely to backport every fix (not just regressions) for 5.6.1 anyway 18:13 nrz Hey, Fine to me too. Eating with children, i may not answer all 18:14 Desour maybe add #12708 to the 5.6.1 milestone? the new serialization is broken with big inputs AFAIK 18:14 ShadowBot https://github.com/minetest/minetest/issues/12708 -- [no squash] Serialize: LuaJIT workaround & restore forwards compat by appgurueu 18:16 sfan5 ah yeah that too 18:18 sfan5 > Use .md extension for markdown files - yes or no? 18:18 sfan5 personally not sure yet, maybe we should have a more obviously placed rendered version of the file that can be properly linked and styled as we want (alluding to the line height complaint in the PR) 18:23 sfan5 > Doc of set_sun/-moon: Absolute orientation and difference in scale - document difference in size or slightly change the scale of both the celestial bodies? 18:23 sfan5 breaking changes for no good a reason 18:23 sfan5 breaking changes for no good reason are not worth discussing, not okay * 18:24 Desour ^ the PR just adds documentation btw. 18:28 sfan5 and finally I can only recommend everyone to take aside a bit of time for looking at any of these https://github.com/minetest/minetest/pulls?q=is%3Aopen+is%3Apr+label%3A%22One+approval%22 18:45 MTDiscord Regarding .md extension, +1 from me, allows using the tooling to preview without hacking around. But the discord (and irc?) bot will need to be patched. 18:57 MTDiscord Regarding sun/moon, I've left review comments in #12145. 18:57 ShadowBot https://github.com/minetest/minetest/issues/12145 -- Doc of `set_sun`/-`moon`: Absolute orientation and difference in scale by Desour 18:59 MTDiscord Have to leave now 19:07 MTDiscord The GitLab workflows generating the fancy page will also need to be updated. 19:08 MTDiscord actually, it looks like a bunch of error messages references lua_api.txt 19:09 MTDiscord script/lua_api/l_object.cpp: log_deprecated(L, "Deprecated call to set_sky, please check lua_api.txt"); script/lua_api/l_object.cpp: log_deprecated(L, "Deprecated call to get_sky, please check lua_api.txt"); network/networkprotocol.h:// See also formspec [Version History] in doc/lua_api.txt 19:35 Zughy[m] how about the needs approval PRs?