Time Nick Message 10:34 rubenwardy imo the two features should probably be dropped from 5.6.0 11:23 sfan5 or we could just get them done 12:28 rubenwardy I don't see either as especially important 12:30 rubenwardy they both need changes, if we were to delay the release for a feature there's other things I'd prefer 12:38 nrz_ i'm curious, which feature blocks the freeze ? 12:44 rubenwardy #12131 and #7629 12:44 ShadowBot https://github.com/minetest/minetest/issues/12131 -- Add `minetest.settings` to CSM API and allow CSMs to provide `settingtypes.txt` by AFCMS 12:44 ShadowBot https://github.com/minetest/minetest/issues/7629 -- Run Minetest update checker on startup by SmallJoker 19:04 sfan5 so far nothing is delaying anything, we still have until the end of the freeze period 19:10 sfan5 anyway I wanted to update translations now 19:11 sfan5 anyone mind if I add the fgettext() stuff from the two pending PRs as dummy code prematurely so we can have them included in the translations? 19:11 rubenwardy sure 19:44 sfan5 for some reason xgettext picks up 50 lines of random source comments and puts them into each .po file as if they belong to "Available commands: ", will fix that manually this time 19:46 sfan5 https://github.com/minetest/minetest/tree/ci commit list 19:47 sfan5 also I don't know who has the stupid idea to add a http://irrlicht.sourceforge.net reference to every keymap_ settings 19:47 sfan5 ...which aren't even visible 19:47 sfan5 but even if we wanted to keep this, it should be added prematurely 19:47 sfan5 uh it's getting to late 19:47 sfan5 programtically* 19:47 sfan5 +a 19:52 ROllerozxa all of the strings related to 'key' type settings appear to be completely unused in the main menu 19:52 rubenwardy they're intentionally hidden, they're only there to end up in minetest.conf.example 19:54 ROllerozxa yeah but they could still be excluded from the dummy translation strings file, something like 'else' => 'elseif entry.type ~= "key" then' @ builtin/mainmenu/generate_from_settingtypes:112 19:55 sfan5 good idea, should I do this now? 19:56 sfan5 though really we should be using the translations as tooltips in the key change menu 19:58 rubenwardy key change should be scrollable and generated from the setting types or some source 20:00 sfan5 builds are fine, pushing those commits 20:03 ROllerozxa yeah uh if the strings are supposed to show up in a future key change dialog then it might be a good idea to keep the translated strings around then 20:13 sfan5 new strings can now be translated in weblate