Time  Nick       Message
06:22 nrz        Krock: then it can be problematic if for example you create a remote camera like supervision camera for a building with a remote command. Maybe we need to handled such case, it can be nice
19:34 sfan5      recently I was thinking that part of what makes coredev reviews so important is that they know how things are supposed to work in the codebase
19:34 sfan5      simple example: core.log("deprecated", ..., N) instead of doing whatever seems good spontanously
19:34 sfan5      would be good to write these things down
19:34 sfan5      but if such a document is put into the repo it's probably too static, so maybe the dev wiki?
19:38 erle       i have never had issues with such stuff being in the main repo of a project. i have frequently had issues with such stuff being in a mediawiki, confluence, another repo etc.
19:38 erle       YMMV
19:38 erle       (confluence is the worst by far)
20:01 MTDiscord  <luatic> sfan5: good idea, document it; probably the "deprecated" log level should even go in lua_api.txt?
20:02 sfan5      if its an internal engine feature, no
20:02 MTDiscord  <luatic> it would make sense to expose this to mods
20:02 MTDiscord  <luatic> mods may deprecate APIs as well, and having a convenience func for this is definitely useful
20:02 MTDiscord  <luatic> also it's basically already exposed :P modders just don't know it
20:09 x2048      Merging #12497 in a few minutes
20:09 ShadowBot  https://github.com/minetest/minetest/issues/12497 -- Release shadow mapping resources when not needed by x2048
20:23 erle       sfan5 do you know “the architecture of open source applications?“ it's a nice read http://www.aosabook.org/en/index.html
20:23 sfan5      not heard of it
20:24 erle       skip the “500 lines or less” stuff and scroll a bit down on the page
20:24 erle       the developers of popular packages are explaining architecture
20:24 erle       like asterisk, cmake, nginx, battle for wesnoth
20:25 Krock      will merge #12450 #12486 #12521 5 minutes after x2048 realized that the time is totally overdue
20:25 ShadowBot  https://github.com/minetest/minetest/issues/12450 -- Enforce limits of settings that could cause buggy behaviour by SmallJoker
20:25 ShadowBot  https://github.com/minetest/minetest/issues/12486 -- Sounds: Various little improvements by SmallJoker
20:25 ShadowBot  https://github.com/minetest/minetest/issues/12521 -- Make `VoxelArea:position()` return a vector with metatable by AFCMS
20:26 erle       it is a good read regardless, but i guess if you want to talk about architectural quirks it's a good idea to read a bit of it to figure out which style of explanation you might want to use
20:26 x2048      Oh sorry.  Merged now.
20:26 x2048      Krock ^
20:27 Krock      missing announced times is a standard, indicating that you're well integrated ;)
20:27 erle       is this the thing that makes repeat_place_time 0.25 at minimum?
20:27 erle       oh it is
20:28 erle       this is problematic when people want to move backwards and hold the mouse button to make a line behind them if they move faster than 4n/s (but i think i said that beforet
20:31 Krock      merging
20:32 Krock      done
20:35 erle       const u64 frametime_min = 1000000.0f / std::max(fps_limit, 1.0f);
20:35 erle       Krock, can this divide by zero?
20:35 erle       oh i see
20:35 erle       sorry
20:35 erle       brainfart
20:38 x2048      Any reason we keep this code around: https://github.com/minetest/minetest/blob/master/src/client/render/pageflip.h#L24 ?
20:39 Krock      erle: a more interesting question would be: "what happens if you cast 'inf' to s64?"
20:40 Krock      x2048: I don't think there's any reason for it to exist
20:40 Krock      there's also some GUISkin class in Minetest that somehow duplicates a file from Irrlicht.. very helpful.
20:42 x2048      Krock: thanks for confirming, I'll drop it in my branch.
20:42 ROllerozxa the pageflip 3d mode broke alongside irrlichtmt upgrading to 1.9 and it was supposed to be fixed for 5.5.0 but nobody really seemed to care