Time  Nick       Message
09:53 Zughy[m]   I've reached Wuzzy's comma PR quality #12423
09:53 ShadowBot  https://github.com/minetest/minetest/issues/12423 -- Docs: add missing backtick by Zughy
09:54 Zughy[m]   it would have been faster for OP to file the PR than opening an issue, but hey
16:07 MTDiscord  <exe_virus> It actually wasn't, sorry
16:07 MTDiscord  <exe_virus> There was a nice (make an issue with this line) button on the web interface. Took less than 30 seconds
16:07 MTDiscord  <luatic> there also is a nice "edit this file" button on the web interface
16:08 rubenwardy You can click a pencil on the file to edit it and open a PR
16:08 MTDiscord  <exe_virus> I'll have to practice, I thought that requires my account to make a branch correct?
16:08 rubenwardy well, not sure about the PR bit but it can create a branch
16:08 rubenwardy it creates the branch for you
16:08 MTDiscord  <luatic> It takes you to the PR afterwads
16:08 MTDiscord  <luatic> afterwards*
16:08 MTDiscord  <exe_virus> On who's account? My minetest repo is already overwhelmed haha
16:09 MTDiscord  <luatic> On the Minetest repo
16:09 MTDiscord  <luatic> the branch is created on your repo though
16:09 MTDiscord  <luatic> but you click the button on the MT repo
16:09 MTDiscord  <exe_virus> Right, I wanted to avoid more branches on my repo, but I can do so going forward.
16:13 Pexin      wouldnt that make a PR into master? I was told not to do that
16:21 rubenwardy PR should be made targetting master
16:21 rubenwardy PR should be made _from_ master
16:21 rubenwardy PR shouldn#'t be made _from_ master
16:21 rubenwardy but GH will make a branch
19:00 sfan5      minetest doesn't seem to consider airlike nodes to be see-through for occlusion culling
19:00 sfan5      weird
19:28 MTDiscord  <FatalError> Why is github more complicated then the programming itself
19:28 MTDiscord  <FatalError> I dont even understand what that means ruben
20:36 sfan5      eh okay it checks light_propagates for that, which is set with paramtype = "light"
20:38 Krock      sunlight_propagates was a mistake. this should be filled automatically wherever possible
20:39 Krock      basically all drawtypes but "normal"
20:40 erle       uh oh
20:42 sfan5      well for debugging I want to make stone invisible without having it let through light
20:43 Krock      specify sunlight_propagates=false manually to overwrite the default .. that would be the idea
20:43 sfan5      well that's the thing
20:43 sfan5      light_propagates and sunlight_propagates are two different things
20:43 Krock      goddamn it
20:45 Krock      weird that this is differentiated at all
20:46 Krock      sight_propagates is the basic condition. sunlight_propagates further specifies whether the light level is lossy or lossless
20:47 Krock      at least according to voxelalgorithms.cpp
21:31 sfan5      I hope everyone here will be glad to know that Minetest 5.6.0-dev can still (mostly) load a map created in Minetest 0.3.1