Time Nick Message 00:23 MTDiscord The only instance of that bug I've ever seen is the one in your screenshot, which I haven't reproduced locally yet. I'm not sure if I've got a 5.5.0 build lying around, and tbh it's a bit of a PITA to setup a build for a specific version... 12:02 rubenwardy Looks like 5.5.1 has half as many crashes as 5.5.0, but still 5x as many as other releases 12:02 rubenwardy on Android 12:11 rubenwardy Crashes per 1,000 devices: 1.57 (598.7% vs all previous releases) 12:15 rubenwardy aha 12:15 rubenwardy wait 12:16 rubenwardy 5.5.1 has 33% fewer crashes than 5.4.2 12:16 rubenwardy but then more than other versions before that 12:24 Zughy[m] sfan5: should I close this? I can't really understand https://github.com/minetest/minetest/pull/12040 12:25 erle Zughy[m] if you do that, what happens to #12226 then? 12:25 ShadowBot https://github.com/minetest/minetest/issues/12226 -- Switch spatial indexing library 12:26 erle as i understand it 12040 is to keep 12226 free of clutter. i don't get it tbh. 12:26 erle like you can put the stuff into different commits obv 12:30 sfan5 I don't think a PR is very useful if it just imports code that doesn't do anything 13:18 sfan5 rubenwardy: the mentioned fix is in here: #12378 13:18 ShadowBot https://github.com/minetest/minetest/issues/12378 -- [no squash] Random things by sfan5 13:43 sfan5 merging #12308 in a bunch 13:43 ShadowBot https://github.com/minetest/minetest/issues/12308 -- [no squash] More various commits by sfan5 13:46 erle sfan5 there is no review or approval on this from anyone though 13:46 sfan5 you are looking at the wrong PR 13:46 erle oh 13:46 erle i see 13:46 erle sorry 13:50 erle sfan5, https://github.com/minetest/minetest/pull/12378/commits/b13a2009fa15fca7ba34e2e28ff090fb60126152 is missing documentation. 13:50 sfan5 documentation where 13:51 erle in lua_api.txt on Settings interface 13:52 erle right now it only says that settings starting with secure. can't be set or am i looking at the wrong revision 13:52 sfan5 it indeed says that 13:53 erle then i suggest to add a line regarding the other things you made impossible 13:54 erle hmmm, does the leaves thing finally solve the holes in the ground for waving bushes? 13:55 sfan5 yes 13:55 erle nice 15:09 kilbith @x2048 I'm here 20:15 x2048 Merging #12364 in a few minutes 20:15 ShadowBot https://github.com/minetest/minetest/issues/12364 -- Force-update shadows when the world is changed by x2048 20:16 x2048 kilbith: are you still around? 20:20 x2048 Never mind 20:58 sfan5 so I just went through all 12 pages of issues tagged "Bug" and picked easy ones to fix 20:59 sfan5 (the results are in #12378) 20:59 ShadowBot https://github.com/minetest/minetest/issues/12378 -- [no squash] Random things by sfan5 21:19 erle what's with setmetatable https://github.com/minetest/minetest/pull/12378/commits/11eac0dcf8663999bc54350a889e5bf510d968af 21:20 erle will this break this mod? https://content.minetest.net/packages/theFox/metavectors/ 21:29 Zughy[m] Sfan is on fire today, nice! 21:30 Zughy[m] question: is quoting issues in the commit message enough to close them? Since the PR has no linked issue 21:30 Zughy[m] (but commit messages have) 21:31 sfan5 yes, it happens as soon as that commit is pushed into master 21:42 MTDiscord erle: No it won't? debug.[sg]etmetatable != [sg]etmetatable 21:43 MTDiscord Decent mods only use the latter 21:43 MTDiscord The former is more powerful though as it allows you to change the metatables of pretty arbitrary types (even primitives like nil, bools & numbers) 21:44 MTDiscord It is too powerful to be left alive :P 21:55 erle oh i see 22:20 kilbith @x2048 sorry missed you again 22:24 MTDiscord @x2048