Time Nick Message 07:07 MTDiscord rubenwardy: try disabling shaders 08:09 sfan5 its possible that the code is not active without shaders but that's not the solution 09:55 MTDiscord sfan5: what about making the serverlist support server banners? 09:56 sfan5 theres an issue for this 09:56 MTDiscord yes 09:56 MTDiscord https://github.com/minetest/serverlist/issues/51 09:58 MTDiscord The main issue I still see is what ruben pointed out: "A problem with any approach is moderation, we don't want nsfw or illegal images to appear" 10:10 sfan5 does anyone know where hecks posted his design ideas for a mainmenu 10:10 sfan5 I remember there being some but can't find them 10:49 erle the problem is also that different things are illegal or frowned upon in different jurisdictions 10:55 erle like, many people know about the bans on nazi symbols. but then you have stuff like this: 10:55 erle https://www.theguardian.com/world/2017/mar/24/hungary-threatens-to-ban-heineken-star-logo-as-communist 10:55 erle > The famous red star logo of Dutch beer Heineken could be banned in Hungary under a government proposal seeking to prohibit the commercial use of “totalitarian” symbols. 10:56 erle as far as i know, it didn't come to that, but i doubt moderators want to keep up with bullshit like this 11:07 celeron55 "any approach" is a bit wrong. contentdb could host server banners and moderation would be enabled that way 11:08 celeron55 but it seems like a lot of work for such a small thing 11:08 celeron55 plus, moderators literally don't know what symbols are illegal in some country 11:09 celeron55 what if the server banners were super pixelated, like 16x8 pixels 11:10 celeron55 it would look visually interesting, but you couldn't represent anything at a resolution that would matter legally or socially 8) 11:10 celeron55 best use could be to place some common biome colors there or whatever, basically a favicon 11:11 celeron55 (i mean, 16x16 favicon of the olden times) 11:11 erle i like 16×16 (but then it is because unifont) 11:12 erle also, come on: 16×8 is totally enough for 卐 or ☭ or a stylized winnie the pooh 11:13 erle maybe the fear is too big after all and it should be tried? 11:13 Zughy[m] the intent is to offer something MC doesn't have, so a banner. They already have icons. Aim higher and focus on the policy 11:13 erle after all, websites have icons 11:13 erle as celeron55 pointed out 11:15 Zughy[m] also, please avoid sharing your stream of thoughts, it floods the chat for nothing. You're everywhere, erle 11:15 erle Zughy[m] any policy aiming at being as non-offensive as possible leads to uninteresting places. all the interesting memes are not created on facebook. 11:15 erle ok 11:16 erle Zughy[m] say, technically, could the main menu be modified by a mod? 11:16 Zughy[m] you can write your own implementation in Lua 11:17 Zughy[m] that's what the people working on my prototype are doing 11:17 erle show and tell? 11:17 erle like which issue 11:17 Zughy[m] ? 11:18 MTDiscord erle: not by a mod, but by a mainmenu script 11:19 MTDiscord the setting is main_menu_script; I suppose a mod could in fact leverage this (LMAO) by setting that to one of it's own paths 11:19 erle luatic then the idea “make a mod for server pictures and host it on contentdb” is not feasible rn ig 11:19 MTDiscord wait, could this be an option to exit the sandbox? 11:20 erle oh 11:20 MTDiscord main_menu_script is not a secure setting 11:20 erle are you saying there is a chance 11:20 MTDiscord well well let's find out :D 11:20 erle thanks luatic, i like where this is going! 11:24 sfan5 can you discover security relevant issues before a point release next time 11:28 MTDiscord I just discovered this spontaneously 11:28 MTDiscord BTW it works marvelously 11:28 MTDiscord Minetest even loads the script after you exit the game 11:28 MTDiscord That is, games can actually change the mainmenu :D 11:28 MTDiscord The feature always existed 11:29 MTDiscord I could literally release a mod changing the mainmenu 11:29 MTDiscord I feel the mainmenu API is hardly secured, but I have to test this 11:29 sfan5 the mainmenu API is not secured 11:30 MTDiscord oof 11:30 MTDiscord should I open an issue then? 11:31 MTDiscord I actually quite like the feature, it allows for easy mainmenu installation 11:31 MTDiscord "feature" 11:31 erle you should release a mod that changes the main menu obviously 11:31 sfan5 disclose it by the security policy 11:32 MTDiscord well, it's to late for privately disclosing it now 11:32 MTDiscord too* 11:32 MTDiscord I suppose I should send the code to reproduce this just to ruben and celeron55 though 11:32 sfan5 that is a fallacy 11:32 erle isn't the code just “set a setting from a mod” 11:32 erle like one line 11:32 MTDiscord two lines 11:33 MTDiscord sfan5: so should I file an issue now or write an e-mail? 11:33 sfan5 email 11:34 sfan5 or PM it, doesn't make a difference for that measure 11:38 MTDiscord alright, email sent 11:38 MTDiscord Oh great, ruben's mail is full: rubenwardy@minetest.net: SMTP error from remote server for TEXT command, host: mx.yandex.ru (77.88.21.249) reason: 552 5.2.2 Mailbox size limit exceeded 1653133082-umdSG88cZI-c2dO3f7X 11:39 definitelya Zughy[m]: Hi, in regards to the concern raised in #6733 over your aqua fonts, you could add an indent to them, like the way you styled the Favourites and Recents icons in the Multiplayer tab. 11:39 ShadowBot https://github.com/minetest/minetest/issues/6733 -- Improve mainmenu [See proposal] 11:46 definitelya Also, I love the design, thanks for the huge mockup work you did! 12:29 sfan5 2022-05-21 14:29:05: ERROR[Main]: .../src/script/cpp_api/s_base.cpp:9b: static int ScriptApiBase::luaPanic(lua_State*): A fatal error occurred: LUA PANIC: unprotected error in call to Lua API (bad argument #3 to '?' (string expected, got table)) 12:29 ShadowBot https://github.com/minetest/minetest/issues/3 -- Furnace segfault 12:29 sfan5 now wtf would this mean 12:35 erle i have had this bug with a recent built too, but i could not reproduce it 12:36 erle sfan5 is it reproducible for you? 12:38 sfan5 it is but it doesn't really make sense to me 12:41 sfan5 I may have forgotten to build after changing revision 12:47 erle so how do you reproduce it? i still have the binary that sometimes has it 12:47 rubenwardy No security issues if my mail box is full *taps forehead* 12:48 sfan5 you reproduce it by moving over certain revisions without rebuilding, in other words: user error 13:25 sfan5 rubenwardy: if you use the sdl backend I hope you never have to enter a _ 13:26 rubenwardy Feels like the start of a joke 13:26 sfan5 it just doesn't work 13:27 sfan5 doesn't exactly work well for a punchline 13:28 erle sfan5 oh, does it mean “builtin does not match the engine code” produces the bug? or is it another dependency error? 13:28 sfan5 yes to the first 13:29 erle well, the thing is, i think i got it with a git pull and a full rebuild (as full as i could) 13:29 erle so if you could tell me which part of builtin it is i could try to debug it 13:30 sfan5 ec9f1575121e3b064b919bca7efddfa8b0fc4e65 13:30 erle thx 14:12 sfan5 does anyone have any complains if I pull in this commit https://github.com/minetest/minetest/commit/258b183775c75c84e89161276ba3ca5d1ff02b0c 14:12 sfan5 +t 14:32 erle sfan5 “Generally but also as a consequence of the last commit,” → ideally you should name the commit here 14:32 sfan5 well that no longer applies, I'd remove that part from the message 14:34 erle so what scenario exactly is this handling? the server unceremoniously crashing? 14:35 erle because i'm pretty sure i already made servers stop talking mid-sentence 14:35 erle and i always eventually timeouted 14:35 sfan5 it handles a scenario which probably does not exist yet 14:36 erle which would be the bookbanning implementation? 14:38 erle for context if someone reads this later https://github.com/minetest/minetest/pull/12280 14:40 erle sfan5 if the scenario does not exist and you are just careful i would add a comment to the code, or else some know-it-all will delete it later “since it can not happen” (and might not even be wrong). 14:40 erle same for this being preparation for future changes 14:43 sfan5 dont think that's necessary 14:44 MTDiscord Merging #12195 in a couple of minutes unless there are objections 14:44 ShadowBot https://github.com/minetest/minetest/issues/12195 -- Improve shadow filters by x2048 14:47 sfan5 rubenwardy: did you upload 5.5.1 to GP yet 15:09 rubenwardy Will do that now 15:09 rubenwardy Merging #12030 15:09 ShadowBot https://github.com/minetest/minetest/issues/12030 -- Deprecate game.conf name, use title instead by rubenwardy 15:09 rubenwardy In 10 15:10 rubenwardy I've built the Android build in a new folder, so I'll have the unmodified .so and such to be able to work out how to do stacktrace mapping 15:15 rubenwardy Done 15:18 erle Zughy[m] when you finally release your improved main menu, feel free to use this code so you can distribute it via CDB https://git.minetest.land/erlehmann/mainmenu_csm/src/branch/master/init.lua 15:18 erle Zughy[m] if you know a way to shutdown and restart the game, i can make it seamless 15:20 rubenwardy sfan5: OK, I've zipped up the lib dir that contains this path /app/build/intermediates/merged_native_libs/release/out/lib/armeabi-v7a/libMinetest.so 15:21 rubenwardy Google Play has accepted it 15:21 rubenwardy https://gist.github.com/rubenwardy/1f208e8f1540f7096513e190a1de0142 15:21 rubenwardy (result of `find . -name "*.so"`) 15:40 sfan5 yeah that should work 15:40 sfan5 as long as file(1) says that it contains debug symbols 15:42 sfan5 merging #12261, #12347, #12346, #12334 and the commit I mentioned earlier in 3 minutes 15:42 ShadowBot https://github.com/minetest/minetest/issues/12261 -- [no squash] Optimize JSON string (de)serialization routines by sfan5 15:42 ShadowBot https://github.com/minetest/minetest/issues/12347 -- Patch built-in Lua to bypass Android miscompile by paradust7 15:42 ShadowBot https://github.com/minetest/minetest/issues/12346 -- Make no_screenshot image more clear by Zughy 15:42 ShadowBot https://github.com/minetest/minetest/issues/12334 -- Fixes to android build. Add option to turn LuaJIT on/off for testing purposes by paradust7 15:42 rubenwardy libMinetest.so: ELF 32-bit LSB shared object, ARM, EABI5 version 1 (SYSV), dynamically linked, BuildID[sha1]=24e90770b258fe5be42b07d519b9fa34dea20431, stripped 15:42 rubenwardy so no 15:43 sfan5 maybe we disable debug info then, dunno 15:43 sfan5 the android build system should be thrown away 15:43 rubenwardy libMinetest.so: ELF 64-bit LSB shared object, ARM aarch64, version 1 (SYSV), dynamically linked, BuildID[sha1]=e1ddd61df953e554e1a3d15b6a213327d6b8ef9d, with debug_info, not stripped 15:43 rubenwardy ./native/build/intermediates/ndkBuild/release/obj/local/arm64-v8a/libMinetest.so 15:43 sfan5 are those two from the same folder? 15:43 rubenwardy no 15:43 rubenwardy that's a different folder 15:44 rubenwardy first was app/build/intermediates/merged_native_libs/release/out/lib 15:44 rubenwardy second is /native/build/intermediates/ndkBuild/release/obj/local/ 15:45 rubenwardy list of all .so dirs is here <+rubenwardy> https://gist.github.com/rubenwardy/1f208e8f1540f7096513e190a1de0142 15:45 sfan5 sounds like the latter are the right ones then 15:46 rubenwardy "The native debug symbols contain an unexpected file: arm64-v8a/libandroid_native_app_glue.a." 15:46 rubenwardy suppose I can just delete that 15:46 sfan5 yes 15:46 sfan5 it doesn't like .a or .o's, just the shared libs 15:48 rubenwardy it's accepted it 15:48 rubenwardy I've updated Releasing Minetest so I don't forget how to do it next time 15:49 sfan5 will force push since I messed up the last commit message (pressed return while editing) ._. 15:50 sfan5 done 15:52 rubenwardy oh interesting 15:52 rubenwardy GH now supports close as fix and close as not planned 15:59 sfan5 indeed 16:43 Pexin someone aware of any issues/PRs about making entities that "carry" a player standing on them instead of sliding out from under? My search expertise is weak and not working. 16:43 Pexin I'm thinking about moving platforms. 16:44 erle Pexin you mean the player is attached? 16:44 Pexin yes but no? 16:46 Pexin standing on moving platform, can walk normally on it. if jump, maybe movement of platform is retained by player, not sure. 16:46 Pexin the cases where i've seen the player "attached" to stuff did not allow local movement 17:19 sfan5 I was just wondering why some code did a certain thing and traced it back to a "simple fix" committed in 2012 17:19 sfan5 at least the commit message is useful 17:26 sfan5 and it turns out the fix no longer does anything 17:32 erle what is it though 17:32 erle you are being awfully unspecific 17:32 rubenwardy He's not asking a question, so probably isn't looking for direct advice 17:32 rubenwardy more "oh that sucks" 17:34 erle oh, i just thought it would be interesting to know which appendix was found this time. sometimes this leads to further ideas. 17:34 sfan5 you'll find out when I open a PR 17:34 erle (appendix, as in: the part that you can remove) 17:34 erle ok! 17:52 MTDiscord @rubenwardy I'd like to add dynamic shadows to the tomorrow's agenda to have a conversation in the group, but I don't have access to dev wiki. 17:52 MTDiscord There are three PRs 17:54 MTDiscord #12359 is about changing the defaults, presets and maybe the way it is configured 17:54 ShadowBot https://github.com/minetest/minetest/issues/12359 -- Default settings, presets and configuration for dynamic shadows by x2048 17:55 MTDiscord #12359 and #12364 are two controversial optimizations I'd like to have input on 17:55 ShadowBot https://github.com/minetest/minetest/issues/12359 -- Default settings, presets and configuration for dynamic shadows by x2048 17:55 ShadowBot https://github.com/minetest/minetest/issues/12364 -- Force-update shadows when the world is changed by x2048 17:57 rubenwardy are you looking for concept approvals or what? 17:58 rubenwardy as in, it's useful to have the questions pre-wrriten out 18:00 MTDiscord For #12357 and #12364 I'd like a yay/nay/make it an option vote. 18:00 ShadowBot https://github.com/minetest/minetest/issues/12357 -- Quantize light frustum calculations by x2048 18:00 ShadowBot https://github.com/minetest/minetest/issues/12364 -- Force-update shadows when the world is changed by x2048 18:53 sfan5 can we get some eyes on #12263 #12313 18:54 ShadowBot https://github.com/minetest/minetest/issues/12263 -- Fixes needed to use irrArray backed by std::vector by paradust7 18:54 ShadowBot https://github.com/minetest/minetest/issues/12313 -- Replace all uses of core::list with std::list by paradust7 18:56 Zughy[m] sfan5: is your latest PR related to #5939 ? 18:56 ShadowBot https://github.com/minetest/minetest/issues/5939 -- Allow servers to disallow bright sky underground for clients 18:58 sfan5 yes 18:58 sfan5 but I don't know why the issue suggests that it should be up to the server 18:59 rubenwardy agreed 19:22 Zughy[m] no idea, it's from 2017 and from Paramat, we'll never have an answer. How about linking it to the PR so it gets closed? ? 20:08 rubenwardy x2048: I've created accounts for you on both wiki. and dev. minetest.net, you should have an email for each 20:11 MTDiscord @rubenwardy thank you 20:15 rubenwardy luatic: deleted all emails, mailbox should be fixed now 20:15 rubenwardy should probably link to my rubenwardy.com email or https://rubenwardy.com/contact/ though 20:54 MTDiscord alright 21:04 erle luatic are you trying to make sure the feature gets removed or what 21:13 MTDiscord """feature""" 21:14 MTDiscord you're joking, right? 21:19 erle luatic, i asked you this morning how to change the main menu from a mod. you replied. i made a mod that changes the main menu to finally get some CSM stuff. 21:20 MTDiscord yes, but you should be aware that security always matters more than this 21:21 erle can't you just, i don't know, introduce a popup or so. 21:22 luk3yx "Measure your CPS by clicking this carefully placed button repeatedly!" 21:29 MTDiscord Why do you want to do it from a mod specifically? 21:34 erle to have a main menu mod on CDB 21:34 erle in particular, i believe that a) CSMs in main menu b) whatever Zughy[m] is cooking up could be distributed fast via CDB and also it would be a good way to try out several approaches 21:35 erle after all minetest has several inventory mods, why not several main menus 21:36 sfan5 I don't know if you are trolling or honestly interested in having a dumb discussion but go do it elsewhere 21:37 rubenwardy What's a good name for dynamic client information, such as resolution, dpi, and controls info? 21:37 rubenwardy was going to call it ClientInfo, but that already exists in server.h 21:37 sfan5 something something HID 21:48 rubenwardy Why is screen resolution a V2U32? Do you get screens more than 65536 pixels tall/wide? 21:49 rubenwardy imagine the FPS on that 21:50 rubenwardy I suppose the reason is because IVideoDriver 21:54 sfan5 will merge irr#101, irr#105, tag a new irrmt version, make minetest use it, merge #12263, #12313 soon 21:54 ShadowBot https://github.com/minetest/minetest/issues/12263 -- Fixes needed to use irrArray backed by std::vector by paradust7 21:54 ShadowBot https://github.com/minetest/minetest/issues/12313 -- Replace all uses of core::list with std::list by paradust7 21:54 ShadowBot https://github.com/minetest/irrlicht/issues/101 -- Make irrArray backed by std::vector by paradust7 21:54 ShadowBot https://github.com/minetest/irrlicht/issues/105 -- Remove core::list and replace uses with std::list by paradust7 22:12 sfan5 all done 22:14 MTDiscord Amazing. Thanks sfan5 ? 22:16 MTDiscord Regarding #11545, I am reviewing/testing it now and hit a couple of problems. 22:16 ShadowBot https://github.com/minetest/minetest/issues/11545 -- Animated particlespawners by velartrill 22:19 sfan5 thanks for testing :) 22:19 sfan5 make sure to write them down there, the author is very repsonsive 22:23 MTDiscord sure 22:37 sfan5 side effect: it's no longer possible to build the server with upstream Irrlicht 22:37 sfan5 ah nvm, that'd be with #12321 only 22:37 ShadowBot https://github.com/minetest/minetest/issues/12321 -- unordered_map instead of map for MapSectors by RichardTry 22:37 sfan5 but this is only a matter of time regardless 22:49 rubenwardy It's so annoying how GitHub reimplements the browser behaviour of restoring fields, it means I can't ctrl+shift+r to go to default 22:55 rubenwardy #12367 22:55 ShadowBot https://github.com/minetest/minetest/issues/12367 -- Add display info to minetest.get_player_information() by rubenwardy 22:56 sfan5 rubenwardy: on cdb do deleted packages just disappear entirely? 22:56 sfan5 would be nice if at least the author can view them 22:56 rubenwardy they're soft deleted 22:56 rubenwardy so they're in the db, but disappear 22:57 sfan5 well yes 22:57 sfan5 I can tell since my package count is still 3 22:57 rubenwardy there's also the ability to unpublish packages