Time Nick Message 07:32 Zughy[m] sfan5: can't answer on GitHub now, but the no screenshot image has no license at all on CDB. Don't content automatically become CC BY SA 3.0 when nothing is declared? Also because I didn't create the image in the first place 09:02 sfan5 contributions by the original author to Minetest implicitly become whatever license our documentation says 09:03 sfan5 but you can't just submit existing stuff that has unknown or no license for inclusion 09:14 celeron55 there needs to at least be explicit or implicit intention of the original author to license it appropriately. of course ideally the author should explicitly declare the exact license that suits MT, but that tends to be a bit too much of a hassle 09:16 MTDiscord @Warr1024 you were the one who contributed the no screenshot image to CDB right? 11:32 MTDiscord Roller, I think so... Was a long time ago ... 11:35 MTDiscord It's a derivative work of the original logo. What license was the original Minetest logo? 11:37 MTDiscord I would license it under the most free terms allowable under the constraints of the upstream work. 11:41 MTDiscord Looks like the original was by erlemann, according to the license file ... so this one is by elremann and me now. Looks like that file formatting isn't designed to credit multiple authors so it'll be interesting to see how that works out :-) 11:41 MTDiscord Looks like everything coming out of MT is CC-BY-SA 4 so that's what my no screenshot image must be too. 11:53 erle i made the original minetest icon 11:53 erle both the pixel art and the vector versions 15:55 MTDiscord Can someone take a look at #12336? It's one file and a -6,+2. 15:55 ShadowBot https://github.com/minetest/minetest/issues/12336 -- Fix lighting of upright_sprite entities by x2048 16:00 erle x2048 can you please add a “how to verify the bug” too? 16:01 erle it is not immediately obvious to me in what ways the lighting is broken 19:16 rubenwardy how do I actually build Irrlicht with SDL2? When I enable the flag in IrrCompileConfig.h, I get fatal error: 'SDL_video.h' file not found 19:16 MTDiscord I had to do it in a completely clean build folder for some reason to get it to compile 19:18 rubenwardy mt build dir or irrlicht build dir? 19:22 MTDiscord dunno, I have irrlichtmt at lib/irrlichtmt so it gets automatically built so both I guess 19:33 sfan5 rubenwardy: you need to remove CMakeCache.txt or your build folder (easier, if you have one) and reconfigure 19:48 erle sounds to me like there is an untracked dependency 19:50 sfan5 offer solutions, not problems 20:09 erle i have offered to work on a solution and i got the impression that neither my offer nor links to literature and tools (that can enable others to solve these things) were particularly appreciated. 20:15 Pexin erle: re #12336 I don't know what the original issue was, but one consequence of the bug this fixes, is billboards (noticably drawer icons) are dark purple at nighttime regardless of local light or enabling/disabling shadows 20:15 ShadowBot https://github.com/minetest/minetest/issues/12336 -- Fix lighting of upright_sprite entities by x2048 20:15 erle i'm not snarky to say “i told you so”, i'm snarky to remind you that the build system is a think that is fixable. 20:15 erle a thing 20:15 erle Pexin, i see thanks 20:18 MTDiscord erle: I added the description of the problem to #12336, thanks 20:18 ShadowBot https://github.com/minetest/minetest/issues/12336 -- Fix lighting of upright_sprite entities by x2048 20:19 MTDiscord Merging #12341 and #12336 in 5m 20:19 ShadowBot https://github.com/minetest/minetest/issues/12341 -- Fix lighting of the wield mesh by x2048 20:19 ShadowBot https://github.com/minetest/minetest/issues/12336 -- Fix lighting of upright_sprite entities by x2048 20:20 erle x2048 in mineclonia PRs we always have two instructions “verify the bug” and “verify the patch”, just to make sure that it is clear what is fixed. that was what i was thinking of. 20:20 erle x2048 have you thought about adding rendering tests against reference targets? 20:21 erle or is it prohibitive because software rendering will not do the thing? 20:26 erle x2048 i wonder, how hard would it be to render a scene with and without shaders and find meaningful diffs? 20:27 erle i ask because there were a bunch of these bugs already 20:31 sfan5 erle: in this case the dependency is known and cmake can be taught about it, none of what you're thinking about is required 20:32 MTDiscord erle: I have not thought about automated rendering tests yet, no. 22:21 rubenwardy hmm, opengl procedures error again on new build 22:22 rubenwardy I wonder if it's SDL