Time  Nick       Message
11:56 sfan5      anyone here?
12:00 celeron55  well, me
12:50 MTDiscord  <MisterE> Yes
13:08 sfan5      I suppose neither of you can make the android build for 5.5.1
13:08 erle       i suppose that means the CI can't do it either?
13:10 sfan5      dunno
13:40 Pexin      i assume superminor impact adjustments to 5.5.1 would at this point be unacceptable hassle
13:52 rubenwardy I can build it in an hour
13:52 rubenwardy Are you planning to include the LuaJIT version change?
13:55 ROllerozxa just noticed, shouldn't https://github.com/minetest/minetest/issues/8596 be closed now when it has been implemented by #11241?
13:55 ShadowBot  https://github.com/minetest/minetest/issues/11241 -- Allow for Game-Specific Menu Music by ExeVirus
14:01 rubenwardy Yes
14:16 sfan5      rubenwardy: sure, pulled it in
15:19 sfan5      rubenwardy: 40 is correct for the next versionCode right?
15:54 erle       what changed protocol-wise?
15:55 erle       or is this not about protocol?
15:55 rubenwardy that's the Android version code
15:55 rubenwardy I think we still do +2 ?
15:55 rubenwardy isn't there a comment?
15:59 sfan5      the script increases it by two but it has to be increased again if it was done in the meantime
15:59 sfan5      that is why I'm asking
16:00 rubenwardy yeah 40 is correct
16:00 rubenwardy 5.5.0 was 38+39
16:19 sfan5      windows builds uploaded
16:20 MTDiscord  <luatic> sfan5: did you grab the backport-5 branch for MTG?
16:27 sfan5      yes
16:38 sfan5      oh we could import translations for this release
16:38 sfan5      but I don't feel like doing it
16:47 sfan5      okay so except the android build, pushing the right tags/branches and doing release announcements there is nothing left
16:53 sfan5      android build is optional but it'd be good to know that it works
16:56 rubenwardy doing that now
18:52 sfan5      ...
19:34 MTDiscord  <x2048> Pushing https://gist.github.com/x2048/27826a45ef19183e06b0d43f141704a3 to master in 15 minutes. Fixes wield_image part of #12245.
19:34 ShadowBot  https://github.com/minetest/minetest/issues/12245 -- Wield images not colored correctly
19:47 rubenwardy https://github.com/rubenwardy/minetest/releases/tag/5.5.1-test
19:49 rubenwardy The version in android/build.gradle hasn't been updated, it's 5.5.0
19:52 sfan5      that was a manual step so I missed it
19:55 sfan5      rubenwardy: if the APKs work please put them in the drafted release on the minetest repo
19:55 rubenwardy well the version is wrong
19:56 rubenwardy argh, annoying bug. Pressing check on the text entry model closes it without entering the text
19:57 sfan5      I amended the commit so you'll have to rebuild
21:02 rubenwardy Done
21:07 sfan5      release time then
21:19 MTDiscord  <MisterE> Yay!
21:24 sfan5      rubenwardy: forum topic and website done; google play & twitter is up to you
21:25 MTDiscord  <MisterE> Should I make a blog post about it?
21:25 MTDiscord  <MisterE> or save it for the monthly release?
21:25 sfan5      I have no opinion on that
21:27 rubenwardy Done twitter and mastodon, just play to go
21:27 rubenwardy Idk about patch releases, but a dedicated post for minor/major releases makes sense
21:27 MTDiscord  <MisterE> This is a patch release?
21:28 MTDiscord  <MisterE> Does it include shadows?
21:28 rubenwardy Yes and no
21:28 MTDiscord  <MisterE> I would guess not?
21:28 rubenwardy It's bug fixes only
21:29 MTDiscord  <MisterE> ok. So not worth a post ig