Time Nick Message 02:45 erle x2048 did you test #12262 with anything else than the snow? 02:45 ShadowBot https://github.com/minetest/minetest/issues/12262 -- Avoid rendering invisible faces of simple nodeboxes by x2048 12:12 rubenwardy Has anyone heard from hecks? 12:13 sfan5 no 12:15 rubenwardy Talked big then *poof* 12:15 rubenwardy Maybe the rendering code scared them that much 12:15 rubenwardy Shame 12:19 erle rubenwardy sfan5 hecks has repeatedly posted screenshots from some anime-style game. is it on contentdb? if not, where can i try it out? 12:20 sfan5 it's nowhere 12:22 rubenwardy It's unrealised and is proprietary 12:23 sfan5 unreleased* 12:26 rubenwardy Oops yeah 12:26 rubenwardy My games are unrealised, his game is unreleased 12:34 erle and i thought i was a perfectionist 12:35 Zughy[m] "Documentation request / missing / error" is a redundant tag, replaceable either by "Action / change needed" or "@ Documentation". Can I delete that? Labelled issues/PRs show is basically unusued https://github.com/minetest/minetest/labels/Documentation%20request%20%2F%20missing%20%2F%20error 12:36 erle Zughy[m] i think it is relevant if the change needed is only documentation. a lot of stuff gets still approved without it, because it is not deemed necessary. do you have examples? 12:36 MTDiscord No, it is not quite replacable 12:37 sfan5 Zughy[m]: this is what I said once too but paramat wanted to keep it 12:38 sfan5 if it's on issues you have "Bug" / "Feature Request" / "Request / Suggestion" + "@ Documentation" 12:38 sfan5 and on PRs "Action / change needed" works (but is less specific) 12:38 MTDiscord ^ that's the problem 12:38 sfan5 quite logical to me so I don't know why we have this label 12:39 Zughy[m] erle: last time I checked you need to provide documentation to any PR 12:39 Zughy[m] (that introduces something, like a new API function) 12:43 Zughy[m] luatic: I don't think that's a problem, if an issue has "@ Documentation", it means there is someone asking to add/edit/remove some lines from the documentation. The other label is redundant 12:50 rubenwardy That label cannot be replaced by @ Documentation 12:51 rubenwardy @ Documentation is for when an issue/PR is primarily about documentation. For example, it's only a change to lua_api 12:52 rubenwardy A PR that adds a Lua API shouldn't be labelled with @ Documentation, but should update the documentation 12:52 rubenwardy I added "Documentation needed" because people kept forgetting to do this. It was later changed by paramat into its current form 12:52 rubenwardy The label could be replaced by "Action/change needed" though 12:54 rubenwardy I'd say delete it and use Action/change needed instead 12:55 Zughy[m] two approvals, going for it 12:56 rubenwardy regarding labels, make sure to read through the roadmap approval label before the meeting: https://github.com/minetest/minetest/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+label%3A%22Roadmap%3A+Needs+approval%22 12:57 rubenwardy if you've started to review something, it's probably worth saving 12:59 rubenwardy aha 12:59 rubenwardy https://github.com/minetest/minetest/pulls?q=is%3Apr+sort%3Aupdated-desc+label%3A%22Roadmap%3A+Needs+approval%22+reviewed-by%3A%40me+is%3Aopen 12:59 rubenwardy this one lists the PRs you've reviewed 13:00 erle Zughy[m] i might be mistaken, but i am under the impression that when something is changed that was never documented well or at all, few people require documentation changes to approve it. for example the change to autoforward in 5.5 (you can no longer go left or right while autoforwarding) was never documented outside of the issue tracker i think, but the documentation never said anything about the left or right key, only the 13:00 erle back key (which stops autoforward). IMO the whole “if it is not documented, we can change it” should be changed to “if you change something undocumented that is observable to players, either explicitly note in the documentation that it is undefined or document it”. 13:02 rubenwardy also, trivial PR: #12115 13:02 ShadowBot https://github.com/minetest/minetest/issues/12115 -- Default chat clickable weblinks by Froggo8311 13:21 Zughy[m] nevermind, I can't edit/delete labels, can someone of you do it? 13:23 rubenwardy done 14:44 sfan5 clients that stand around doing nothing seem to constantly generate emerge requests that end up cancelled 14:44 sfan5 the wonders of adding metrics to code 14:46 sfan5 or only if they have interacted before? 14:52 sfan5 standing around underground appears to be the condition 14:57 erle does this apply to a specific game, or generally? 14:57 erle like, ig the emerges are cancelled bc there is already something there 15:04 sfan5 dunno 15:29 erle 21:33 Zughy[m] about the "Maintenance" label that shouldn't be a macrocategory (so "@ Maintenance"): issues like #11667 are really just Maintenance 21:33 ShadowBot https://github.com/minetest/minetest/issues/11667 -- Github CI: Reduce compilation times with ccache 21:33 erle Zughy[m] which component is “maintenance”? 21:33 Zughy[m] or #12226 21:33 ShadowBot https://github.com/minetest/minetest/issues/12226 -- Switch spatial indexing library 21:34 erle Zughy[m] can you tag #11667 with a label that makes clear this is a bogus request? 21:34 ShadowBot https://github.com/minetest/minetest/issues/11667 -- Github CI: Reduce compilation times with ccache 21:34 erle ccache can only be used if you have reliable incremental builds 21:34 Zughy[m] I'll answer you with another question erle: what component are those two? 21:34 erle no idea 21:36 erle the ccache manual even says that it is unreliable https://ccache.dev/manual/latest.html#_the_direct_mode