Time  Nick      Message
16:22 MTDiscord <luatic> I'm pretty sure the debug whitelist is way too permissive and effectively allows trivially exiting the sandbox if another mod holds an insecure environment. The following functions are currently whitelisted: "gethook", "traceback", "getinfo", "getmetatable", "setupvalue", "setmetatable", "upvalueid", "sethook", "debug", "setlocal". "setupvalue" and "setlocal" can be used to interfere in "private" mod code, tricking "secure" mods into
16:22 MTDiscord leaking their environments. "debug.setmetatable" can be used to execute code in a "__gc" metamethod after a crash.
16:23 MTDiscord <luatic> But please, don't take this away from me, it allows me to change to font on runtime for my game
16:23 MTDiscord <luatic> And to correctly reset it afterwards, even if the game crashes
16:31 sfan5     you need setupvalue and setlocal for that?
16:33 MTDiscord <luatic> No, not for that. I only need setmetatable for that, but I'm sure debug.getmetatable / debug.setmetatable is pretty exploitable too as it ignores the __metatable field.
16:35 sfan5     does it allow touching userdata objects
16:37 MTDiscord <luatic> Yes
16:38 erlehmann > But please, don't take this away from me, it allows me to change to font on runtime for my game
16:38 erlehmann wouldn't it be easier to make that into a thing
16:38 erlehmann if you are consolidating font api anyways
16:38 erlehmann games being able to set fonts
16:39 erlehmann (overridable by the user of course otherwise stuff becomes unreadable)
16:39 erlehmann luatic which sandbox are you referring to?
16:39 MTDiscord <luatic> The insecure environment sandbox
16:40 MTDiscord <luatic> I'm getting very weird behavior here...
16:40 MTDiscord <luatic> If I remove my hack, it segfaults, lol
16:40 MTDiscord <luatic> But it also seems to work without part of the hack
16:41 MTDiscord <luatic> Yay relying on undefined behavior
18:24 sfan5     #11867
18:24 ShadowBot https://github.com/minetest/minetest/issues/11867 -- [no squash] Mod security improvements by sfan5
23:10 sfan5     I think we should cut down on the number of PRs by merging all of mine ;)
23:12 MTDiscord <Jonathon> thats only 10
23:13 MTDiscord <Jonathon> of which you technically have conflicts
23:17 erlehmann fixing those will only make me file new bugs
23:18 erlehmann you can't win this battle!
23:18 erlehmann also, as you said yourself: if you fix one bug, ppl demand you fix others as well
23:18 erlehmann ^^
23:19 MTDiscord <Jonathon> i think your going to spam the issue list no matter what erlehmann, so whatever anyone does at this point in relationship to you is irrelevant
23:19 erlehmann i was kinda joking
23:20 MTDiscord <Jonathon> anyways, sfan5: curious if that debug log was helpful at all?
23:20 erlehmann but i did notice that whenever i try to find bugs i end up filing like 5 or 10 at a time
23:20 erlehmann which is exhausting for everyone involved, so i try to not do it
23:20 erlehmann unless something really goes on my nerves
23:21 sfan5     @Jonathon sort of, I need to do some stuff for further analysis and haven't gotten to that yet
23:21 sfan5     well actually s/sort of/yes/
23:21 sfan5     it contained a clue so it was useful
23:22 MTDiscord <Jonathon> ah ok, thank you