Time  Nick      Message
06:28 MTDiscord <fatalerror420> i dont even know tbh
21:10 MTDiscord <josiah_wi> irr#84
21:10 ShadowBot https://github.com/minetest/irrlicht/issues/84 -- Restore some unit tests by JosiahWI
21:10 MTDiscord <josiah_wi> The time has finally come.
21:23 MTDiscord <Sublayer plank> did irrlicht have any unit tests for the 3d modes?
21:24 MTDiscord <josiah_wi> I'm not familiar enough with what 3d modes are.
21:25 MTDiscord <Sublayer plank> red-green 3d anaglyph for example. it broke in minetest particularily along with the upgrade to irrlicht 1.9.0 as part of irrlichtmt I believe
21:28 erlehmann the problem with irrlichtmt is the lack of history
21:28 erlehmann can it be rebased?
21:35 MTDiscord <josiah_wi> @ROllerozxa Do you know which part of Irrlicht that would be in? Most of the tests are organised into very broad categories. e.g. testing the line class, testing matrices, testing the color class...
21:36 MTDiscord <josiah_wi> Lol, there were over 200 changed files, and now that I removed the unused media I accidentally committed, it's down to 30. Much more reasonable.
21:37 MTDiscord <josiah_wi> ROllerozxa, if the 3d mode stuff was tested, it was probably done so indirectly through the scene tests? We removed most of the scenes anyway, and those tests were based on a pretty fragile "check against a reference image we have" system.
21:39 MTDiscord <Sublayer plank> I don't really know where the 3d mode code would be in irrlicht. maybe somewhere in the video driver?
21:40 MTDiscord <josiah_wi> Yeah... I would bet that was tested then, but that we don't have the scenes required to run those tests anymore.
21:47 MTDiscord <Sublayer plank> oh I was about to mention the extreme amounts of unnecessary test media in the PR but I guess you had it under control :P
21:49 MTDiscord <josiah_wi> Nah, still learning the ropes here.
21:50 MTDiscord <josiah_wi> C++ question: are my does bitwise and not work quite like you'd think with true and false booleans?
21:51 MTDiscord <josiah_wi> Sorry for the bad English there - my thought process changed and I was done before I realised what happened.
21:51 MTDiscord <josiah_wi> I'm trying to repeatedly "sum up" test results by doing "result &= testResult()" and it seems like something isn't working there.
21:57 MTDiscord <luatic> Your aggregation is correct. If you want to determine if no test failed, you can just "and" all the test results.
22:13 MTDiscord <josiah_wi> Ah, I had written the test incorrectly again.
22:13 MTDiscord <josiah_wi> Now I just have to deal with MacOS, which I am not looking forward to.
22:45 sfan5     the 3d mode code is in minetest, it broke inside irrlicht but it's something more subtle
22:53 MTDiscord <exe_virus> oof, Someone (me) missed a change to lua_api.txt and it got merged. The underlying code doesn't exist so it's just a removal of those two lines from the document: https://github.com/minetest/minetest/pull/11241 Line number: https://github.com/minetest/minetest/blob/1c5ece8334d050379eb99fe2ead52f9f4db44249/doc/lua_api.txt#L5668