Time Nick Message 18:15 Krock Will merge #9249, #9847, #11770 and #11793 in 15 minutes 18:15 ShadowBot https://github.com/minetest/minetest/issues/9249 -- Minimap: gamma-correct average texture colour calculation by HybridDog 18:15 ShadowBot https://github.com/minetest/minetest/issues/9847 -- Add bitop library by Lejo1 18:16 ShadowBot https://github.com/minetest/minetest/issues/11770 -- Fix find_nodes_in_area misbehaving with out-of-map coordinates by sfan5 18:16 ShadowBot https://github.com/minetest/minetest/issues/11793 -- Remove unused error when attempting to enable shaders with Direct3D video driver selected by rollerozxa 18:27 rubenwardy that'll bring us down to 99 PRs, awesome 18:28 Krock 69 would be nice tho 18:28 rubenwardy yeah, 69 > 99 18:30 Krock merging 18:33 Krock done 18:34 rubenwardy easy documentation PR: 9853 18:34 rubenwardy #9853 18:34 ShadowBot https://github.com/minetest/minetest/issues/9853 -- pauloue's ItemStack example by FreeLikeGNU 18:35 rubenwardy #10492 is also fairly easy and has been open for a while 18:35 ShadowBot https://github.com/minetest/minetest/issues/10492 -- Implemented disconnect_player by IceDragon200 18:38 kilbith too bad we can't overload << & | >> with metatables 18:46 rubenwardy merging #10492 in 10 18:46 ShadowBot https://github.com/minetest/minetest/issues/10492 -- Implemented disconnect_player by IceDragon200 18:53 kilbith only way I see to use native bitops is to load a Lua file as string and perform some global substitutions on the bitops 18:58 MTDiscord or upgrade to lua 5.3? 18:58 MTDiscord nono 18:58 MTDiscord Just wait until lua 5.6 when it reaches JIT speed 18:59 MTDiscord actually how large are the incompatibilities between 5.1 and 5.4? 18:59 kilbith 5.4 sucks 19:00 kilbith `local foo ` could have just been `const foo` 19:01 kilbith and Mike Pall is the last gatekeeper of the Lua language 19:01 rubenwardy yeah, I hate <> notation 19:02 MTDiscord just fork to mtlua and backport bitwise operators 19:02 rubenwardy I suspect the reason is that const is a valid variable name, so it would assignment to globals 19:02 rubenwardy +break 19:03 kilbith we did fork LuaJIT at EvidenceB/Kidscode, to make it impossible to decrypt the bytecode 19:09 nrz_ if you encrypted it , it should be decrypted to be interprted, then you can decrypt it, the key shouuld be in binary or something i think no ? 19:10 rubenwardy I suspect they're referring to obscurification 19:10 kilbith I'll certainly *not* explain how it works 19:11 nrz_ blizzard encrypts their builds too before they make publically available and strangely everyone find a way to decrypt them :p 19:11 MTDiscord that requires some efforts at least 19:12 rubenwardy it's an odd decision for singleplayer as modding breathes so much life into games 19:12 rubenwardy but for multiplayer and student software \o/ 19:18 MTDiscord once ruben merges his, that will be 5 prs in a day, most in a while 19:19 rubenwardy thanks for reminding me 19:20 rubenwardy I think we had 6 merges in Oct 31, 2021 19:20 rubenwardy or 5 19:20 rubenwardy there's a few non-squashed commits, I think it's 6 19:21 rubenwardy certainly a while 19:21 rubenwardy #11746 19:21 ShadowBot https://github.com/minetest/minetest/issues/11746 -- Update to Android target SDK 30 by rubenwardy 19:50 MTDiscord "69 > 99" - well yes, but actually no 21:10 sfan5 rubenwardy: did you test that it works without a permissions request 21:10 sfan5 (it should but just to be sure) 21:11 rubenwardy I tested it on Android 12 and it worked 21:11 rubenwardy I don't have access to any other phones than this one 21:12 rubenwardy I've built a build, I can upload it 21:12 sfan5 please do 21:16 rubenwardy https://github.com/rubenwardy/minetest/releases/tag/android-30-2 21:18 erle_annoyed FYI: i just encountered an assertion failing due to the merge of #11770 in the code of the (previously-working) lua workaround for exactly the bug that PR is supposed to fix. i will of course adjust my code, but the assertion was basically “can minetest be trusted to find all the nodes that it can place?”. congratulations, you now have an 21:18 erle_annoyed engine that can place nodes but then fail to find them. have fun with the little bugs it will cause for years. 21:18 ShadowBot https://github.com/minetest/minetest/issues/11770 -- Fix find_nodes_in_area misbehaving with out-of-map coordinates by sfan5 21:18 sfan5 yep works 21:18 erle_annoyed sfan5 sorry for not having filed the other bug yet, i am on holidays. is it important to you that i do it fast? 21:18 erle_annoyed the one with the upright sprite not being rendered 21:19 sfan5 ah 21:19 sfan5 nah, no hurry 21:19 erle_annoyed (i have not yet reproduced it outside mcl2/mineclonia) 21:19 erle_annoyed ok 22:22 kilbith oh no, not him again 22:23 MTDiscord you talking 'bout yourself? 23:19 erle_annoyed sfan5 is there a reason, why the networking code contains no explicit null pointer checks except “hasn't visibly blown up yet”? 23:21 sfan5 that is too vague to answer 23:40 erle_annoyed to be more specific 23:40 erle_annoyed src/network/networkpacket.cpp:556:8: runtime error: null pointer passed as argument 2, which is declared to never be null 23:40 erle_annoyed src/network/networkpacket.cpp:66:8: runtime error: null pointer passed as argument 1, which is declared to never be null 23:52 rubenwardy merging #11746 in 10 23:52 ShadowBot https://github.com/minetest/minetest/issues/11746 -- Update to Android target SDK 30 by rubenwardy