Time  Nick       Message
14:25 sfan5      merging game#2897, game#2902 in 10m
14:25 ShadowBot  https://github.com/minetest/minetest_game/issues/2897 -- Improve Russian translation by ptah-alexs
14:25 ShadowBot  https://github.com/minetest/minetest_game/issues/2902 -- Readd character.b3d normals by appgurueu
14:40 sfan5      uh
15:22 sfan5      rubenwardy: do you have time to the android fix this weekend?
15:22 rubenwardy as in, release the version?
15:22 rubenwardy or has issues been found
15:22 rubenwardy *have
15:22 sfan5      uh yeah forgot a word: it's "release"
15:23 sfan5      don't even need to be 5.4.2 and all that, I suggest we just leave it untagged
15:24 rubenwardy Android has a fourth number I believe
22:10 Danilo82   Hello, could you guys make a better documentation on building minetest?, its really confusing right now
22:23 sfan5      which part in particular are you having problems with?
22:25 Danilo82   there is an explanation about compiling irrlicht and minetest but nothing about using irrlicht in minetest
22:30 Lone_Wolf  Are you on Windows or Linux?
22:30 Lone_Wolf  And do you mean compiling Minetest with Irrlicht? Or something else?
22:30 Danilo82   linux
22:31 Danilo82   IrrlichtMt
22:31 cheapie    IrrlichtMt is just a build-dep for MT itself - there shouldn't be any extra steps to "use" it, CMake for MT should just find it as long as you installed it.
22:32 Danilo82   i cloned minetest and irrlicht, but i dont know how to tell minetest to use the irrlicht code
22:33 Lone_Wolf  Have you tried compiling Minetest without telling it where Irrlicht is? It should find it if you put it in the right place with the right name
22:33 MTDiscord  <Jonathon> put it in minetest/lib
22:33 Lone_Wolf  The README.md instructions will git clone it into the proper place
22:33 sfan5      the easiest way to do that is cloning irrlicht to lib/irrlichtmt (should also be mentioned in the instructions), did you do that?
22:35 Danilo82   i clone irrlicht into minetest/lib/irrlicht?
22:37 Lone_Wolf  Yes
22:38 sfan5      lib/irrlichtmt
22:39 Lone_Wolf  oop, wonder if it would still have detected it
22:43 Menchers   CMake found the CMake configuration file for IrrlichtMT that told it where to find the library and include files
22:44 Menchers   I installed irrlicht to $HOME/.local
22:45 Menchers   minetest's CMake build scripts found it in $HOME/.local/lib/cmake/IrrlichtMt
22:46 MTDiscord  <josiah_wi> You probably have to set a variable for that to work because $HOME/.local isn't on CMake's search paths by default (afaik).
22:46 Menchers   huh
22:46 Menchers   it worked without intervention for me
22:47 MTDiscord  <josiah_wi> Interesting. Well, that's convenient in any case. xD
22:47 MTDiscord  <josiah_wi> It should also be possible to point Minetest directly to an Irrlicht build with a variable now, if that got merged.
22:48 Menchers   yeah I thought there were variables named something like IRRLICHT_LIBRARY and IRRLICHT_INCLUDE_DIR for manually pointing to the stuff
22:48 MTDiscord  <josiah_wi> The general concensus here seems to be that that's much more convenient/secure than installing IrrlichtMt.
22:48 Menchers   I just see IrrlichtMt_DIR now though
22:49 Menchers   which wants the CMake configuration file
22:49 Menchers   to be more exact, it wants the directory containing the CMake configuration file
22:49 MTDiscord  <josiah_wi> Yeah. I made a PR to add IRRLICHTMT_BUILD_DIR but it might not be merged yet.
22:50 MTDiscord  <josiah_wi> It will also find the configuration file, but IrrlichtMt doesn't have to be installed for it to work; it grabs it directly from the build tree.
22:50 Menchers   huh IrrlichtMt_DIR breaks the all caps convention for CMake variables
22:50 MTDiscord  <josiah_wi> That's because it's an internal advanced variable.
22:51 Menchers   several other libraries still have _LIBRARY and _INCLUDE_DIR variables
22:51 MTDiscord  <josiah_wi> Uh, my PR hasn't been merged, and it also adds documentation explaining exactly what the options are for helping Minetest find IrrlichtMt, so it would probably answer Danilo's request.
22:51 MTDiscord  <josiah_wi> I have one approval.
22:51 Menchers   json, freetype, sqlite3
22:52 MTDiscord  <josiah_wi> Menchers, those libraries don't use configuration files so their variables are different.
22:52 MTDiscord  <josiah_wi> #11656
22:52 ShadowBot  https://github.com/minetest/minetest/issues/11656 -- Add variable to use existing IrrlichtMt build by JosiahWI
22:55 Danilo82   now it works