Time Nick Message 03:29 wsor4035 v-rob: around? 03:30 v-rob Yeah 03:30 wsor4035 re https://github.com/minetest/minetest/issues/11669 03:30 wsor4035 what is the issue with allowing formspecs to touch the border but not exceed them? 03:32 v-rob Modders can't portably choose a formspec size that will not touch the screen borders. It differs from computer to Android (10 vs 15), so the 90% makes sure that, whatever the form size, it won't touch the edges. So, it actually isn't a matter of modders being able to choose a form size that doesn't touch the borders. 03:33 v-rob It is possible to add an option. For instance, there's anchor[] and position[], so it probably wouldn't be too hard to add a padding[] that sets the padding around the form. So, padding[0,0] would make it touch the screen edges 03:33 v-rob padding[0.9,0.9] would be the default 03:34 v-rob Still, regardless of a padding setting, there's still no way to make the formspec take up the whole screen space since aspect ratios differ. 03:34 v-rob It will touch the edges, but only in one dimension. 03:35 v-rob Unless you have the perfect screen size for that one formspec 03:35 wsor4035 so basically it falls back to your pre emptively deciding that "touching borders bad" for everyone. 03:35 v-rob Why not? It's a good default 03:35 wsor4035 maybe for your cases, but not arbitrarily forcing it on everyone 03:36 v-rob Should we arbitrarily force "touching borders good" 03:36 v-rob ? 03:36 v-rob Either one is arbitrary 03:36 wsor4035 that was the default since forever? 03:36 v-rob Neither of these was the default. The default was "let the formspec be bigger than the screen" 03:36 wsor4035 well, if to big it went out of bounds 03:37 wsor4035 well anyways, as you suggested, a padding to change from 0.5 all around to nothing would resolve the issue 03:37 wsor4035 *padding[] 03:37 wsor4035 rather than it being hard coded 03:37 v-rob Yeah, I can make a PR without too much trouble 03:38 wsor4035 seems a simple enough solution it would be fine for 5.5 still? 03:39 v-rob I think it probably could, we aren't in feature freeze or anything 03:39 wsor4035 ah, as the issue is 5.5 tagged 03:39 wsor4035 thanks 03:40 v-rob Cool, glad that got worked out 03:40 wsor4035 let me grab a link from the logs and post it in github 03:43 wsor4035 done 09:52 sfan5 easy reviews -> #11515 #11646 #11671 #11666 09:52 ShadowBot https://github.com/minetest/minetest/issues/11515 -- Add "MINETEST_MOD_PATH" environment variable by emixa-d 09:52 ShadowBot https://github.com/minetest/minetest/issues/11646 -- [NO SQUASH] Content store: extract ZIPs asynchronously by sfan5 09:52 ShadowBot https://github.com/minetest/minetest/issues/11671 -- Add minetest.get_server_max_lag() by Wuzzy2 09:52 ShadowBot https://github.com/minetest/minetest/issues/11666 -- Make MetaDataRef:get() return nil instead of nothing by TurkeyMcMac 19:13 MTDiscord Can someone point me to a PR or issue that explains why we don't have a way for server backends at the Lua mod level to know client minetest viewport width and height for formspecs? 19:18 MTDiscord https://github.com/minetest/minetest/issues/10393 Explanation: paramatted 19:27 specing > think that DPI, gui scaling, and operating system should be made available at bare minimum. That information never changes in the course of gameplay, 19:27 specing imagine playing on high DPI phone then moving mt to low DPI external screen 19:43 Krock will merge #11675, #11668 and #11672 in 10 minutes 19:43 ShadowBot https://github.com/minetest/minetest/issues/11675 -- List only jpg and png as screenshot format options by HybridDog 19:43 ShadowBot https://github.com/minetest/minetest/issues/11668 -- Reduce shadow jitter by lhofhansl 19:43 ShadowBot https://github.com/minetest/minetest/issues/11672 -- Fix crash if calling minetest.[remove|ban|kick]_player on startup time by Wuzzy2 19:52 Krock merging 20:18 sfan5 I imagine DPI-adjusted viewport would be most useful 21:04 MTDiscord meh, let modders decide. If they change screens mid-game, then the modder will see that change updated (hopefully), and can send a different formspec. It only affects the currently displayed formspec. Alternatively, we could extend container[] elements to be optionally displayed if they pass certain criteria.... 21:04 MTDiscord i.e. container[max_width=500, max_dpi = 72] stuff end[] 21:07 MTDiscord given how much of a mess formspecs is, and that it supposedly will be replaced, seems easier to just expose that information to modders and let them do what they want with it rather than investing significant time into something eventually will be removed(when a alternative exists) 21:08 MTDiscord *alternate solution 21:18 MTDiscord 96dpi is standard on all systems since Vista 22:09 MTDiscord Mobile too? 22:17 MTDiscord not mobile