Time Nick Message 00:26 DS_ irr#55 00:26 ShadowBot https://github.com/minetest/irrlicht/issues/55 -- Fix X11 selections by Desour 00:26 DS_ please test your stuff 11:00 pgimeno I'd suggest to place inserted lines 1064-1113 from irr#55 in a switch statement; it would save some vertical space and be better factored 11:00 ShadowBot https://github.com/minetest/irrlicht/issues/55 -- Fix X11 selections by Desour 11:09 pgimeno I mean something like this: http://www.formauri.es/personal/pgimeno/pastes/irr55_switch.c 11:17 pgimeno that's more future-proof too, easier to add other string types, and there may be more 11:21 pgimeno see for example the output of "Programm 4: Inhaltstyp TARGETS" here: https://www.uninformativ.de/blog/postings/2017-04-02/0/POSTING-de.html - I don't understand German but it seems to me that GTK is setting all these clipboard types. COMPOUND_TEXT might be a target. 11:23 pgimeno style wise, I'd rename "X_ATOM_UTF8_STRING_2" to "X_ATOM_UTF8_MIME_TYPE" 13:46 DS_ pgimeno: Thanks! Using switch doesn't work there as the X_ATOM_* variables are no constant expressions. (I've tried that yesterday already.) COMPOUND_TEXT looks a bit complicated, do we really need to support that? I haven't seen any application yet that doesn't support anything else. I think I've messed up character encodings, I'll fix that. 13:46 pgimeno uh 13:47 pgimeno hmm then what are they? 13:47 * pgimeno checks 13:48 sfan5 variables 13:49 pgimeno oh rats, switch does not accept variables >.< 13:49 pgimeno I've been away from C for too long :) 13:50 pgimeno in that case, I guess that joining the conditions into one would be best 13:51 DS_ you mean one if branch instead of multiple ones? I think I did that 13:52 pgimeno maybe, I guess I didn't pay enough attention to the other commits 13:52 DS_ btw. should I change the #includes to include the C++ headers instead of the C ones? 13:52 DS_ ah, I see 13:53 DS_ the other commits fixed some things, including copying into minetest 13:53 pgimeno ah right, the second commit does that 13:53 pgimeno never mind then 13:53 pgimeno oh wait 13:53 DS_ I guess I should've squased. 13:54 pgimeno if it's X_ATOM_TEXT or XA_STRING or X_ATOM_UTF8_STRING or X_ATOM_UTF8_STRING_2, you always send XA_STRING, is that intentional? 13:55 DS_ I think it's wrong 13:55 DS_ I'm not sure if target = type 13:55 pgimeno or did you mean to send req->target which is what was it was done in the previous commit? 13:55 DS_ doc says that the target defines the type 13:56 pgimeno I don't think you should be sending a type that is not what was requested, if you support what was requested 13:56 DS_ also, just copying our clipboard text into the property and using their type, without actually converting our representation is bad 13:57 pgimeno yes, I also wondered about that 13:59 pgimeno TEXT and STRING are supposed to be in Latin1 IIRC? too lazy to check right now ^.^ 14:00 DS_ TEXT is polymorphic 14:01 DS_ STRING is ISO Latin-1 plus \n and \t 14:07 DS_ oh, it looks like minetest uses the clipboard for wstrings, so I guess I shouldn't define it to be utf-8 14:08 pgimeno you mean it sends wstrings to the clipboard? ugh, is that even compatible between applications? 14:09 DS_ it uses the strings it gets from the clipboard in wstrings 14:09 DS_ it can be compatible if you convert the strings 14:10 pgimeno hm, isn't mbtowcs part of C++11? 14:11 pgimeno mbstowcs* 14:11 pgimeno I think minetest has wrappers for those somewhere 14:11 DS_ ah seems so 14:12 pgimeno or Irrlicht, can't remember 14:13 DS_ oh, btw., when minetest sets the clipboard, it seems to use utf-8 14:26 sfan5 irrlicht's clipboard handling uses a core::string unlike all other stuff that's supposed to hold "international text" uses a core::stringw 14:26 sfan5 so assuming that to be utf-8 is a sane decision 14:28 DS_ do we have helpers to get the length of a stringw? 14:28 DS_ (length, not size) 14:34 DS_ nevermind 17:47 MTDiscord re https://github.com/minetest/minetest/pull/11511 specifically on the subject of "preventing this from causing issues is on them". the given example is essentially filling a book with lorem ipsum 32k times, which in reality is? possible with a any book mod that uses the formspec field textarea[] because it is there is no way to limit textarea[] (or field[] for that matter) input gracefully (yes i am aware i can cut it in lua, however 17:47 MTDiscord thats rather poor for user ux)