Time  Nick      Message
11:05 sfan5     okay, irr#49 merged
11:05 ShadowBot https://github.com/minetest/irrlicht/issues/49 -- Export targets to build tree by JosiahWI
11:05 sfan5     the make install workaround is now gone and instructions look much more straightforward https://github.com/minetest/minetest/pull/11287#issuecomment-888472649
11:19 MTDiscord <Jordach> i still find that incredibly ass to parse
11:23 sfan5     pushing http://sprunge.us/9gbRCR?diff in 5m
11:32 celeron55 interesting
11:35 celeron55 did hecks test this yet?
11:35 sfan5     not that I'd know
11:38 pgimeno   but the CMAKE_PREFIX_PATH workaround is not gone :/
11:39 pgimeno   that makes me nervous, it's always been a target directory, not a library directory
11:39 pgimeno   and it doesn't look like you can use it for another library, should that be necessary in future
11:39 sfan5     what?
11:39 sfan5     are you confusing it with CMAKE_INSTALL_PREFIX?
11:40 pgimeno   er, yes
11:40 pgimeno   thanks for the correction :)
11:41 pgimeno   guess the confusion comes from autoconf where --prefix is the installation prefix
11:41 sfan5     speaking of autoconf I'm very glad we don't use it
12:35 celeron55 if you think about it, --prefix is a terrible argument name, it only brings up the question _what_ prefix it is
12:35 celeron55 frankly CMAKE_PREFIX_PATH also is a terrible name
12:35 celeron55 CMAKE_INSTALL_PREFIX is good
13:08 MTDiscord <josiah_wi> You don't need to set CMAKE_INSTALL_PREFIX unless you intend to run make install.
15:28 MTDiscord <josiah_wi> Whelp, this is embarrassing. Thanks to Bastrabun for helping me find this.
15:28 MTDiscord <josiah_wi> irr/#51
15:28 ShadowBot https://github.com/minetest/minetest/issues/51 -- More documentation by jnumm
15:28 MTDiscord <josiah_wi> irr#51
15:28 ShadowBot https://github.com/minetest/irrlicht/issues/51 -- Fix incorrect documentation by JosiahWI
17:44 Krock     will merge #11461 and #11503 in 10 minutes
17:44 ShadowBot https://github.com/minetest/minetest/issues/11461 -- Fix /emergeblocks crashing in debug builds by Wuzzy2
17:44 ShadowBot https://github.com/minetest/minetest/issues/11503 -- Mods: Combine mod loading checks and deprection logging by SmallJoker
17:54 Krock     merging
17:54 Krock     done