Time  Nick      Message
19:43 Extex     Where and in what file are ignore and air registered?
19:44 sfan5     % egrep ':(air|ignore)' builtin -r
19:44 sfan5     builtin/game/register.lua:core.register_node(":air", {
19:44 sfan5     builtin/game/register.lua:core.register_node(":ignore", {
19:47 Extex     Ty
20:21 MTDiscord <Warr1024> Anyone able to review https://github.com/minetest/minetest/pull/11405 yet?
20:35 pgimeno   !title
20:35 ShadowBot Add API for mods to hook liquid transformation events by Warr1024 · Pull Request #11405 · minetest/minetest · GitHub
20:40 Krock     why do you need oldnode as string? content_id would be way faster in all regards
20:43 sfan5     no other api returns content ids
20:43 MTDiscord <GreenXenith> ^ consistency
20:49 MTDiscord <Warr1024> I had originally considered returning just bare positions with no oldnodes at all, but (1) there's probably no other good way to get this information if I don't have it, and (2) it was nearly free already so it seemed unnecessary to throw it out.
20:49 MTDiscord <Warr1024> I suspect that repacking that extra data that MAY be useful or may not into lua is not going to be a significant cost though.
20:50 MTDiscord <Warr1024> After all, we do stuff like passing node as the second param to a ton of APIs like ABMs and node callbacks even though it's uncertain whether they'd actually be needed or not by the callee (or whether the fact that the hook is being called at all is sufficient)
20:52 Krock     except vmanip.. yes..