Time Nick Message 00:03 MTDiscord Do I sense sarcasm? Cause yeah almost every invention has been invented like 10 times before it becomes publically available or widely known as "invented" and several more before the first official invention. This is extremely common in just about all hardware and software 01:00 MTDiscord #11405 is ready, anyone wanna give it a review? 01:00 ShadowBot https://github.com/minetest/minetest/issues/11405 -- Add API for mods to hook liquid transformation events by Warr1024 07:32 sfan5 did you check the performance impact? 11:47 MTDiscord I couldn't feel any performance impact on my machine, and I'm on an 8 year old thinkpad so I'd think I should if anyone would. If you have a more thorough way to test it, I'd like to know. 11:47 MTDiscord I did do some basic benchmarking of the hook in use and found that each node of liquid transformed cost about 1 microsecond, given NodeCore's logic, which is probably a bit heavy. 11:49 MTDiscord Basically I wired it into NodeCore's "on_nodeupdate" system, which looks up the position hash in an index for optics, and also does a get_node at that position to look up the node by name in the crafting system index. 11:50 MTDiscord I was able to get up to about 800 nodes to consume a little over 1ms every 10 seconds. 15:12 sfan5 pushing http://sprunge.us/FlFx6G?diff in 5m 18:24 Krock will merge #11382 #11398 #11387 and #11395 in 15 minutes 18:24 ShadowBot https://github.com/minetest/minetest/issues/11382 -- Inventory: Make addList() consistent by SmallJoker 18:25 ShadowBot https://github.com/minetest/minetest/issues/11398 -- Auth API: Error when accessed prior to ServerEnv init by SmallJoker 18:25 ShadowBot https://github.com/minetest/minetest/issues/11387 -- run on_grant and on_revoke callbacks after privs change by AFCMS 18:25 ShadowBot https://github.com/minetest/minetest/issues/11395 -- Remove unsupported video drivers by hecktest 18:39 Krock merging 18:42 Krock done 19:01 kilbith https://paste.ubuntu.com/p/6H2tsH3k4G/ 19:01 kilbith the fuck is this 19:03 sfan5 a bug I guess 19:07 kilbith 062fd21 has not been tested for sure 19:08 Krock excuse me what 19:08 Krock I tested this for sure 19:08 sfan5 with MTG? 19:08 Krock yeah 19:08 sfan5 ¯\_(ツ)_/¯ 19:08 Krock rebuilding minetest to ensure 19:09 kilbith so where is the auth function in creative? 19:09 sfan5 check_player_privs 19:10 sfan5 it should never reach there however, at load time it's only called with name="" 19:10 kilbith ah, hmm 19:10 sfan5 ...unless the builtin creative_is_enabled forgets to check for this 19:10 Krock he left 19:10 Krock nvm 19:11 sfan5 hm no builtin has no creative priv 19:11 Krock compiling... 19:12 kilbith sorry, bad connection 19:13 Krock well idk. cannot reproduce in vanilla MTG 19:15 sfan5 shouldn't the error have the full call stack shown? 19:16 Krock yes. it should look like this: https://pastebin.com/raw/pt4vmsaX 19:17 Krock if that error is valid, then is_creative_enabled might be overwritten by another mod which makes use of auth functions before they're ready 19:19 kilbith well it probably comes from i3 which doesn't check if name == "" 19:20 kilbith I now added it and the bug's gone 20:15 MTDiscord sfan5 I can redo the commit I accidentally clobbered if you'd like. 20:15 sfan5 it's not about the commit 20:15 sfan5 you just need those changes or it's broken 20:17 MTDiscord I understand. I will make a new commit with those changes. 20:18 MTDiscord I do see why the changes are necessary. :-) 20:44 sfan5 ubuntu 16.04 does not like the enum inside a map 20:44 sfan5 https://gitlab.com/minetest/minetest/-/jobs/1390128628 20:44 sfan5 not sure we should care 20:45 sfan5 yeah support for it ended in april 21:29 MTDiscord I'm happy to report that my PR is passing CI and seems pretty solid.