Time Nick Message 06:20 MTDiscord When I think about how often I add new features to my server it would be an absolute hassle to need to let my SSCSM be reviewed by someone before it can go live...we are talking up to 5 changes per week and if SSCSM has been added I would make use of that extensively of course 09:29 sfan5 merging #11289 in 10m 09:29 ShadowBot https://github.com/minetest/minetest/issues/11289 -- Minor fixes (don't squash) by sfan5 11:51 specing_ right now you get 0 SSCMS changes per five years because they are not supported 11:51 specing_ having to go through review would be a vast improvement 15:19 kilbith test 15:19 kilbith sfan5: please hold your horses with the shadows PR, I noticed at least a regression caused by your commits 15:19 kilbith more details later 15:21 kilbith * at least one 15:35 MTDiscord While we're on PR's today, anyone have time to merge game-specific background music? https://github.com/minetest/minetest/pull/11241 15:40 sfan5 kilbith: sure, please post the details there 15:42 kilbith basically the "Very Low" quality filtering no longer works, but there's probably more 15:42 sfan5 @exe_virus I'm still not quite convinced sound_stop_all is a good idea but I haven't voiced my concerns there yet 15:43 sfan5 probably the removal of the ifdef that did #define PCFSAMPLES 4.0 in certain conditions 15:46 kilbith please acknowledge this code is touchy and I'd put more caution before declaring it "ready" 15:49 sfan5 no it definitely ready 15:49 sfan5 the regression you're seeing is because I keep removing setting inconsistencies without an answer from Liso indicating whether these have a purpose or not 15:51 kilbith this level of self-confidence is mind blowing ... 15:51 MTDiscord Okay it's a fair complaint, but why not allow modders the ability of sound stop all? As for the reworking without that, it's not impossible, just harder. 15:52 MTDiscord Yeah uh, if removing setting inconsistencies blindly breaks features, its definitely a regression 15:52 sfan5 if I explain every change and waited for mutual confirmation we wouldn't be done in 10 years 15:52 sfan5 it's about the balance 15:53 MTDiscord Fortunately you just have to wait like a few hours for Liso to wake up I'd assume? 15:53 MTDiscord In this one case, yeah 15:53 MTDiscord If lower quality settings are breaking, that is a problem 15:53 MTDiscord Because most players have low end machines 15:57 sfan5 kilbith: this is how it's supposed to look you say? https://a.uguu.se/alHUqYJ7JQrH_.jpg 15:57 VanessaE I see the edges of the shadows are still curved.. 15:57 VanessaE (the leading and trailing edges, not the sides) 15:58 sfan5 (this is the "very low" quality setting) 15:59 sfan5 but I guess they're also "curved" on ultra high.. 15:59 VanessaE the settings I was using when I was testing it early-on would probably be considered "medium" now (I'd need to look again) 16:41 MTDiscord sorry, I was busy this weekend. Let me check the filtering values. 16:42 MTDiscord I'm awake!! xD 16:44 MTDiscord Right on que :] 16:52 sfan5 the shadow mapping should still work just as before 16:54 MTDiscord yes, it works like always, I don't see any problem 16:56 MTDiscord the values for level 2 filtering is 64 samples in poisson, and 8x8 kernel (64 samples) for PCF for level 1 in PCF is 16 samples (4x4 kernel) and 32 looks better for poisson. 16:57 MTDiscord level 0 has 0 (1x1 kernel ? ) extra samples for PCF and 4 samples for poisson 17:30 MTDiscord constants set up correctly 18:07 Krock will merge #10515 and #11247 in 15 minutes 18:07 ShadowBot https://github.com/minetest/minetest/issues/10515 -- Fix base64 validation and add unittests by appgurueu 18:08 ShadowBot https://github.com/minetest/minetest/issues/11247 -- Add core.compare_block_status function by SmallJoker 18:22 Krock merging 18:24 Krock done 22:19 kilbith okay the filtering issue seems fixed now 22:22 kilbith still have some things to report, wait for my green light please 22:28 kilbith for example: https://youtu.be/28rsyG9T_oc 22:28 kilbith @Liso 22:33 kilbith Liso: the shadow distance must be >= to the viewing range 22:45 kilbith and I think it's worth waiting x2048's PR to be merged on Liso's fork