Time Nick Message 07:50 nerzhul sfan5, Krock, my PR is fixed. as Krock approved it but sfan5 did 2 comments, one was answered the other fixed, is this okay to merge and let me continue my work on cleaning up client ? :) 14:09 MTDiscord trying to compile minetest with windows and VS2019, nearly there, but I have IrrlichtMT giving me some unresolved externals. I built it also with VS2019, and didn't involve mingw, is this my problem? 14:18 sfan5 I tested that last week, should work 14:18 sfan5 which symbols are missing? 14:19 MTDiscord MATIERALS_MAX_TEXUTRES_USED 14:19 MTDiscord irr::video::SMATERIAL 14:19 MTDiscord CMATRIX4 14:19 sfan5 you're not linking with Irrlicht then 14:19 MTDiscord huh 14:19 MTDiscord odd 14:20 MTDiscord okay I pointed cmake to the .lib 14:20 MTDiscord wonder why it can't find it 14:21 MTDiscord it's in the project inputs: "C:\dev\irrlicht\build\lib\Win32-VisualStudio\Debug\IrrlichtMt.lib" hmmmm 14:24 MTDiscord Oh I didn't build shared libs, which I figure are .dll's which shouldn't stop the build process, but maybe it somehow does affect those symbols being exporting 14:26 sfan5 if you built it statically you should not have a .lib file at all 14:27 MTDiscord ? static link libraries on windows are .libs 14:27 MTDiscord dynamic are .dlls 14:27 sfan5 no 14:28 MTDiscord https://www.google.com/search?client=firefox-b-1-d&q=what+is+windows+.lib+file 14:28 sfan5 or at least I've never seen that, dunno 14:29 MTDiscord kk, anyways, so if you don't point minetest.sln to a .lib how does it find the precompiled irrlichtMT? 14:29 MTDiscord or are you saying we can compile irrlicht in the minetest.sln when that builds? 14:29 sfan5 shared libraries generate a .lib (linking) and .dll (runtime) and I'd expect static libraries to generate an .a 14:29 sfan5 but I guess that's mingw-specific then 14:29 MTDiscord yeah it is 14:29 MTDiscord no worries 14:29 MTDiscord .lib = .a in this case 14:29 pgimeno what exe_virus said sounds correct to me. Linux->Windows: .o->.obj, .a->.lib, .so->.dll 14:30 MTDiscord basically, my .lib is not satisfying all the dependencies 14:30 sfan5 I recommend just building it shared 14:30 MTDiscord Yep, that's what I'm doing now 14:31 MTDiscord though it'd be nice to use the Vs debugger for debugging it later 14:31 sfan5 dynamic linking shouldn't prevent the debugger from working 14:31 MTDiscord if the pdb is available? 14:32 MTDiscord it's a bit different from linux where an .so contains the code 14:32 MTDiscord basically a .dll doesn't normally contain the .obj file code to debug with 14:43 MTDiscord Okay, got it. Gotta build in release mode with shared libs for now. I'll figure out the problem with debug builds later. Good neough 14:47 MTDiscord Sweet, it hit breakpoints! now I can finally actually help minetest development on the engine side. only 1.5 hours to get it done. Not bad for highly morphing open source code 15:00 MTDiscord And what path did you give CMake? 15:01 MTDiscord Oh didn't scroll down, sorry. 16:02 MTDiscord Does minetest have a function to provide a list of the names of all the folders in a given directory? I'm trying to get a list of games in the games folder so I can preload menu music provided by each game 16:03 sfan5 it does, yes 16:05 sfan5 * `minetest.get_dir_list(path, [is_dir])`: returns list of entry names 17:12 MTDiscord Gotcha, I'll look at what it calls on the backend 17:12 MTDiscord Thanks! 17:36 Pexin sfan5: I'm still kind of new to github, when I made my PR edits, should I respond to each suggestion comment or let the diff speak for itself? 17:37 sfan5 personally I'd only comment if the change isn't obvious or you did not implement the suggestion 17:37 Pexin ok thanks 18:01 MTDiscord is this https://imgur.com/a/tBq0jo5 worth filing a issue over? example from mtg, however i can replicate with just liquid nodes(removing cooling lava abm) it appears to affect 5.4, 5.3, 5.1.1, but not 5.2 18:20 sfan5 it doesn't flow? 18:20 MTDiscord it flows right up to that point, and stops 18:20 MTDiscord height grows up, but never moves into the next node 18:22 MTDiscord you can test this yourself, make a 8 node long hole, put the default:river_water_source water at position 1, and default:lava_source at position 8 19:14 MTDiscord anyways, should i make a issue for it? 19:14 sfan5 it likely already exists 19:38 nerzhul sfan5, can we merge #11234 now we have concerns fixed :) 19:38 ShadowBot https://github.com/minetest/minetest/issues/11234 -- [NOSQUASH] refacto: don't permit to access to RenderingEngine::filesystem widely by nerzhul 19:39 sfan5 i'll look at it again soon