Time  Nick      Message
07:07 nerzhul   sfan5, i saw that irrlicht has support for both using STL or not. As minetest use strongly the STL we may drop non STL support, no ? this library is not intended to be used outside minetest/Mt forks, what do you think ?
07:07 sfan5     I haven't seen any STL support
07:08 nerzhul   irrUString.h L61
07:08 nerzhul   it's the only file with both compat support
07:08 nerzhul   it's the file i imported recently
07:08 sfan5     oh
07:09 nerzhul   what do you think about dropping support for C++97 and lesser ? :p
07:11 sfan5     sure we don't need to support that
07:11 nerzhul   ok i'm writing a pr to cleanup this file :)
07:11 sfan5     for Irrlicht I don't think there's a big difference, just a few preprocessor defines
07:16 nerzhul   yep, it's just a header, it's not used inside
07:16 nerzhul   it's just used by mt directly
07:16 nerzhul   https://github.com/minetest/irrlicht/pull/33/files
07:32 nerzhul   ah i need more work if we use this method :)
07:32 nerzhul   as 2 function couples have same signatures
07:33 sfan5     huh so USTRING_CPP0X_NEWLITERALS wasn't enabled before?
07:33 nerzhul   in my build it seems not
07:34 nerzhul   maybe because it's tied to gcc and i'm on clang :p
07:34 nerzhul   building MT show me the duplicated functions, i'm pushing the fix commit
07:36 nerzhul   woot, my MT doesn't startup, it break on joystick controller ? Wtf i'm not using joysticks
07:36 nerzhul   return joystick->handleEvent(event.JoystickEvent); => joystick is null
07:36 sfan5     recompile, something in irrlicht headers changed
07:37 nerzhul   already done on my side
07:37 nerzhul   with the current branch which is up to date
07:37 nerzhul   i'm cleaning anyway to be sure
07:37 sfan5     if you installed irrlicht system-wide make sure that's up to date
07:38 nerzhul   i don't think as mt recompiled required files on my header changes, will verify the cache
07:38 nerzhul   it's fine it's the local one :)
07:39 nerzhul   m_receiver->joystick = &joystick; => as it's one the parent i don't know how it can be null, except if we don't instantiate using the only constructor we have, but the default one
07:43 nerzhul   wow it's very strange, the starting behavious is clearly not cool
07:44 nerzhul   MT crashed on startup for multiple reasons... i will recompile globally the irrlicht lib to be sure
07:45 nerzhul   ah found... we renamed lib and my local cache didn't switched
07:46 nerzhul   perfect :)
07:47 nerzhul   then https://github.com/minetest/irrlicht/pull/33 is ready :)
09:39 sfan5     merging game#2868, #11229 in 10m
09:39 ShadowBot https://github.com/minetest/minetest_game/issues/2868 -- Check for required engine features on startup by sfan5
09:39 ShadowBot https://github.com/minetest/minetest/issues/11229 -- Update library versions in buildbot by sfan5
09:54 nerzhul   what about my PR ? :D
10:01 sfan5     I'll look at it
18:25 nerzhul   sfan5, you mean i should restore the 4 functions removed ? if yes i can, but honestly minetest compiles without it, then as we don't call it i'm not sure it's interesting to keep them no ? :)
19:57 sfan5     nerzhul: who knows if/when we'll need them in the future
19:57 sfan5     and savign some space in a header isn't really critical
19:57 nerzhul   ok i'll restore them soon, :)
19:57 nerzhul   but remember originally clang didn't haven them, only gcc :)
19:57 nerzhul   windows neither
20:00 sfan5     weren't there identical functions that take a u32 instead of a char32_t?
20:00 sfan5     you're right though I don't think they're used right now
20:00 nerzhul   i should check, but function i removed (outide of those you pointed) are duplicate due to the typedefs
20:01 nerzhul   no i don't think they where used, we can just discard, and have uniform code for all compiler like before :)
20:01 nerzhul   if you are okay with current status, feel free to approve then :)
22:10 Pexin     sfan5: re: weblink user-config CTRL keys..  I added that as a safety feature in case some language-specific keyboards etc cause problems for some people.