Time Nick Message 03:22 MTDiscord https://github.com/minetest/irrlicht/pull/31 03:23 MTDiscord Build is failing on Windows because of a bad ZLIB header. I think this is a bug in ZLIB's build setup but I haven't confirmed it. 15:39 MTDiscord is it building debug or release 16:09 MTDiscord Release. The issue is not Windows, it's the cross compiling. It sets paths to the headers manually and I ignore them. I don't know cross compiling, and I don't know how to handle this. 16:11 MTDiscord There's a variable to handle library paths, but if it doesn't take priority over root paths it won't help. 16:12 sfan5 https://github.com/Kitware/CMake/blob/v3.5.2/Modules/FindZLIB.cmake#L134 16:12 sfan5 cmake should define the target even if the paths are set manually 16:12 sfan5 but something about it is not correct 16:14 MTDiscord find_package is calling FindZLIB.cmake which is probably setting its own header path. 16:14 MTDiscord So the ZLIB_INCLUDE_DIR set in the toolchain gets ignored. 16:18 MTDiscord Yes FindZLIB is setting target properties which the toolchain doesn't affect. 16:18 MTDiscord I don't know of any easy workaround. 16:21 MTDiscord More importantly I PRd an attempt at fixing the subdirectory install issue, but I also have a fairly new version of CMake and can't test it. I'll look into installing an old version maybe. https://github.com/minetest/irrlicht/pull/32 17:20 MTDiscord Zlib with the current head works fine 17:20 MTDiscord Then again, I specified VCPKG 17:37 MTDiscord With my PR? 17:44 MTDiscord However it doesn’t find OpenGL headers at all 17:51 MTDiscord Uhh that's a problem because I didn't change the OpenGL stuff. 17:52 MTDiscord Or I forgot to add the OpenGl header back. 17:53 MTDiscord This is head of Minetest’s irrlicht 18:06 MTDiscord Then you won't experience the ZLIB issue because it's in my fork. 18:13 MTDiscord Cannot open include file: 'GL/glext.h': No such file or directory 18:16 MTDiscord there we go, W10 SDK was missing 19:28 sfan5 merging #10425, #11163 in 10m 19:28 ShadowBot https://github.com/minetest/minetest/issues/10425 -- Add `minetest.colorspec_to_colorstring` by v-rob 19:28 ShadowBot https://github.com/minetest/minetest/issues/11163 -- Rename “Irrlicht” to “IrrlichtMt” in documentation by Wuzzy2 19:40 sfan5 hm I didn't visual studio not to have glext.h by default 19:40 sfan5 +expect 19:53 sfan5 classic microsoft to force such nonsense 22:25 MTDiscord it's not that i'd sa 22:25 MTDiscord it's that there's no literal cmake variable with paths 22:27 MTDiscord i finally got cmake to spit this out: 22:27 MTDiscord Found OpenGL: C:\Users\Jordach\Desktop\vcpkg-master\installed\x64-windows\lib\OpenGL32.Lib 22:28 MTDiscord however, there are no paths for GL headers 22:29 sfan5 there's gl.h inside the windows sdk on my system 22:29 sfan5 but no glext.h, which is sort of an issue 22:29 MTDiscord no glext.h or wglext.h 22:30 MTDiscord they are installed via vcpkg install opengl:x64-windows 22:30 sfan5 oh I see 22:30 MTDiscord however 22:30 MTDiscord even with the vcpkg toolchain 22:30 MTDiscord cmake can't find the headers to include them 22:31 MTDiscord this is cmake being stupid 22:36 MTDiscord > find_path(OPENGL_WGLEXT GL/wglext.h) 22:36 MTDiscord results in NOTFOUND by cmake 22:38 MTDiscord lemme see if i can patch it 22:55 MTDiscord it finds the proper GLU and GL libraries from vcpkg 22:57 MTDiscord but not the headers 22:58 MTDiscord (and for no reason at all it prefers the debug versions as well) 22:58 MTDiscord You can give hints to find_package. 22:58 MTDiscord Or find_path probably. 23:01 MTDiscord find_path(OPENGL_GLEXT "GL/glext.h") NOTFOUND 23:01 MTDiscord even though cmake finds the libraries from vcpkg fine 23:19 MTDiscord wtf 23:19 MTDiscord not even vcpkg's opengl contains glext.h or wglext.h 23:21 MTDiscord stuffing the ones from http://www.opengl.org/registry/api/GL/glext.h into the GL folder from vcpkg works 23:21 MTDiscord dirty hack