Time Nick Message 00:43 MTDiscord IrrlichtMt has a hard defined number of materials 00:43 MTDiscord IMaterial is defined with a max of 8 00:45 MTDiscord What I really suspect is happening behind the scenes 00:45 MTDiscord Is that the camera isn’t actually centered on the model 00:46 MTDiscord As the bones are not set to origin at 0,0,0 00:46 MTDiscord In blender space 00:46 MTDiscord Without a camera positioning option it does and doesn’t 00:46 kilbith are you models offset from center in blender? 00:46 MTDiscord Yes 00:47 kilbith that's why 00:47 MTDiscord Camera positioning would be nice 00:47 MTDiscord Or to set the model positioning 00:47 kilbith this isn't really compatible with the current formspec syntax 00:47 kilbith might be worth waiting v-rob rewrite 00:48 MTDiscord Hypertext exists 00:48 kilbith we already have 10 params for model[] 00:49 MTDiscord I’m surprised you don’t just make certain formspecs actual core.* functions that return the valid formspec string 02:30 kilbith https://github.com/minetest/minetest/pull/10788#issuecomment-816346340 02:30 kilbith sfan5, please. 15:10 LoneWolfHT sfan5, @josiah_wi : input appreciated https://github.com/minetest/minetest/pull/11176 15:18 MTDiscord @josiah_wi ^ 15:21 sfan5 LoneWolfHT: building irrlicht in the same build as MT isn't that bad, gitlab does it too 15:23 x2048 Hey, whom of the coredevs can I tag in #11130 to get a review? 15:23 ShadowBot https://github.com/minetest/minetest/issues/11130 -- Fix rendering of allfaces nodes with transparent textures by x2048 15:25 MTDiscord x2048: why have you marked your PR as a draft? 15:29 x2048 I was looking if I could request review explicitly 15:31 x2048 appguru, I've now re-requested review from you (may be multiple times, github UI drives me crazy) 15:31 x2048 Can you add other reviewers? 15:32 MTDiscord My approval still stands, but remains worthless as I'm not a core dev and not exactly knowledgeable with C++ 15:34 MTDiscord https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/requesting-a-pull-request-review 15:34 MTDiscord I think I understand the MSVC PR, but why was I pinged on it? Am I missing something I should be seeing? 15:37 MTDiscord Because people here are desperate for any competent review they can get. 15:40 LoneWolfHT Just wondering if you had any input on the Cmake part, no problem if not though 15:43 x2048 Thanks Jonathon. Appears, I cannot request reviews in minetest/minetest :) 15:45 MTDiscord Setting the build type to Release is unnecessary, but it's in the old code too apparently. 18:34 sfan5 rubenwardy, Krock: so how does 5.4.1 look for this weekend? 18:35 MTDiscord excellent to me since i now have the ability to build it 18:36 MTDiscord unfortunately i don't own a mac old enough to build it for snow leopard 18:48 Krock no objections 18:48 Krock I might even have some spare time if you need help with anything 19:17 sfan5 pushing http://sprunge.us/ohRwVs?diff if build succeeds 19:46 sfan5 oh dang I should have waited until the end 19:53 Krock linker errors? 19:53 sfan5 yea 20:22 sfan5 merging #11152, #11167, #11150 in 10m 20:22 ShadowBot https://github.com/minetest/minetest/issues/11152 -- Fix server favorites not saving when client/serverlist/ doesn't exist already by sfan5 20:22 ShadowBot https://github.com/minetest/minetest/issues/11167 -- Don't reseed stars when changing star count by Wuzzy2 20:22 ShadowBot https://github.com/minetest/minetest/issues/11150 -- Update builtin locale files and German translation by Wuzzy2