Time Nick Message 06:16 MTDiscord sfan5, Krock, what about my header move to irrlicht ? it seems this is intended to be retributed to it ? 11:33 Wuzzy #9294 11:33 ShadowBot https://github.com/minetest/minetest/issues/9294 -- Add callbacks for falling and attached nodes by Wuzzy2 11:50 Krock @nerzhul: sorry, would you mind explaining this? I don't understand what you mean by that 11:51 Krock also forgot to merge #11011 yesterday. will do that in 10 minutes 11:51 ShadowBot https://github.com/minetest/minetest/issues/11011 -- Schematic: Properly deal with before/after node resolving and document by SmallJoker 11:51 MTDiscord Krock currently there is irrString.h in irrlicht. irruString is a derivate from irrlicht as you see, but not included in irrlicht currently 11:52 MTDiscord then i think it's time to return back this irrlicht_charges header into irrlicht ? 11:52 Krock @nerzhul: so question is whether the server could still be built using the official 1.9 headers. I heard from sfan5_ that 1.9 upstream should still work for this case 11:52 MTDiscord i'm trying to move some code parts from MT to irrlicht if they are irrlicht engine generic 11:52 MTDiscord i don't understand why it should not, as the header is always present, just it's in lthe lib 11:53 Krock @nerzhul so would upstream irrlicht 1.9 have this header? if not - does the server compile without it? 11:53 MTDiscord i don't understand why we want to be close to irrlicht 1.9 as we forked it 11:54 MTDiscord we want server to be built with vanilla irrlicht ? 11:54 MTDiscord if yes it sound just crazy 11:54 MTDiscord maintaining both compat is a bit crazy ? 11:54 Krock yes that's what I saw mentioned in an earlier discussion 11:54 sfan5 hm yeah does the server need this header? 11:54 sfan5 I don't think it does but not sure 11:54 MTDiscord i don't think as it's called from some client irrlicht code 11:55 sfan5 nerzhul: currently the server is still allowed to be built with irrlicht 1.8.4, we can easily forbid that if it turns out to be bad 11:55 sfan5 (CI also tests this) 11:55 MTDiscord yep 11:55 MTDiscord let me check files where it's called 11:56 MTDiscord called from CGUITTfont.h only it seems 11:57 MTDiscord then no problem ? 12:00 Krock merging 12:00 MTDiscord on irrlicht then mt you mean, ? 12:01 MTDiscord i don't know how CI works , where does irrlicht comes @sfan5 ? it's a regular build from the github CI used on minetest/minetest repo ? 12:01 sfan5 https://github.com/minetest/minetest/blob/master/util/ci/common.sh#L15-L16 12:01 sfan5 same gitlab-ci.yml for gitlab, similar in the buildbot scripts 12:01 MTDiscord ah you put a tag then 12:02 MTDiscord won't be easy for MR which target both sides no ? 12:02 Krock done 12:02 sfan5 true 12:02 sfan5 I plan to rename the libraries anyway so I can put some new files there (without a new tag, since we're still in early stages) 12:04 MTDiscord can't we have temporary artifact like on gitlab, on the irrlicht side and download it directly ? could be nice ? 17:12 Wuzzy I created a list of hardcoded features: https://dev.minetest.net/List_of_hardcoded_features 17:14 sfan5 some of those have creative workarounds 17:14 sfan5 > place_param2 is coupled to placement, if you only want to change the inventory image, you're out of luck 17:14 sfan5 for example here you can: disable placement prediction and unset place_param2 after startup 18:08 sfan5 Krock: any other UI issues you noticed? 18:09 Krock no, seems fine 18:09 Krock the grey background was strange at first tho 18:09 Krock but it seems intentional 18:11 sfan5 could possibly tune it down a bit 18:12 sfan5 replace box[0,0;5.75,7;#888888] with box[0,0;5.75,7;#666666] and see if you like it better 18:12 ShadowBot sfan5: Error: That URL raised 18:12 ShadowBot sfan5: Error: That URL raised 18:12 Krock ShadowBot: thanks very helpful 18:15 Krock hmm. in terms of contrast it looks better using darker values 18:16 sfan5 I think #666666 is better,too 18:16 ShadowBot sfan5: Error: That URL raised 18:16 rubenwardy Intentionally missing partial transparency? 18:17 Krock pitch black also does not look too wrong given the semi-transparent dialogue 18:19 Krock I'd go for #f0e . it looks cute but sounds evil /s 18:20 Krock FWIW https://i.postimg.cc/RVyyNcs1/grafik.png 18:21 sfan5 better suggestion: choose a random color each time 18:21 Krock yeah that sounds good to me. I cannot decide anyway so let's do random 18:23 Krock sfan5: Port label needs moving too 18:23 sfan5 whoopsie 18:36 sfan5 merging #11078 in 10m 18:36 ShadowBot https://github.com/minetest/minetest/issues/11078 -- Mainmenu: Improve "Join Game" tab by sfan5 19:07 MTDiscord yay 21:18 sfan5 pushing http://sprunge.us/JOj9fh?diff in 5m