Time Nick Message 16:31 sfan5 for anyone here who uses macOS: testing is appreciated to determine if old issues still exist with irrlicht 1.9 16:31 sfan5 -> https://github.com/minetest/minetest/issues/1614#issuecomment-800414636 16:38 MTDiscord sfan5: the formspecs don't redraw their hotzone/clickable areas 16:38 MTDiscord when the window size changes 16:39 MTDiscord IrrGUI might be the cause 16:39 sfan5 just formspecs? 16:39 MTDiscord however, it does fix formspecs when you make minetest fullscreen with the green button 16:39 MTDiscord it's something to do with the window decoration that makes irrlicht recalculate formspec zones 16:40 MTDiscord because it works when entering and leaving fullscreen via the "maximise" option 16:57 MTDiscord it seems like a WM/DE protocol issue with Irr1.9 16:57 MTDiscord it also happened under 1.8 as well 17:16 sfan5 merging #10918, #11065 in 10m 17:16 ShadowBot https://github.com/minetest/minetest/issues/10918 -- DevTest: Formspec tests, children getter, better lighttool by Wuzzy2 17:16 ShadowBot https://github.com/minetest/minetest/issues/11065 -- Tweak duration_to_string formatting by Wuzzy2 17:37 sfan5 oops 17:37 sfan5 done now 18:29 sfan5 @Jordach if you have some time spare it'd be interesting to know if this fix can be applied to 1.9 https://github.com/minetest/minetest/issues/1614#issuecomment-272680011 18:30 MTDiscord I’ll give it a whirl in about half an hour 18:41 kilbith setVertexShaderConstant deprecated 18:55 kilbith trivial: https://github.com/minetest/minetest/pull/11071 19:03 pgimeno I haven't tried to compile with the new Irrlicht yet, but I'm interested to know if #6573 is fixed with the 1.9 update 19:03 ShadowBot https://github.com/minetest/minetest/issues/6573 -- Compose and dead key handling don't work on Linux 19:17 kilbith and: https://github.com/minetest/minetest/pull/11072 19:56 kilbith updated: https://github.com/minetest/minetest/pull/11071 19:57 kilbith PTAL 20:15 sfan5 pgimeno: I still cannot type an ó or ò under Linux, so no 20:16 pgimeno oh ok, thanks 20:16 sfan5 but now that we can very conveniently fix bugs in Irrlicht maybe the time has come 20:22 MTDiscord sfan5, building the modified irr 20:25 MTDiscord -- Looking for IRRLICHT_VERSION_MT - not found 20:25 MTDiscord i just cloned minetest/irrlicht 20:27 sfan5 somehow, you are doing it wrong 20:28 MTDiscord ? 20:28 MTDiscord https://cdn.discordapp.com/attachments/747163566800633906/821480139077713970/Screenshot_2021-03-16_at_20.28.36.png 20:29 MTDiscord git log wishes to differ 20:29 MTDiscord even github believes it 20:29 MTDiscord > This branch is even with minetest:master. 20:29 MTDiscord so no, cmake is wrong 20:31 MTDiscord these eyeballs are wrong 20:31 MTDiscord gimme a few minutes to read 20:32 MTDiscord there we aer 20:32 MTDiscord You need to set IRRLICHT_INCLUDE_DIR and IRRLICHT_LIBRARY FYI. I don't think the build process on MacOS should differ in particular unless there's a bug 20:33 MTDiscord i renamed my sources differently 20:33 MTDiscord i mv'd folders for organisation 20:52 MTDiscord fixed it in two li nes 20:55 MTDiscord i should've used a branch, but eh 20:56 MTDiscord sfan5, https://github.com/Jordach/irrlicht/commit/cac0fb34392a4945cdd7e85023e8fb47d5b2ab13 20:56 sfan5 looks good 20:57 MTDiscord it's the same thing as earlier, but that's all that was needed for it to work fine under Big Sur 20:59 MTDiscord haha, nice, it'd be awesome to see the homebrew release actually work... 20:59 MTDiscord https://gfycat.com/immaculateimpoliteabyssiniangroundhornbill 20:59 MTDiscord here's a video with mouse clicks shown 21:00 MTDiscord yay 21:00 MTDiscord it's not broken anymore 21:00 MTDiscord Oh, that's awesome, you can actually clicking on the buttons instead of having to click like half an inch above them? :-D 21:00 MTDiscord yes 21:00 MTDiscord it seems like currently, you have to click where the buttons would be if it were fullscreen 21:01 MTDiscord yes 21:01 MTDiscord it's a two line fix 21:02 MTDiscord Even if it's just 2 lines, it's 2 rather important ones, and I'd think it warrants at least a 5.4.0.1 release for OSX... 21:03 MTDiscord I mean, whatever it takes to get brew (and possibly other packagers for OSX) to take notice and update 21:04 sfan5 bumping the irrlicht requirement to some fork we just made in a minor release would be very weird 21:04 MTDiscord and the fix for that is simple 21:04 MTDiscord turn on the autosave screen size and relaunch 21:04 MTDiscord or go fullscreen via the green button 21:05 MTDiscord Oh, would this not fix the fact that MT only renders in the bottom-left corner of my screen? 21:05 MTDiscord you need 5.5.0-dev 21:05 MTDiscord (or at least of whatever window it has) 21:05 sfan5 that was fixed in another PR 21:05 MTDiscord with the MT fork to fix that 21:05 MTDiscord i made sure it works btw 21:05 MTDiscord it works on my machine 21:06 MTDiscord Okay, so 5.4 is just a trash version on OSX and won't be fixed? 21:06 MTDiscord basically brew has been useless for a while 21:06 MTDiscord Ugh, is there some better way to get prebuilts for OSX then? 21:06 sfan5 fixing this requires switching to the fork and we can't just do that in a 5.4.1 21:06 sfan5 https://github.com/minetest/minetest/issues/1614#issuecomment-800414636 I posted one earlier 21:06 MTDiscord there's been shit on the floor for like the last year or so (catalina) and nobody smelt it 21:07 MTDiscord this entire problem is: formspecs be wack 22:15 sfan5 merging #11055, #11071 in 10m 22:15 ShadowBot https://github.com/minetest/minetest/issues/11055 -- GUIScene: Clear depth buffer + replace deprecated clearZBuffer calls by kilbith 22:15 ShadowBot https://github.com/minetest/minetest/issues/11071 -- Fix deprecated calls with Irrlicht 1.9 by kilbith 23:33 kilbith I'm suspecting that our fork of Irrlicht is actually not up-to-date with the sourceforge repo 23:34 kilbith for example I get a compilation error when I try to use `ISceneManager::createShadowVolumeSceneNode` whereas the Irrlicht changelog mentions it 23:35 sfan5 the irrlicht guys only merge changes from trunk into ogl-es infrequently AFAIK 23:35 sfan5 both branches are also mirrored into our repo if you want to experiment 23:35 kilbith and I exchanged emails with the Irrlicht maintainer today about this depth sorting issues with transparent models, they say this sounds like a problem Irrlicht had up to 1-2 years ago 23:37 kilbith ah ok, well, I have no idea how stable or up-to-date this branch is but this doesn't smell good 23:57 Wuzzy I added support for rotatable floor signs: #11073 23:57 ShadowBot https://github.com/minetest/minetest/issues/11073 -- Wallmounted rotate2 by Wuzzy2 23:57 Wuzzy https://satoshiupload.com/images/hvoXt1gIQw.png 23:57 Wuzzy ↑ these are all wallmounted nodes, NOT facedir ones