Time Nick Message 12:56 sfan5 opinions wanted 12:56 sfan5 https://github.com/minetest/minetest/pull/10714#issuecomment-784974041 12:56 sfan5 https://github.com/minetest/minetest/pull/7840#issuecomment-784968394 12:56 sfan5 and more importantly -> https://github.com/minetest/irrlicht/issues/1#issuecomment-782929112 13:24 rubenwardy Irrlicht 1.9 makes sense, if it really is close to release. We don't need everything to be bug free, just the stuff we use 13:25 sfan5 how does the release date matter? We need to fork it anyway to make our customisations 13:25 rubenwardy it matters in terms of how broken it is 13:26 sfan5 presumably it works fine since we've been using it on Android for years 13:26 sfan5 (though the revision we have on android is somewhat outdated, I think?) 13:35 celeron55 sounds like it has to be tested and only then decided 13:35 celeron55 make a windows build, throw it on the forum and see if the kids complain? 13:35 celeron55 minetest 5.5.0: tested on children 13:36 Zughy[m] marketing gone wrong 13:40 rubenwardy Minetesting™ 13:42 sfan5 strictly speaking there isn't even a decision to be had. we could fork 1.8 but then android support would just ????vanish which is not acceptable 13:43 celeron55 that's true, having two forks is complete nonsense 13:43 celeron55 so why are you even asking 8) 13:46 sfan5 to have people agree, I guess 13:54 celeron55 to me it seems like the only question is "when" 13:54 celeron55 if we want to, we can delay forking indefinitely 13:55 celeron55 and live with the bugs or hope irrlicht gets a stable release in some years 14:34 sfan5 I guess I need to figure out how to use svntogit next 14:40 sfan5 or maybe merging can work without the revision history? 14:41 sfan5 but it'd still be useful to have svn mirrored as-is to git for cherry-picking purposes/merging future changes 14:42 sfan5 github can even import from svn directly but I guess it won't keep it in sync 14:53 rubenwardy zaki/irrlicht is a mirror, not sure if it's still alive? 14:53 sfan5 that's the outdated one we're using for our android stuff 15:07 nerzhul sfan5: git svn clone :) 15:14 sfan5 okay I managed to do an import that doesn't have the whole history 15:23 sfan5 https://github.com/minetest/irrlicht/tree/svn-trunk 15:23 sfan5 https://github.com/minetest/irrlicht/tree/svn-ogl-es 15:24 nerzhul svn is so broken that it depends on the repository state if you want all 15:24 nerzhul if it has been broken at a point you may not recover all commits 15:33 sfan5 the ogl-es branch supports opengl so we don't even need to merge them 15:34 sfan5 might still be useful to have both for cherry-picking 16:02 nerzhul i think it should not be so easy 16:02 nerzhul i think first you may at least have MT work with irrlicht-dev branch 16:02 nerzhul after break everything with cherry pick :D 16:32 MTDiscord <{$username}> What does irrlicht 1.9 bring to the table? 16:35 nerzhul i don't know, it's why i'm suspicious about using it 16:36 nerzhul if someone has ideas, it's why i prefer stable + backport opengl es 16:43 sfan5 not being a codebase that wasn't been touched since 7 years is a pretty good advantage 17:15 pgimeno so what happens to the SDL port? will that line of work be abandoned? 17:17 sfan5 no, why would it? It will just be done on top of irrlicht 1.9 17:18 pgimeno ok 17:43 nerzhul we should do things in order 17:43 nerzhul else it will be painful 18:17 sfan5 https://github.com/minetest/irrlicht/issues/1#issuecomment-786102200 19:02 nerzhul why did your closed all MR ? 19:02 nerzhul if you think the opengl-es branch is fine we can use it, and ignore irrlicht 1.9, for our fork 19:10 sfan5 force-pushing master automatically did that 19:11 sfan5 and the ogl-es branch merges changes from 1.9 regularily, it's essentially the same 20:26 sfan5 if someone wants to bother these can be posted to the forums telling people to test, report back, etc. 20:26 sfan5 https://github.com/minetest/irrlicht/issues/13#issuecomment-786180987