Time Nick Message 12:42 sfan5 approvals needed for #10752, #10973 12:42 ShadowBot https://github.com/minetest/minetest/issues/10752 -- Allow overwriting media files of dependencies by Desour 12:42 ShadowBot https://github.com/minetest/minetest/issues/10973 -- [NOSQUASH] Update credits for 5.4.0 by sfan5 12:53 nerzhul i take al ook 12:53 rubenwardy done the second 12:53 rubenwardy trying to work out how the first works - it looks like it's only called with server texture packs 12:59 rubenwardy ahhh ofc 12:59 rubenwardy I see, I misread what the function does 13:01 sfan5 https://github.com/minetest/minetest/blob/master/src/client/inputhandler.h#L201-L211 13:01 sfan5 can anyone explain me the difference between all of these 13:02 rubenwardy is down is if it's currently down 13:02 rubenwardy wasPressed/Released is if it was just pressed or released on this last update tick 13:02 rubenwardy not sure about wasDown 13:02 rubenwardy those are terrible comments lol 13:02 rubenwardy ah, there's more comments on the method 13:03 sfan5 291a6b70d added wasPressed/Released and changed the comment above wasDown 13:03 rubenwardy looks like wasDown is the same as isDown, but only returns true once per tick? Maybe I read the comments wrong 13:03 rubenwardy was this me 13:03 sfan5 not your commit 13:04 sfan5 it's the mouse-dig binding PR 13:13 sfan5 once again it's obvious that the PR has not been properly reviewed 13:14 rubenwardy Ironic given that it was made by a (briefly) core dev and reviewed by two others 13:15 rubenwardy Well, not really ironic 13:17 nerzhul sfan5, aren't we in feature freeze ? #10752 sounds a feature 13:17 ShadowBot https://github.com/minetest/minetest/issues/10752 -- Allow overwriting media files of dependencies by Desour 13:17 sfan5 yeah it sounds like one 13:18 sfan5 but it fixes a regression 13:22 nerzhul sfan5: ok for me 13:25 sfan5 we also need to decide which of #10990 and #10991 to merge 13:25 ShadowBot https://github.com/minetest/minetest/issues/10990 -- Fix wrong number of items in allow_metadata_inventory_put/take callbacks by savilli 13:25 ShadowBot https://github.com/minetest/minetest/issues/10991 -- Fix late limiting of invalid inventory actions by appgurueu 13:26 sfan5 everything has taken too long already so I vote for 10990 and cleaning up properly post-5.4.0 13:30 nerzhul i'd prefer the first version, less risks 13:30 nerzhul but this code is a pure crap 13:31 nerzhul we should refactor it at a point 13:31 sfan5 true 14:26 sfan5 okay looks like everything is going to be solved for release 14:26 sfan5 who is present evening? 14:26 sfan5 +this 14:52 rubenwardy I will be 15:04 nerzhul i am present as a spectator if you need 15:04 nerzhul for next release and irrlicht we should define a clear roadmap, not only which base version we iwll use, but also what we need to do. Using the github kanban directly on the project can be nice 15:11 sfan5 there are number of project management problems that should be solved, roadmap is one of them 15:11 sfan5 btw I don't think basing our code on irrlicht 1.8 has any value 15:11 sfan5 we need 1.9 anyway so we should start from the 1.9 codebase from the beginning 15:25 sfan5 I guess I could import translations in a few hours 16:53 Zughy[m] #10982 should be closed 16:53 ShadowBot https://github.com/minetest/minetest/issues/10982 -- Undo 18:06 sfan5 imported translations https://github.com/minetest/minetest/commits/translations 18:06 sfan5 will push once build finishes 18:24 sfan5 done btw 18:27 Krock will merge #10990 in 10 minutes 18:27 ShadowBot https://github.com/minetest/minetest/issues/10990 -- Fix wrong number of items in allow_metadata_inventory_put/take callbacks by savilli 18:28 sfan5 will merge #10752, #10973, #10992 right after 18:28 ShadowBot https://github.com/minetest/minetest/issues/10752 -- Allow overwriting media files of dependencies by Desour 18:28 ShadowBot https://github.com/minetest/minetest/issues/10973 -- [NOSQUASH] Update credits for 5.4.0 by sfan5 18:28 ShadowBot https://github.com/minetest/minetest/issues/10992 -- Fix keyWasDown in input handler by sfan5 18:29 Krock 3 approvals? uuh okay 18:34 Zughy[m] 5.4 within the evening? 18:34 sfan5 yes 18:36 Krock merging 18:37 Krock sfan5: you may proceed 18:37 sfan5 alright 18:45 sfan5 okay time to build for windows 18:48 rubenwardy Krock: nerzhul reviewed whilst I was testing lol 18:48 Krock heh 18:49 nerzhul ) 18:49 nerzhul sometimes i appear 18:49 Krock random nerzhul :3 18:51 nerzhul my life is changing again, i may have a bit more time to help on our technical debt 18:52 sfan5 oh almost forgot 18:52 sfan5 these two should be merged first https://github.com/minetest/minetest_game/milestone/1 18:53 sfan5 will do that in 5 minutes 18:54 Krock game#2834 seems good. consistent capitals and placement of full stops and exclamation marks 18:54 ShadowBot https://github.com/minetest/minetest_game/issues/2834 -- l10n/pt_BR: added Brazilian Portuguese translation by ronoaldo 18:55 sfan5 the other one is weird but I think it's supposed to be that way 18:57 Krock according to wikipedia it's a planned language based on a fixed sentence logic 18:58 Krock even more obscure than Esperanto 19:07 sfan5 okay both builds uploaded 19:12 sfan5 and both tested to work 19:12 sfan5 if nobody has any comments I will proceed to push the tags/branches now 19:13 Krock I'd like to test 9b59b2f75de8 shortly 19:13 sfan5 sure, I'll wait for that 19:15 Krock okay. works 19:16 Krock other than that it seems to be fine 19:16 sfan5 :+1: 19:17 Krock ?? 19:19 sfan5 I merged stable-5 according to instructions and git describe says it's "5.4.0-113-g07903949e" 19:19 sfan5 weird 19:19 sfan5 but ¯\_(ツ)_/¯ 19:21 sfan5 tagged and pushed MTG too 19:22 sfan5 rubenwardy: android plz 19:22 rubenwardy doing it 19:29 sfan5 uhhh what are the highlights this version 19:30 celeron55 it has a bigger number 19:30 celeron55 and new bugs 19:32 rubenwardy Improved input binding, allows changing mouse bindings. 19:32 rubenwardy Added support for showing attached objects whilst in first person mode (Jordach) 19:32 rubenwardy ContentDB: Added dependency resolution, update all, and download queues. 19:32 rubenwardy Loads of formspec improvements, including 3d models, more styling, and optimisations. 19:32 rubenwardy Loads of bug fixes including several security patches. 19:32 rubenwardy and more bugs ofc 19:36 sfan5 thanks, I took that list 19:37 sfan5 in case anyone visited the post in the first 4 minutes they have seen the two highlights suggested by c55 19:38 celeron55 8) 19:43 rubenwardy weird how only one of those has an author cred lol 19:48 Zughy[m] congratulations, people :) <3 19:52 celeron55 i must say you're running the release process very smoothly 19:53 nore hmmmm, seems like I should have tried to get my PR merged in time for this release 19:53 nore oh well, will try before next one :) 19:53 rubenwardy updated PPA 19:54 rubenwardy hmmmm isn't here anymore 19:54 rubenwardy eh, not funny 19:54 rubenwardy I apologise 19:54 nore lol :D 19:54 nore whooops, hadn't even seen the possible close label 19:55 nore I thought the PR was mostly done though 19:55 nore only needed testing, I think I tested locally a bit but that's all 19:56 rubenwardy OK, you remove the WIP tag then 19:56 nore I'd like to know if it works for others as well 19:56 rubenwardy and use "testing needed" 19:56 nore oooooh, never knew this label existed 19:56 nore should I remove the possible close as well? 19:56 rubenwardy yeah 19:58 sfan5 oh neat the android build exists 19:58 rubenwardy yeah, uploaded to the gh release 20:00 sfan5 website updated too. 20:02 sfan5 >News: 5.4.0 released. (March 23rd 2021 ) 20:02 sfan5 whoopsie 20:03 Krock lgtm 20:03 Krock "oh it came earlier than expected" 20:04 sfan5 man, github pages is almost instant 20:04 rubenwardy it is good 20:07 nerzhul great job team 20:07 rubenwardy hmm, Android night is vvverrrryyy dark compared to PC 20:07 rubenwardy maybe it's just my phone 20:14 nore okay, #10451 rebased 20:14 ShadowBot https://github.com/minetest/minetest/issues/10451 -- Client-side translations: gettext support by Ekdohibs 20:15 nore also, minetest feels fast to compile :) (I'm also working on another project where I get 6-12h build times, this is quite a difference) 20:17 rubenwardy what is that, Linux? 20:19 nore nah, a project to debootstrap OCaml, but we have a code run inside a naive interpreter, compiler to bytecode by a naive compiler 20:19 nore so, several levels of inefficiencies, build times suffer a lot 20:20 nore (like, 4 orders of magnitude) 20:31 rubenwardy OK, submitted to Google Play 20:40 LoneWolfHT rubenwardy: Night is pretty much pure black for any screens that have good colors/contrast 20:41 LoneWolfHT Probably worse on smaller screens 20:52 rubenwardy play update approved 20:55 Zughy[m] merge #10536 ? 20:55 ShadowBot https://github.com/minetest/minetest/issues/10536 -- Add roadmap by rubenwardy 21:06 MTDiscord We should thank the dev team for their great work, thank you guys! 21:23 ronoaldo Hey guys - checking in: did 5.4 changed module script loading somehow? While testing the translations with a 5.4 build + updated .po files, a friend discovered an issue with a mod containing the UTF-8 BOM bytes. 21:25 ronoaldo 2021-02-23 17:28:55: ERROR[Main]: ...a de Trabalho/minetest-5.4.0-dev-linux/bin/../mods/color_blocks/init.lua:1: unexpected symbol near 'ï' 21:27 Krock fix the mod? I don't remember any such change 21:27 rubenwardy link? 21:28 rubenwardy this one? https://content.minetest.net/packages/PrairieWind/color_blocks/ 21:28 ronoaldo Yes 21:28 ronoaldo I could reproduce the bug. 5.3.0 raises no error and on 5.4.0 it raises invalid UTF-8 error 21:29 ronoaldo This mod init script contains the UTF-8 byte order mark, this error will raise on any other lua file containing such bytes. 21:29 ronoaldo init.lua: UTF-8 Unicode (with BOM) text, with CRLF line terminators 21:29 rubenwardy world loads for me 21:29 rubenwardy which platform? 21:29 rubenwardy probably Windows 21:29 ronoaldo hmm, maybe it is my build then? 21:29 ronoaldo nope, we are both on Linux, using KDE 21:30 rubenwardy did you download from CDB or Git? 21:30 ronoaldo from CDB 21:30 ronoaldo he used a world and mods from 5.3 to test my 5.4 build. 21:31 ronoaldo but I used a clean world on both 5.3/5.4 both downloaded from contentdb and the error raised while entering the world with that mod open on 5.4 21:31 rubenwardy I can't see ï in that file 21:31 ronoaldo you can't 21:31 ronoaldo it is the three first bytes of the file. you will see with hexdump 21:31 ronoaldo or with `file -Lks` to show it has BOM (byte order mark) 21:31 rubenwardy also, why does the file contain loads of random ItemStacks, a bit weird 21:32 rubenwardy ah 21:32 ronoaldo yeah, that is from the mod itself... my point is about file handling at the loading point, this could affect other things if something changed in 5.4... 21:33 ronoaldo BOM is the source of a lot of evil in the world, should not exist but ... i had so many issues with that in my life :( 21:34 Krock CRLF in minetest.conf are also funny. I thought trim() would fix that, but there's apparently something not working correct yet 21:34 ronoaldo https://en.wikipedia.org/wiki/Byte_order_mark 21:35 ronoaldo If you guys can't reproduce at master with that mod activated with a fresh download from contentdb, it could be an issue with my build then. 21:35 ronoaldo https://pastebin.com/SG8MK0z8 21:35 ronoaldo The build we used to test is this one: https://github.com/ronoaldo/minetest/releases/tag/5.4.0-dev-pt_BR 21:36 ronoaldo It was my attempt to gather translation feedback without asking for the folks to build from source. I used `cmake -DRUN_IN_PLACE=1 ; make ; make package` to generate that, and just changed .po before build from master. 21:36 ronoaldo Also, my minetest_game was fetched before packaging from my fork with the localization to portuguese for the game as well. 21:37 ronoaldo My build was made from debian/testing 21:38 ronoaldo It could be a minor issue (i.e.), only this mod in entire contentdb having this particular bytes, but it raised some eyebowls when it was working on 5.3 and not on 5.4, hence I decided to check here 21:39 rubenwardy I suspect it may be an issue with the build/packaging 21:39 rubenwardy perhaps try upstream/5.4.0 ? 21:39 rubenwardy and building directly and running without make package 21:39 ronoaldo Good. 21:39 ronoaldo I'll try that. 21:39 rubenwardy If your distro versions don't match exactly, you can have problems when sharing builds 21:40 rubenwardy also, there's the PPA for 5.4.0 now, if using Ubuntu-based distros 21:40 ronoaldo But then it would not error on my machine right? it errored on mine and someone elses .... 21:40 ronoaldo Oh, cool. Testing from PPA is way better. 21:40 rubenwardy oh true with that. Well, still worth checking to see if it's just that build 21:40 rubenwardy also, maybe it's locale based 21:40 rubenwardy I'm in en_gb 21:40 ronoaldo hmm, that is correct 21:41 ronoaldo I'm on pt_BR 21:41 ronoaldo the other person who tested is also there, and my build could somehow inherit the locale right? 21:42 ronoaldo How do I use the PPA:? 21:42 rubenwardy sudo add-apt-repository ppa:minetestdevs/stable 21:42 rubenwardy sudo apt-get update 21:42 rubenwardy sudo apt-get upgrade 21:42 rubenwardy see https://launchpad.net/~minetestdevs/+archive/ubuntu/stable 21:43 ronoaldo thanks - I'll test it out! 22:05 ronoaldo confirmed that PPA don't reproduces the issue, error is only present in my build! thanks for the help! 22:06 ronoaldo now, is there a way to figure out what I did wrong? (just some pointers could be helpful) 22:08 ronoaldo hmm, one differece I noticed is that when i run minetest --version, it says "Using LUA 5.1.5" but not LuaJIT as it sais on the PPA build. 22:10 ronoaldo anyway, testing from PPA seems to be pulling translations already right? so actually no need for me to custom build anymore :D 22:18 ronoaldo just for posterity, when I installed libluajit-dev and rebuild it worked just fine. 22:31 Turner92 /!\ this chat has moved to irc.crimeircd.net #pp /!\ 22:32 percY-Sn /!\ this chat has moved to irc.crimeircd.net #pp /!\ 22:33 moondoggyDi /!\ this chat has moved to irc.crimeircd.net #0 /!\ 22:33 ShadowBot moondoggyDi: Error: That URL raised 22:34 Netham45gM /!\ this chat has moved to irc.crimeircd.net #0 /!\ 22:34 ShadowBot Netham45gM: Error: That URL raised 22:34 Netham45gM /!\ this chat has moved to irc.crimeircd.net #0 /!\ 22:34 ShadowBot Netham45gM: Error: That URL raised 22:34 Netham45gM /!\ this chat has moved to irc.crimeircd.net #0 /!\ 22:34 ShadowBot Netham45gM: Error: That URL raised 22:39 MTDiscord here as well? 23:21 ronoaldo oh wait, 5.4 was just released? yay! 23:21 ronoaldo can't believe I was bothering with custom builds lol