Time  Nick       Message
11:00 sfan5      how on earth do you turn a normal PR back into a draft
11:03 Zughy[m]1  on GitLab you just need to put "Draft:" or "WIP:" in the title, idk if it works on GitHub too
11:03 sfan5      hmm
11:35 sfan5      https://github.blog/changelog/2020-04-08-convert-pull-request-to-draft/
11:35 sfan5      the option is well hidden
13:49 sfan5      this release stuff is kinda taking way too long
13:52 Zughy[m]1  easy: roll it out and then blame your least favourite core dev
14:16 rubenwardy yeah, it's a bit of a pain
14:22 sfan5      is #10805 even significant enough to delay 5.4.0 for it?
14:22 ShadowBot  https://github.com/minetest/minetest/issues/10805 -- Shift-clicking reports the wrong number of items to callbacks
14:25 rubenwardy I added it as it's a regression, I don't have an opinion as to whether it should be considered a blocke
14:26 rubenwardy will merge #10968 in 10
14:26 ShadowBot  https://github.com/minetest/minetest/issues/10968 -- Replace deprecated call to add_player_velocity in builtin by EliasFleckenstein03
14:27 rubenwardy make that 5
14:50 sfan5      hm
15:29 LoneWolfHT CTF has issues with stacks of -1 (63525 or whatever the number is) and we suspect it's because of 10805
15:30 rubenwardy is there a corresponding CTF issue for this?
15:34 LoneWolfHT https://github.com/MT-CTF/capturetheflag/issues/784
15:37 sfan5      #10805
15:37 ShadowBot  https://github.com/minetest/minetest/issues/10805 -- Shift-clicking reports the wrong number of items to callbacks
18:24 MTDiscord  <e​xe_virus> Where can we find what formspec version numbers are supported in a given minetest release? I.e. 4.17 supports: 5.0 supports: etc.
18:24 Krock      history of lua_api.txt, or networkprotocol.h respectively.
18:25 Krock      @exe_virus https://github.com/minetest/minetest/blob/5.1.0/src/network/networkprotocol.h#L221  <-- replace 5.1.0 with the version you'd like to know
18:25 Krock      same goes for the line in lua_api.txt
18:27 Krock      all features that are not documented to require a certain version are version 1. Keep in mind that formspec_version was first exposed in 5.1.0-dev
18:48 Wuzzy      2-line bugfix PR: https://github.com/minetest/minetest/pull/10742
18:48 Wuzzy      #10742
18:48 ShadowBot  https://github.com/minetest/minetest/issues/10742 -- Fix world-aligned node rendering at bottom by Wuzzy2
18:49 sfan5      convince someone else, I already looked at it ;)
18:49 Zughy[m]1  savage
18:51 Krock      -.- looking
18:54 sfan5      #10973 (cc rubenwardy)
18:54 ShadowBot  https://github.com/minetest/minetest/issues/10973 -- [NOSQUASH] Update credits for 5.4.0 by sfan5
18:55 Krock      ah right. tile 6 became 8 and so on. shifted.
19:03 Krock      glad to see an automated approach for this
19:06 rubenwardy (I did that the last two times using a terrible bash script)
19:09 rubenwardy good to have one version controlled though
19:51 MTDiscord  <J​onathon> @exe_virus