Time  Nick      Message
18:34 lhofhansl Hello all. I would appreciate a closer review of #10709 if someone has the time.
18:34 ShadowBot https://github.com/minetest/minetest/issues/10709 -- Allow map save to compress blocks asynchronously. by lhofhansl
18:41 sfan5     soon(tm)
18:42 Krock     why do you need swapSerializedBlocks? would it be possible to &&-move the ownership after swapping to a new list? this approach is kinda obscure
18:43 Krock     I understand that this reduces the computation efforts, but I wonder whether there's not a better solution than feeding a dummy object
18:43 Krock     s/dummy/new/
18:44 Krock     also savemap_timer could be replaced by IntervalLimiter
18:47 celeron55 eh, lol
18:47 celeron55 i went to read IntervalLimiter's implementation
18:48 celeron55 it's so simple, yet the only comment got the return value completely mixed
18:49 lhofhansl Krock: I had a different version first where timerUpdate and save are passed a list that would be filled with the results. This is way it is more contained inside Map.
18:49 celeron55 and it's written by me
18:50 lhofhansl Krock: There's locking or making a copy and then work on the copy. I do not see any other approach. Locking would likely need to be too fine grained.
18:51 lhofhansl I tried a copy constructor for MapBlock but that spiraled out of control quickly - perhaps I can try again.
18:52 lhofhansl and the savemap timer I kept from the original. Happy to change it obviously.
18:53 lhofhansl let's discuss on the PR.
19:05 Krock     I wish NRVO were guaranteed
19:59 lhofhansl Krock: Me too. Hence the weird swap approach. I'll address your comment on the PR today.
23:14 sofar     rubenwardy: now i see where that media server question came from,  lol