Time  Nick      Message
17:20 Thomas-S  I'd appreciate a second approval for #10679 very much, so that it can be merged in time for 5.4.0. Thanks :)
17:20 ShadowBot https://github.com/minetest/minetest/issues/10679 -- Formspec: Allow to specify frame loop for model[] by Thomas--S
17:39 sfan5     don't worry, 5.4.0 isn't gonna come this year
17:49 MTDiscord <a​ppguru> mhm
18:37 MTDiscord <a​ppguru> drawtypes and other effects need proper separation
18:37 MTDiscord <a​ppguru> liquids are a good example for this
19:53 Krock     will push https://github.com/minetest/minetest/issues/9308#issuecomment-577345571 in ~15 minutes
20:06 lhofhansl Why does it need to be a thread_local instead of just a local variable in OnEvent?
20:06 Krock     it needs to persist multiple callbacks
20:06 Krock     because it's triggered on mouse input, not keyboard input
20:06 lhofhansl (just looking at the snippet, have not looked at the surrounding code)
20:06 lhofhansl I see. Thanks.
20:06 Krock     "static" alone would be possible too
20:07 lhofhansl static seems better in this case, right?
20:07 Krock     I'm not sure about the difference, but so far thread_local was preferred for some reason
20:08 lhofhansl I mean no need for each thread to have it's only, this one is truly global it seems.
20:09 lhofhansl But no big deal.
20:09 lhofhansl only = have it's own
20:31 Krock     well, it really doesn't matter. there's only one formspec anyway
20:31 Krock     pushing