Time  Nick      Message
03:12 lhofhansl I have had MT setup with a MAP_BLOCKSIZE of 32 now, and I do not see any detriments. Even when I measure the time for mapgen, etc, it is, within a few percent, the same. And FPS on the client is much better. And since we have the separate mesh generator thread on the client I even have not observed any major stutters.
03:13 lhofhansl Why do we think that lower MAP_BLOCKSIZE is better for low-end machines? The aggregate work in the same, right, just the unit of generation, exchange, and rendering is different.
09:33 Krock     @L​one_Wolf : I cannot reproduce #10675 using your code. Which actions are performed twice? I don't use either mod, thus it's kinda difficult to figure out what exactly doesn't work as expected
09:33 ShadowBot https://github.com/minetest/minetest/issues/10675 -- #7924 causes unwanted rightclicking in certain situations
09:34 Krock     !tell lhofhansl How about sequential mapblock updates? What if there's a mesecon circuit that updates the mapblock data each second? There's also a problem with the inventory serialization which is very slow for large itemstacks (with metadata)
09:34 ShadowBot Krock: O.K.
16:27 Krock     #10661 is now ready for review
16:27 ShadowBot https://github.com/minetest/minetest/issues/10661 -- [MANUAL SQUASH] Settings: Proper priority hierarchy by SmallJoker
16:33 Krock     will merge trivial game#2785 in 10 minutes
16:33 ShadowBot https://github.com/minetest/minetest_game/issues/2785 -- Fix minor bug in german translation. Fixes #2784 by randomMesh
16:42 Krock     merging....
16:48 Krock     Q: should FontEngine continue to use m_settings, or shall I replace everything with g_settings? It's currently the same anyway
16:49 sfan5     i dont see a reason fontengine needs its own settings
16:49 Krock     maybe the idea was to contruct a new object when joining a game, so that game settings can be applied
16:49 Krock     but that's only an assumption
16:57 Krock     now the total line difference is +1. amazing.
17:05 MTDiscord <L​one_Wolf> @Krock 'fixed' https://github.com/minetest/minetest/issues/10675#issuecomment-735424737
17:05 MTDiscord <L​one_Wolf> You should now see a 'REMOVED' chat message every time you spawn the entity
17:19 Krock     trying
17:21 Krock     on_secondary_use and on_rightclick is called at the same time
17:21 Krock     I see
17:37 Krock     also happens with key presses
17:39 Krock     probably due to the reset functions at the end
17:44 Krock     the key event outlasts multiple frames until it's marked as handled
17:52 Krock     hhaha. fixing that causes the same problem when rightclicking the entitiy
17:52 Krock     same but reversed
18:01 Krock     but it works properly in other situations
18:01 Krock     like changing fast move
18:16 Krock     actually that seems to be expected
18:17 Krock     if (m_script->item_OnSecondaryUse(   ....   pointed_object->rightClick(playersao);
18:21 Krock     @L​one_Wolf: Does this fix your issue ? https://krock-works.uk.to/u/patches/0001-Input-Fix-on_rightclick-called-when-placing-into-air.patch
18:21 Krock     another option would be to replace wasKeyPressed a few lines above with wasKeyDown, which marks the key as handled
18:27 MTDiscord <J​onathon> @Lone_Wolf ☝️