| Time |
Nick |
Message |
| 04:02 |
|
Taoki joined #minetest-dev |
| 05:43 |
|
Icedream joined #minetest-dev |
| 06:15 |
|
Icedream joined #minetest-dev |
| 06:34 |
|
NetherEran joined #minetest-dev |
| 07:44 |
|
ssieb joined #minetest-dev |
| 08:00 |
|
ShadowNinja joined #minetest-dev |
| 08:08 |
|
pgimeno joined #minetest-dev |
| 08:36 |
|
NetherEran joined #minetest-dev |
| 09:35 |
|
calcul0n joined #minetest-dev |
| 09:39 |
|
Fixer joined #minetest-dev |
| 09:40 |
|
troller joined #minetest-dev |
| 10:26 |
|
lisac joined #minetest-dev |
| 10:34 |
|
proller joined #minetest-dev |
| 10:45 |
|
calcul0n_ joined #minetest-dev |
| 10:54 |
|
appguru joined #minetest-dev |
| 11:00 |
|
Flitzpiepe joined #minetest-dev |
| 11:34 |
|
appguru joined #minetest-dev |
| 11:35 |
|
appguru1 joined #minetest-dev |
| 11:35 |
|
appguru joined #minetest-dev |
| 11:47 |
|
proller joined #minetest-dev |
| 12:01 |
|
fluxflux joined #minetest-dev |
| 13:22 |
|
NetherEran joined #minetest-dev |
| 13:47 |
MTDiscord |
<appguru> < test #10520 > |
| 13:47 |
ShadowBot |
MTDiscord: Error: That URL appears to have no HTML title within the first 4KB. |
| 13:47 |
pgimeno |
https://github.com/minetest/minetest/pull/10520 -- Contributing doc: Minor improvements and a clarification by paramat |
| 13:48 |
MTDiscord |
<appguru> how about we just kick shadowbot then? |
| 13:48 |
|
absurb joined #minetest-dev |
| 14:00 |
|
Fixer_ joined #minetest-dev |
| 15:57 |
|
lhofhansl joined #minetest-dev |
| 15:58 |
lhofhansl |
Planning to merge #10521 soon. |
| 15:58 |
ShadowBot |
lhofhansl: Error: That URL appears to have no HTML title within the first 4KB. |
| 15:58 |
pgimeno |
https://github.com/minetest/minetest/pull/10521 -- Minor clientmap improvements. by lhofhansl |
| 16:02 |
Krock |
f32 camera_fov should really be const there |
| 16:03 |
Krock |
if even. could also be removed. doesn't have to be there. |
| 16:07 |
lhofhansl |
Same for camera_{position|direction}. I just followed the pattern we have elsewhere. We seem to not want to use members. |
| 16:08 |
Krock |
*shrug* no one knows |
| 16:10 |
lhofhansl |
Lemme at least turn them into const before I merge. |
| 16:15 |
sfan5 |
yeah please turn camera_* const |
| 16:16 |
lhofhansl |
Added some more consts as well while I was at it. We had the same in ClientMap::renderMap |
| 16:16 |
|
Lejo joined #minetest-dev |
| 16:17 |
lhofhansl |
Merging now. Perhaps some more improvements coming. There were so many low hanging fruit - I'm sure there are more. :) |
| 16:24 |
Krock |
thanks |
| 16:24 |
Krock |
btw, not merged yet |
| 16:25 |
Lejo |
I hope here is the right place to get #10517 done, as it needs domain stuff and gitlab pages changes. Btw: Who is responsible for the gitlab mirror? |
| 16:25 |
ShadowBot |
Lejo: Error: That URL appears to have no HTML title within the first 4KB. |
| 16:25 |
pgimeno |
https://github.com/minetest/minetest/issues/10517 -- Correctly publish https://minetest.gitlab.io/minetest |
| 16:26 |
rubenwardy |
Nerzhul, me, and celeron have admin on gitlab |
| 16:26 |
rubenwardy |
The config is in the GitHub repo |
| 16:28 |
lhofhansl |
Krock: Just waiting for the automation to finish/ |
| 16:34 |
lhofhansl |
Done |
| 16:40 |
|
pmp-p joined #minetest-dev |
| 16:57 |
sfan5 |
nitpick: commit messages should not end with a dot |
| 17:01 |
|
Fixer joined #minetest-dev |
| 17:03 |
Lejo |
Another thing about the management thing of Issues/PRs (https://forum.minetest.net/viewtopic.php?t=25507) I think we should work more with tags, like adding more often "Supported by core devs" or if it's a bad idea nobody would merge if someone would create a PR just close the Issue. Contributors should clearly know if a Issue is likly to get merged when creating a PR for it. I mean we don't want to waste their |
| 17:03 |
Lejo |
time. These PRs for "approved" Issues should be priorised. The second thing is about how to review PRs. I often wonder why PRs are half reviewed like one small mistake was just fixed and than nothing happens. You could use tags here as well to clearly show where what (idea, codestyle, working) needs to be reviewed. I understand that it's hard to handle so much stuff but that's exactly the reason why we should order |
| 17:03 |
Lejo |
the mess. |
| 17:17 |
|
pipo joined #minetest-dev |
| 17:20 |
|
pipo left #minetest-dev |
| 17:28 |
|
Fixer_ joined #minetest-dev |
| 17:31 |
|
homthack joined #minetest-dev |
| 17:38 |
sfan5 |
bump #10443 |
| 17:38 |
ShadowBot |
sfan5: Error: That URL appears to have no HTML title within the first 4KB. |
| 17:38 |
pgimeno |
https://github.com/minetest/minetest/pull/10443 -- Decouple entity minimap markers from nametags by sfan5 |
| 17:46 |
Krock |
didn't test yet but looks good |
| 17:49 |
Krock |
...and needs rebase |
| 17:49 |
sfan5 |
oh yea I can do that |
| 17:49 |
Krock |
perhaps "removeMarker" should also set the pointer to nullptr afterwards? ref ptr argument |
| 17:50 |
Krock |
just as an idea |
| 17:51 |
Krock |
Minimap::addMarker() kinda owns the pointer, so keeping ownership nearby would make sense |
| 17:54 |
sfan5 |
will do |
| 17:58 |
sfan5 |
rebased and also made the change |
| 18:16 |
Krock |
Thanks. ☑ |
| 18:27 |
sfan5 |
merging #10443, #10485 in 10 minutes |
| 18:27 |
ShadowBot |
sfan5: Error: That URL appears to have no HTML title within the first 4KB. |
| 18:27 |
ShadowBot |
sfan5: Error: That URL appears to have no HTML title within the first 4KB. |
| 18:27 |
pgimeno |
https://github.com/minetest/minetest/pull/10443 -- Decouple entity minimap markers from nametags by sfan5 |
| 18:27 |
pgimeno |
https://github.com/minetest/minetest/pull/10485 -- Implement unloading of static_save=false objects according to existing docs by sfan5 |
| 18:48 |
|
DS-minetest joined #minetest-dev |
| 19:02 |
Lejo |
Were there a IRC-Bug as nobody event took note of my msg? Repost from the top: Another thing about the management thing of Issues/PRs (https://forum.minetest.net/viewtopic.php?t=25507) I think we should work more with tags, like adding more often "Supported by core devs" or if it's a bad idea nobody would merge if someone would create a PR just close the Issue. Contributors should clearly know if a Issue is likly |
| 19:02 |
Lejo |
to get merged when creating a PR for it. I mean we don't want to waste their time. These PRs for "approved" Issues should be priorised. The second thing is about how to review PRs. I often wonder why PRs are half reviewed like one small mistake was just fixed and than nothing happens. You could use tags here as well to clearly show where what (idea, codestyle, working) needs to be reviewed. I understand that it's |
| 19:02 |
Lejo |
hard to handle so much stuff but that's exactly the reason why we should order the mess. |
| 19:05 |
Krock |
yes |
| 19:12 |
|
Lejo1 joined #minetest-dev |
| 19:17 |
|
DS-minetest joined #minetest-dev |
| 19:19 |
|
proller joined #minetest-dev |
| 19:38 |
Lejo1 |
So after now two and a half hour may I ask you what do you think about my idea? What have you already planned to order and speed up the review process? |
| 20:13 |
sfan5 |
generally irc can be slow, you shouldn't expect to have an answer within a few hours |
| 20:13 |
sfan5 |
to the point: prioritizing approved PRs is a good idea, not sure about extra tags for reviewing though that is probably helpful too |
| 20:17 |
MTDiscord |
<Jordach> Honestly code testing should be moved to automated services |
| 20:25 |
|
basxto joined #minetest-dev |
| 20:26 |
|
basxto joined #minetest-dev |
| 20:27 |
Lejo1 |
I just think tags can help organising that. |
| 20:27 |
Lejo1 |
Jordach: Yeah, I agree the checks should do codesyle and other testing as well |
| 20:29 |
|
MTDiscord joined #minetest-dev |
| 20:36 |
Lejo1 |
Ok so about expecting answeres "so" fast, will just check the logs tomorrow! I'm looking forward to see your thoughts! |
| 20:42 |
|
lhofhansl joined #minetest-dev |
| 21:29 |
|
basxto joined #minetest-dev |
| 21:56 |
|
basxto joined #minetest-dev |
| 21:57 |
|
basxto joined #minetest-dev |
| 22:46 |
|
lhofhansl joined #minetest-dev |
| 23:08 |
|
basxto joined #minetest-dev |
| 23:09 |
|
Seirdy joined #minetest-dev |
| 23:09 |
|
v-rob joined #minetest-dev |
| 23:11 |
|
basxto joined #minetest-dev |
| 23:42 |
MTDiscord |
<josiah_wi> Clang format seems like it could be improved with a very small amount of work. Of course the whitelist would need to be updated afterwards. |
