Time Nick Message 17:33 MTDiscord ACTION[Main]: Server: Shutting down \n terminate called after throwing an instance of 'std::system_error' \n what(): Invalid argument 17:33 MTDiscord Client crash after a local world shutdown 17:34 MTDiscord My client is only a few commits behind if it 17:34 MTDiscord s behind at all 18:00 Krock backtrace would be helpful 18:27 MTDiscord https://pastebin.com/8LgXKxAj 18:27 MTDiscord Happens when I close Minetest 18:29 Krock https://github.com/minetest/minetest/blob/master/src/main.cpp#L228 18:30 Krock but g_settings is never deleted 18:53 MTDiscord Hmmm. I'm getting a freeze with no crash now 18:54 MTDiscord https://pastebin.com/AkzePQ1M 18:54 MTDiscord I have two clients running at once btw 18:55 MTDiscord The other one is just in the main menu though 18:59 MTDiscord I was getting freezes & crashes with 5.4-dev too 18:59 MTDiscord To be precise: It first freezed and crashed later on 19:15 MTDiscord ooooh got that other error now too https://pastebin.com/rpenXH0W 19:16 MTDiscord This is with my client compiled at https://github.com/minetest/minetest/pull/10351 btw 19:17 MTDiscord Been slowly inching back from latest dev to see where it appears 19:40 MTDiscord I'm getting close ? 19:42 sfan5 bisecting is less work btw 19:45 MTDiscord Not sure what to look for 19:45 sfan5 huh? 19:45 sfan5 with bisect you pick a commit where it worked and a commit where it didn't and git gets you to the buggy change in the least possible steps 19:51 MTDiscord Ah 19:51 MTDiscord Too late though, already found the culprit: https://github.com/minetest/minetest/pull/10318 19:52 MTDiscord To reproduce join a game then exit to OS 19:52 Krock I don't want to touch that code ever again 19:55 sfan5 I'm guessing m_map_settings keeps references to the global object that ends up being cleared before it 19:57 Krock Settings holds a pointer of the global FlagDesc structs 19:58 Krock and also group defaults of inherited default values 19:59 Krock setGroupDefault copies the group pointer rather than its value 20:04 Krock yes, that's likely the problem 20:04 Krock double-free of Settings *group inside SettingsEntry,, caused by overrideDefaults 20:12 Krock Lone_Wolf: does this fix your issue? https://krock-works.uk.to/u/patches/settings-crash-attempt1.diff 20:19 MTDiscord Is there an easy way to apply that which I'm not aware of? 23:38 paramat merging game#2740 23:38 ShadowBot https://github.com/minetest/minetest_game/issues/2740 -- Update description to manage expectations by paramat 23:44 paramat #10366 and #10247 are both ready, quick and easy to review, and have a big benefit for mainmenu presentation 23:44 ShadowBot https://github.com/minetest/minetest/issues/10366 -- Improve layout of main menu local tab by paramat 23:44 ShadowBot https://github.com/minetest/minetest/issues/10247 -- Give unnamed world names incremental numbers. Format 'world' by paramat