Time  Nick      Message
00:28 paramat   merging #10276 , thanks for review/approval. Krock, as usual you are a MT hero :3
00:28 ShadowBot https://github.com/minetest/minetest/issues/10276 -- Add 'ores' global mapgen flag by paramat
08:56 Krock     calling me hero after fixing and breaking a feature multiple times is strange but ok
09:41 oil_boi   Where is this NearbyCollisionInfo structure as defined in line 41 of collision.cpp getting the local nodes in the collision step from?
10:48 sfan5     oil_boi: https://github.com/minetest/minetest/blob/4ba5046308d6bdf7b38394770c6f82b6927393f2/src/collision.cpp#L336-L345
15:20 shangul   Hope I am asking in the right place. What process must be done by the client in order so that it may receive RemoveNode packets from server? After some tracing now I am so confused.
15:21 shangul   I'll check online logs for replies.
15:21 Krock     you need to get past INIT2
15:22 Krock     clientiface.h for a visualization IIRC
15:52 sfan5     apparently ADDNODE is not used when placing nodes at all
15:53 sfan5     due to some piece of code in serverpackethandler.cpp
16:07 sfan5     unforunately this seems to be needed to correctly handle buildable_to and stuff even though 90% of cases the prediction would match the actual result
17:30 shangul   Krock, After the client pass INIT2, what else is needed? I have noticed that Server::sendRemoveNode sends a RemoveNode message only if that message's block position exists in that specific client's m_blocks_sent(can be checked via isBlockSent(p)). And that can be achieved by client by sending GotBlock message. I wonder if anything else is needed.
18:01 Krock     dunno