Time  Nick       Message
13:14 MTDiscord  <W​arr1024> ABMs have gotten some improvements, but they're still really slow.  I have a hypothesis that they jump between C++ and Lua too often, and could be improved by passing a list per mapblock to Lua instead of calling per node.  If I can make this happen and keep the same mod API interface (looping over that table on the lua side), and it actually improves perf, would I be likely to get a PR merged?
13:25 sfan5      definitely
16:15 Krock      will merge game#2730 and game#2566 in 15 minutes
16:15 ShadowBot  https://github.com/minetest/minetest_game/issues/2730 -- Update Chinese translation by IFRFSX
16:15 ShadowBot  https://github.com/minetest/minetest_game/issues/2566 -- Fix beds by An0n3m0us
16:30 Krock      rubenwardy: how's the unique ptr supposed to work? this causes an abort by sanity_check(false); in serverinventorymgr.cpp L100  https://krock-works.uk.to/u/patches/0001-send-help.diff
16:30 Krock      merging
16:32 Krock      done
16:32 rubenwardy you want a.get() not &a
16:32 rubenwardy &a will get a pointer to the unique_ptr
16:33 rubenwardy C++ style casts are designed to fix the unsafe-ness of C-style cast. Ie: you can cast any pointer to anything, like you do that
16:34 rubenwardy I don't think there's a nice compile time version though
16:34 sfan5      static_cast?
16:34 rubenwardy as in, dynamic_cast will return nullptr if invalid,  and static_cast won't work on casting to derived types
16:35 sfan5      ah right
16:35 Krock      o/  a.get(); works. thanks.
16:35 Krock      PR updated