Time Nick Message 00:14 paramat merging game#2605 00:15 ShadowBot https://github.com/minetest/minetest_game/issues/2605 -- Replace some sounds with new sounds by An0n3m0us 00:17 paramat ha, commit is 'be fed 55' 13:07 rubenwardy Merging #10341 13:07 rubenwardy in 10 13:07 ShadowBot https://github.com/minetest/minetest/issues/10341 -- Do not allow access to inventories of foreign players by appgurueu 13:09 rubenwardy might be worth having 5.3.1 soonish 13:11 Krock still no check for DROP 13:11 Krock wait for the inventory callbacks. personal milestone for 5.4.0 13:21 sfan5 hmm 13:22 sfan5 I was going to suggest adding a log messag to 10341 but the other code logs to infostream which nobody is going to read anyway 13:24 Krock could be passed to on_cheat() so that mods can kick or ban players trying to abuse it 13:25 Krock actionstream would be a good approach too (used for general anticheat messages) 13:29 rubenwardy I'll hold off 13:31 Krock it's fine. feel free to merge. I'll write a patch for DROP and CRAFT later 13:41 rubenwardy #10085 ready for review 13:41 ShadowBot https://github.com/minetest/minetest/issues/10085 -- Use JSON for favorites, move server list code to Lua by rubenwardy 13:41 rubenwardy I should probably add unit tests for conversions 15:28 rubenwardy Merging #10341, #9818, #10321, #10096 in 10 15:28 ShadowBot https://github.com/minetest/minetest/issues/10341 -- Do not allow access to inventories of foreign players by appgurueu 15:28 ShadowBot https://github.com/minetest/minetest/issues/9818 -- Make bgcolor tint button background images by Df458 15:28 ShadowBot https://github.com/minetest/minetest/issues/10321 -- Add vector.offset by Desour 15:28 ShadowBot https://github.com/minetest/minetest/issues/10096 -- Document normalmap textures by HybridDog 17:44 rubenwardy 27 PRs with 1 approval -> https://github.com/minetest/minetest/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+label%3A%22One+approval%22 17:53 rubenwardy with our fresh meat, maybe we can actually get PRs down to a manageable level 17:54 pyrollo One less, will merge #9312 in 10mn 17:54 ShadowBot https://github.com/minetest/minetest/issues/9312 -- Add compass HUD element by EvidenceBKidscode 17:54 rubenwardy :tada: 17:54 rubenwardy that's another one gone from my review list 17:57 pyrollo Closed a outdated one also :) 17:57 Krock ? 17:58 pyrollo #10345 17:58 ShadowBot https://github.com/minetest/minetest/issues/10345 -- Add Second Hand 17:58 pyrollo I hope this second hand stuff is cheap 17:59 Krock so I could play Minetest as a Zombie simulator. hands at 90° looking for brains 17:59 pyrollo :D 18:00 pyrollo On a gameplay point of view, this could be interresting. Specialy for formspec free games, like nodecore 18:00 pyrollo They could imagin crafting recipes with two hands 18:00 Krock interferes with MMO/RPG game styles where that space could be used to display the current game mode or selected spell... 18:01 pyrollo Should be an option given to game 18:01 Krock also protection mod text 18:01 rubenwardy I think it should be a HUD element 18:01 rubenwardy not sure how to do dual wielding, though 18:02 pyrollo I think it could be used with very different games than mtg 18:02 pyrollo Playing with two kbds :D ? 18:05 rubenwardy haxor edition 20:30 v-rob Does C++11 have designated initializers? 20:31 v-rob Appears it doesn't. Too bad 20:31 pyrollo https://stackoverflow.com/questions/18731707/why-does-c11-not-support-designated-initializer-lists-as-c99 20:33 rubenwardy it'll be in C++20 20:33 v-rob A bit moot for us 20:33 rubenwardy which means Minetest will get it in 28-30 20:33 rubenwardy *2028-2030 20:33 pyrollo Have to be patient, you can use them for MT 12.0 20:33 sfan5 even the thing in c++20 has limitations 20:34 rubenwardy lol 20:34 v-rob Yup, another thing to add the checklist of why I like C better than C++ 20:34 rubenwardy I'd like C++17 at some point, it has lots of nice stuff 20:34 rubenwardy also lots of meh, especially in c++20 too 21:59 v-rob When we replace the formspec syntax, are there any plans to give it a name besides "formspec"? 22:00 rubenwardy GUI 22:00 sfan5 gooey 22:00 rubenwardy `minetest.show_gui(obj)`, `gui.Window { width = 3, height = 4 }` 22:01 rubenwardy could go trendy with guix 22:01 rubenwardy xgui200 22:02 v-rob What is with tacking random X's everywhere? 22:02 rubenwardy \o/ 22:02 v-rob I could never figure that out 22:02 rubenwardy I think it means eXtended? 22:02 v-rob What in the world would Internet Explorer's ActiveX mean then? 22:02 rubenwardy Active eXtension? 22:02 v-rob Because Active is another weird thing that gets tacked on everywhere 22:03 v-rob So how about ActiveGuiX? 22:03 rubenwardy lol 22:04 rubenwardy I like `gui`, it's simple and understandable 22:04 v-rob No, this is much better: `minetest.show_active_gui_x_6000(obj)`, `active_gui_x_200.Window { width = 3, height = 4}` 22:04 v-rob The numbers are different for coolness and extra confusion 22:04 rubenwardy increase the number by 1000 each release 22:18 v-rob Smart pointers sure can be verbose 22:18 v-rob e = std::move(irr_ptr(static_cast(/* Create image button here */))); 22:19 sfan5 sounds like you need a macro 22:19 rubenwardy static_cast? 22:19 rubenwardy or just a function 22:19 rubenwardy look at make_unique in utils/unique.h 22:19 rubenwardy I can't remember if that was merged 22:20 rubenwardy https://github.com/rubenwardy/minetest/blob/csm_chat_message/src/util/make_unique.h 22:20 rubenwardy obviously, don't include the namespace std 22:20 rubenwardy but you can forward arguments to a constructor like that 22:21 v-rob Extending namespace std is undefined behaviour 22:22 rubenwardy doesn't matter to your usecase 22:22 rubenwardy just that PR 22:22 rubenwardy also, that's dumb 22:22 v-rob I didn't make the rules :) 22:22 v-rob Would it work with `irr_ptr`? 22:22 v-rob I don't think it would 22:22 rubenwardy should work 22:22 rubenwardy unless the definition is messed up 22:23 rubenwardy also, you don't need std::move around the constructor due to copy ellision 22:24 rubenwardy well, I've never needed it with unique_ptr 22:26 v-rob `e` is already previously defined, so I think it might be needed? 22:26 v-rob https://github.com/v-rob/minetest/commit/f0f8ba76af623409839dfcc677155da161f12f23#diff-074850a88796e13dad12dd7ae1a8d9f7R355-R365 22:27 rubenwardy hmm 22:27 rubenwardy oh right, that's not make_irr_ptr 22:27 rubenwardy heh, idk 22:27 v-rob Is the static_cast necessary though? 22:28 rubenwardy no, doesn't it derive from GUIButton? 22:28 v-rob Yes 22:28 rubenwardy it should cast to the base type implicitly 22:28 v-rob Oh, ok 22:31 rubenwardy > goto 22:31 v-rob ? 22:34 rubenwardy I noticed a goto in that commit 22:35 v-rob Glue code, will be removed in a later force-push 22:35 v-rob That commit isn't done 22:51 rubenwardy merging #9438, #9923, and #10329 in 10 22:51 ShadowBot https://github.com/minetest/minetest/issues/9438 -- Make dropped items respect tool/craftitem/etc light_source values by LoneWolfHT 22:51 ShadowBot https://github.com/minetest/minetest/issues/9923 -- Fix inventory swapping not calling all callbacks by appgurueu 22:51 ShadowBot https://github.com/minetest/minetest/issues/10329 -- Mark multiply and divide with two vectors as deprecated (Schur product and quotient) by Desour 22:52 sfan5 are you absolutely sure #9923 is bug free? 22:52 ShadowBot https://github.com/minetest/minetest/issues/9923 -- Fix inventory swapping not calling all callbacks by appgurueu 22:52 sfan5 well I guess people will complain if it isn't 22:53 appguru Krock knows best 22:53 rubenwardy I'm not. Krock did extensive testing, I did testing on CTF (as it uses a range different callbacks) 22:53 rubenwardy well, I can drop that from the list to be checked more 22:54 rubenwardy well, given I have actually given a suggestion to make the code nicer