Time  Nick       Message
10:18 sfan5      merging #10296 in 5 minutes
10:18 ShadowBot  https://github.com/minetest/minetest/issues/10296 -- Fix missing #10286 - Translated strings in hypertext fields are broken if they contain spaces by pyrollo
17:05 Krock      will merge #10302 in 5 minutes
17:05 ShadowBot  https://github.com/minetest/minetest/issues/10302 -- define environ variable on OpenBSD by semarie
17:10 Krock      The active core member count increased by 66% in just a week. Impressive.
17:10 Krock      mergign
17:11 pyrollo    :D
17:12 Krock      pyrollo: about the "project goal debate": there were some discussions on GitHub and on the forums. However, it was never possible to define a clear direction
17:13 pyrollo    To bad :(
17:13 Krock      though there are a few popular issues (formspec, for example) about long-term goals
17:13 pyrollo    I think it's something important, not to have a result you "must" reach, but sort of ideal
17:13 Krock      for code quality and API decisions it would probably work, as long it does not touch anything that's visible to players
17:15 Krock      short-term goals are specified by Milestone-marked issues or PRs (until next release). For others - well, there's no decision on which way to go. Best practice is usually to be as generic as possible, so that nobody complains about it being a "Minecraft ripoff" or "unoriginal/limited"
17:18 pyrollo    It's like what we call "central" politics in France :D
17:18 Krock      Nobody knows what to do but they all have their own ideas on what's best?
17:19 pyrollo    I guess I'll make a forum post, not about a clear vision (I have none) but about what I think, regardless of what it would break, what is missing or not well in actual MT.
17:19 pyrollo    GTG, be back
17:19 Krock      !tell pyrollo FYI: other wishlists are here: https://forum.minetest.net/viewforum.php?f=7
17:19 ShadowBot  Krock: O.K.
17:34 celeron55  the android package name wasn't added to the serverlist user agent string, right?
17:35 celeron55  i was looking at the statistics and the absolute mess of what they are could be solved in the long term by doing that
17:35 celeron55  so that any future forks are likely to be distinguishable
18:18 rubenwardy pyrollo: see https://github.com/orgs/minetest/teams/engine/discussions/3
19:15 v-rob      Is there a reason why core devs don't merge stuff immediately?
19:15 Krock      https://dev.minetest.net/Git_Guidelines#Upstream_commit_rules
19:15 v-rob      For instance, Krock approved #10300, so why didn't he merge it immediately, seeing as it has the two approvals?
19:15 ShadowBot  https://github.com/minetest/minetest/issues/10300 -- Auto focus on OK button in main menu error messages by v-rob
19:16 Krock      It's usually helpful to keep PRs open for at least a day so that other devs can have a look at it, if wanted
19:16 v-rob      Ah, OK
19:17 Krock      this way, bugs can be highlighted prior merging, resulting in less after-merge fixes
19:17 Krock      announcing on IRC is not required, but generally a nice thing to do to inform other devs about what you're doing
19:18 v-rob      OK, I'll do that in the future
19:18 Krock      patches are specified to delay at least 5 minutes in IRC - best when others are online. generally waiting longer = better
19:19 Krock      would be great if you could do that. thanks :)
19:34 v-rob      Just thinking after looking at #10295: Why can't Minetest
19:34 ShadowBot  https://github.com/minetest/minetest/issues/10295 -- Added serialization routines for double precision floating point. by scrain777
19:34 v-rob      use fixed point numbers
19:34 Krock      check out readF1000
19:36 v-rob      Isn't that network serialization?
19:36 v-rob      I kind of meant internally; fixed point numbers have no loss of precision near world borders.
19:42 pgimeno    what sort of implementation is that???
19:43 pgimeno    I hope 10295 is rejected
19:45 pgimeno    my thought was that serialization was among the simplest of the problems to solve when it comes to turning coordinates into floats
19:51 pgimeno    there's already one serialization routine for IEEE single-precision floats, another one can be made for IEEE double-precision floats, but using two single-precision floats to construct a double-precision one is a bad hack, when it can be done properly. It loses precision and range.
19:53 Krock      I already replied with a comment going towards this direction. If it already requires 8 bytes, then make best use of it
19:56 pgimeno    indeed
19:57 pyrollo    will merge #9065 in ... 15mn
19:57 ShadowBot  https://github.com/minetest/minetest/issues/9065 -- Load media from subfolders by Desour
19:57 pyrollo    My first merge <3
19:58 v-rob      Cool feeling, isn't it
19:58 Krock      grats
19:58 pyrollo    Feeling powerfull :p
19:59 pyrollo    v-rob if I can do of any help in your work on formspec, just tell me what you need.
20:00 pyrollo    I did some (lot of?) hacking on formspec code, so I guess I could help.
20:06 v-rob      Honestly, it's probably reviewing the more popular formspec features
20:06 v-rob      Like #8679
20:06 ShadowBot  https://github.com/minetest/minetest/issues/8679 -- Add FormSpec key and mouse events by v-rob
20:07 v-rob      ATM, I'm working on the parsing refactor
20:07 pyrollo    Ok!
20:07 v-rob      I decided to leave the inventory list refactor until after some parsing refactoring
20:08 pyrollo    You have to start somewhere :)
20:35 v-rob      I'm drowning in C++ member function pointers and unordered map iterators
20:35 v-rob      Blugh!
20:37 pyrollo    I cowardly leave you there
20:45 pgimeno    u32Tof32Slow translates line by line to u64Tof64Slow, just changing types and values, and same for the vice versa: https://notabug.org/pgimeno/minetest/commit/cb99475a2ef28e03e75bdc6c3d2719d2abacdf2d
20:46 pgimeno    I have to verify one value, the rest should work
20:50 pgimeno    line 98 is wrong, u32 should be u64, fixing
20:51 pgimeno    fixed: https://notabug.org/pgimeno/minetest/commit/dee45e77eddfdd4cbfbbb35014a910f27376928e
20:53 pgimeno    another minor copy/paste error fixed, now going to test it. https://notabug.org/pgimeno/minetest/commit/caa8edf6c06c000ae20777257cae85a3363386db
20:59 pgimeno    what C++ standard are we on?
20:59 pgimeno    11?
20:59 v-rob      Yes
21:00 pgimeno    thanks
22:21 pgimeno    I was off by a factor of 2 in an exponent. Fixed, and unit tests added (and they pass): https://notabug.org/pgimeno/minetest/commit/714988bef515db5e11c130f66c8f40842f3e9124
23:51 pgimeno    https://notabug.org/pgimeno/minetest/commits/pg-ieee-doubles has two commits now