Time  Nick       Message
09:36 Sokomine   oh? did i accidentally post my comment on github several times? there was some lag
09:55 Krock      yes
11:01 Sokomine   sorry for that. and thanks for your work on the serialization problem
11:11 sfan5      merging game#2599 in 10 minutes
11:11 ShadowBot  https://github.com/minetest/minetest_game/issues/2599 -- Add different woods to mese posts by An0n3m0us
13:36 kilbith    sfan5: can you take a look and see why does it fails on MinGW please? https://github.com/minetest/minetest/pull/10261/checks?check_run_id=990483740#step:4:1325
13:38 sfan5      hm
13:39 sfan5      I'm guessing windows has some legacy stuff that conflicts with naming something "far" (https://en.wikipedia.org/wiki/Far_pointer)
13:45 kilbith    oof, that was it
13:45 kilbith    and I salute your low-level knownledge
13:50 Krock      https://docs.microsoft.com/en-us/cpp/cpp/keywords-cpp?view=vs-2019#microsoft-specific-c-keywords
13:50 Krock      notinh here
13:51 Krock      thanks MSVC for that one
14:05 pgimeno    judging by this, it could perhaps be solved with: #ifdef far / #undef far / #endif: https://stackoverflow.com/questions/53158449/far-pointer-declaration-in-visual-studio#53159147
17:47 sfan5      https://old.reddit.com/r/Minetest/comments/iau92t/im_stuck_in_this_state_in_any_game_i_load_what/
17:47 sfan5      I'm thinking preventing mods from directly setting the mapgen might be a good idea
17:48 sfan5      because in this case I assume some game set the mapgen to singlenode and this persists for new worls, thus stuff doesn't work without any clear indication why
17:49 rubenwardy with world-specific settings, minetest.setting:set should only ever set world settings
17:50 sfan5      ..which is what minetest.set_mapgen_setting does
17:53 rubenwardy I'm aware
17:53 sfan5      yeah my thought was kinda incomplete
17:54 sfan5      what I meant to say is that core.settings:set("mg_name", ...) could be deprecated in favor of core.set_mapgen_setting
17:57 Krock      minetest.settings is not applied to the currently run new map
17:58 Krock      map_meta.txt is generated prior mods are loaded for the world
17:58 Krock      so the mod that changes the mapgen name to singlenode is faulty
17:59 Krock      this is the correct way for mods to force mapgen settings: https://github.com/SmallJoker/lualandmg/blob/master/init.lua#L65  (does not affect minetest.conf)
18:07 Krock      nevertheless this settings structure is awful
18:07 Krock      still on my todo list