Time  Nick       Message
12:18 Krock      will push https://krock-works.uk.to/u/patches/0001-GenericCAO-Fix-glow-not-working-since-a08d18a.patch in 15 minutes
12:29 Krock      pushing
12:29 ANAND      I'll troubleshoot 7924 today mostly
16:07 sfan5      merging #10000, #10002 in 5m
16:07 ShadowBot  https://github.com/minetest/minetest/issues/10000 -- Recalc mesh normals for CAOs by dcbrwn
16:07 ShadowBot  https://github.com/minetest/minetest/issues/10002 -- Fix Lua panic when error() message is not a string by pauloue
16:35 Krock      #9717
16:35 ShadowBot  https://github.com/minetest/minetest/issues/9717 -- Extended motion mechanics API for LuaEntitySAOs by sorcerykid
16:35 Krock      does anyone know what's the purpose of locking speed and acceleration?
16:38 sfan5      I remember reading it somewhere in the docs/explanation
16:38 sfan5      the idea is to simulate player-like walking forward behaviour without having to call set_velocity and set_acceleration at every step
16:42 Krock      with those functions you'll also end up calling those for every step
16:44 sfan5      but if you only need to lock it once?
16:56 Krock      still obscure to me. is this another approach to timed movements?
16:59 sfan5      ¯\_(ツ)_/¯
18:31 appguru    sfan5: from what I can see you pushed a fix for #10005
18:31 ShadowBot  https://github.com/minetest/minetest/issues/10005 -- CSM: get_item_def crashes Minetest
18:31 sfan5      I did
18:31 Krock      wondering whether it would work to attach one player to another
18:31 Krock      probably it would...
18:31 sfan5      but since get_item_def doesn't use the _full function you stumbled upon the same bug
18:38 appguru    Krock: Weird bug you found, can confirm it. I will investigate later.
18:39 PGimeno    attaching player to another sounds interesting, a piggy back ride!
18:43 hecks      9139 continued; why would GenericCAO::getPosition apply the camera offset twice?
18:46 sfan5      http://sprunge.us/H1KYLA?lua to fix https://0x0.st/iVNa.mp4
18:46 sfan5      ^ Krock does that look good?
18:48 Krock      yes
18:48 sfan5      thanks, pushing it in a few minutes
18:51 Krock      punchplayer is not called when damage is disabled
18:51 Krock      must be a feature
18:56 sfan5      https://gitlab.com/minetest/minetest/-/jobs/584792929#L1749 huh?!
19:15 Krock      perhaps a temporary server outage
19:15 Krock      or timeout reached
19:16 Krock      content_mapblock.cpp:369:15: error: 'fabs' is not a member of 'std'
19:49 hecks      Alright, so the camera offset isn't applied twice but for one frame it isn't being applied at all; everything is in world space
19:52 hecks      m_matrixnodes should never be in world space, right?
19:54 hecks      There's also a race condition somewhere in here because it doesn't always happen
20:07 PGimeno    right, it should never be in world space, maybe it hasn't been updated yet?
20:23 hecks      I fixed it
20:27 PGimeno    nice work!
20:31 hecks      someone missed a camera un-offset somewhere
20:38 rubenwardy argh, so many dependencies
22:39 hecks      #10008 chupacabra has been caught, please review
22:39 ShadowBot  https://github.com/minetest/minetest/issues/10008 -- Fix player-to-object attachment teleport bug by hecktest