Time Nick Message 10:39 sfan5 merging #9546 in 5m 10:39 ShadowBot https://github.com/minetest/minetest/issues/9546 -- Fix small typos in lua_api.txt by dnchu 13:27 kilbith sfan5: https://github.com/minetest/minetest/issues/9547 16:27 karamel Hello, I see a mix of int, s16, f32, float sometime for the same thing at different functions. What is the recommended typing? 16:34 kilbith blocker: https://github.com/minetest/minetest/pull/9548 16:34 kilbith as the parser changes 17:03 celeron55 karamel: there's usually a correct type for any particular value. note that for example positions can be either integer or floating point depending whether non-integer values make sense or not 17:04 celeron55 in MT usually the more exact type is used like s16 or f32 instead of short int or float but that's really just a stylistic choice given the platforms MT runs on 17:21 karamel Ok, thanks 18:39 Krock sfan5: so you're suggesting to use #define LOG(a) or similar to disable logging? In debug mode async logging would be awful 18:39 sfan5 yes 18:40 sfan5 "server doesn't lock up in hard to figure out ways" is higher in my priorities than "log output of debug mode (which nobody uses) looks nice" 18:44 Krock ok, added to the PR. I'd like to keep both changes to ease fixing it 19:03 sfan5 Krock: what I meant was changing line 43 into #if 1 19:03 sfan5 but what you did works too 19:05 Krock no, profile might still be wanted 19:05 Krock *PROFILE() 19:05 Krock that's removed in release builds