Time  Nick        Message
00:04 Wuzzy       is there a shortcut for "set everything of element type X to default"?
00:05 Wuzzy       or do i have to explicitly name every attribute i want to reset in style_type?
00:10 Wuzzy       ahhhhh
00:11 Wuzzy       those 9-slice buttons are awesome
00:11 Wuzzy       this helps me a lot in cleaning up the remaining ugly mess of the MCL2 interface ?
00:15 rubenwardy  unfortunately, you have to do it manually
00:16 rubenwardy  you can combine properties into one style though:   `style_type[button;bgimg=,bgimg_middle=,color=]`
00:16 rubenwardy  oops, ; not ,
00:16 rubenwardy  #minetest
18:59 Krock       #9501  rubenwardy
18:59 ShadowBot   https://github.com/minetest/minetest/issues/9501 -- GUIFormSpecMenu: Remove field_close_on_enter warning by SmallJoker
19:00 rubenwardy  Lgtm
19:01 Krock       human check failed
19:01 Krock       missing || in L1321
19:02 Krock       testing..
19:03 Krock       check,
19:04 DS-minetest field_close_on_enter should be called m_field_close_on_enter and be cleared in regenerateGUI and in the destructor
19:05 sfan5       > This is a pain. field_close_on_enter[] only existed for a brief moment
19:05 sfan5       you mean the 5th parameter only existed for a brief moment?
19:05 Krock       yes
19:06 Krock       added in https://github.com/minetest/minetest/commit/e10fee000 , legacy in #4566
19:06 ShadowBot   https://github.com/minetest/minetest/issues/4566 -- Fix backwards compatibility issue introduced by close_on_enter by rubenwardy
19:07 Krock       two months
19:07 sfan5       hm should've been removed in 5.0 really
19:07 Krock       my thoughts
19:07 rubenwardy  Was it even in a stable release? Is it documented?
19:07 Krock       never
19:08 Krock       May and December were releases
19:08 sfan5       https://github.com/minetest/minetest/blob/0.4.15/doc/lua_api.txt#L1554 huh indeed
19:08 Krock       added and turned into legacy in the same indev version
19:10 * Krock     slaps rubenwardy kindly with a large trout
19:10 sfan5       now whos gonna review my PRs
19:10 rubenwardy  Should have never maintained backwards compatibility, no idea why that was done
19:11 Krock       sfan5: I'd prefer if you'd use GET_ENV_PTR_NO_MAP_LOCK in l_env.cpp
19:11 Krock       those macros are quite helpful figuring out what's locked when
19:12 Krock       hold on. that's returning if env doesn't exist
19:12 Krock       >,<
19:12 sfan5       I think the use of get_env_ptr vs ..._no_map_lock is all over the place anyway
19:12 sfan5       since they are currently identical
19:15 Krock       will merge #9501, #9500 and #9493 in 15 minutes
19:15 ShadowBot   https://github.com/minetest/minetest/issues/9501 -- GUIFormSpecMenu: Remove field_close_on_enter warning by SmallJoker
19:15 ShadowBot   https://github.com/minetest/minetest/issues/9500 -- Remove unnecessary checks before delete by developedby
19:15 ShadowBot   https://github.com/minetest/minetest/issues/9493 -- Return empty table when minetest.get_connected_players() is called at load time by sfan5
19:15 Krock       #9489 too
19:15 ShadowBot   https://github.com/minetest/minetest/issues/9489 -- Fix memory leak in guihypertext by Desour
19:16 DS-minetest be careful with 9500 though, it autocloses something that maybe shouldn't be autoclosed
19:17 DS-minetest somthing = that issue there
19:17 Krock       the issue does not have a dashed underline, and no tooltip. issue won't be closed automatically
19:17 sfan5       I grepped the code and didn't find any more of those checks
19:18 Krock       nvm, looked at the wrong PR
19:19 kilbith     wh
19:19 kilbith     why #9392 still opened
19:19 ShadowBot   https://github.com/minetest/minetest/issues/9392 -- guiHyperText: Fix blinky cursor on link hover by SmallJoker
19:20 Krock       *shrug*
19:30 Krock       merging (4)
19:33 Krock       took the liberty to try to shorten the commit title a bit so that it's not moved to the second line
19:33 Krock       (done)