Time Nick Message 12:56 sfan5 merging #9437 in 5m 12:56 ShadowBot https://github.com/minetest/minetest/issues/9437 -- GUIHyperText: Fix bug with UTF-8 chars in action name by kilbith 15:10 Jordach sfan5, one star fix for android pushed 16:33 Andrey01 Hello, still time a question: does anybody know what`s a source file whose code executes display an info when an user hovers over icons (ping, creative mode) of a server in the server list tab of the main menu? 16:56 Krock I think you're looking for the server list tab file 16:56 Krock https://github.com/minetest/minetest/blob/master/builtin/mainmenu/tab_online.lua 16:57 Krock information is added by tooltip[] but that does not work on single list entries 17:39 rubenwardy made a class diagram: https://github.com/minetest/minetest/issues/9358#issuecomment-596111586 17:54 Krock rubenwardy: that would be a nice clean structure 17:54 Krock thing is, most elements will need access to GUIFormSpec 17:54 rubenwardy I would like to collect the reasons for that and account for it 17:57 paramat if there is a meeting today i am around for the next 3 hours. an hour from now or later is best for me 17:58 rubenwardy I'll be around for an hour and half more, roughly 17:58 Krock yes, I'd like to do one, in 30 minutes would be preferable 17:59 Krock according to the away status, most devs seem to be available already. don't hesitate to discuss 5.2.0 already :) 18:00 rubenwardy I'd be up for it now, safest option 18:01 rubenwardy !dev Meetings 18:01 ShadowBot Meetings - Minetest Developer Wiki -- http://dev.minetest.net/Meetings 18:05 paramat ok now is fine 18:08 rubenwardy blockers: https://github.com/minetest/minetest/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3ABlocker 18:08 rubenwardy milestone: https://github.com/minetest/minetest/milestone/15 18:09 rubenwardy sofar, nore, sfan5 18:10 rubenwardy ShadowNinja 18:10 paramat i still have not gone through checking for stuff that needs to be done for 5.2.0, perhaps we can do that over the next week 18:15 Krock okay, I'm in 18:16 Krock most of the bugs should already be marked with milestones. add Blocker tags if these have to be merged into 5.2.0 18:16 Krock I think the android PR will have to wait for 5.3.0 18:17 Krock until the dependency issues and multicraft references are solved, right? 18:18 Krock sfan5: how is #9471 a blocker? I think this glow is intended 18:18 ShadowBot https://github.com/minetest/minetest/issues/9471 -- Builtin Item lighting is never updated 18:18 Krock if other items aside light source nodes are affected, this would be a problem 18:19 Krock the "glow" param is calculated client-side. the builtin_item activity in on_step does not matter there 18:19 Krock maybe reduce the glow amount, but I don't see any more issues than that 18:22 appgurueu Improved waypoint PR: https://github.com/minetest/minetest/pull/9480 18:22 appgurueu (and also, again sorry to sfan5) 18:22 appgurueu (for mixing) 18:23 sfan5 Krock: yes I just realized 18:23 sfan5 I remeber seeing buggy items, but that might've been just them being stuck in nodes 18:25 sfan5 random items being lighter than the rest is extremely unexpected because the sourroundings are not light up 18:26 sfan5 s/being lighter/glowing/ 18:28 Krock maybe those should be made light_source / 2 to not look so weird 18:28 rubenwardy I agree 18:29 paramat fine for me 18:29 paramat (reduced glow, that is) 18:30 appgurueu Could my (image) waypoint PR be merged? 18:30 Krock after 5.2.0 18:31 appgurueu Feature freeze currently? 18:31 Krock looking toward starting it today 18:31 appgurueu Then couldn't it be sneaked in? 18:32 appgurueu Today? 18:32 rubenwardy shame not to have scroll container 18:32 rubenwardy I tried debugging the issue with item tooltips, but it's a bit gross 18:32 Krock shame not to have the android rework 18:32 appgurueu What needs to be reworked? 18:33 rubenwardy I would consider the android rework a blocker 18:33 rubenwardy well, saying that 18:33 rubenwardy it's still far off given the crashes 18:33 paramat err, i agree android PR should wait, removing blocker label ... 18:33 appgurueu Any reason not to merge the two blockers? 18:33 appgurueu https://github.com/minetest/minetest/pulls?q=is%3Apr+is%3Aopen+label%3ABlocker 18:34 rubenwardy review needed 18:34 Krock appgurueu: the point for "Blocker" is to mark PRs that must be merged until the next release due to gameplay limitations 18:34 rubenwardy blocker is typically done on bad regressions or game breaking bugs 18:34 kilbith >:( 18:34 Krock the android PR is nice and all, but needs more work from both sides 18:35 appgurueu Well, Jordach's PR already has one approval, so why not merge it? 18:35 rubenwardy because that's not how the rules work 18:35 Krock appgurueu: ffs please read the discussion. it's not done 18:35 rubenwardy we should consider releasing 5.3.0 as soon as Android support is fixed 18:35 rubenwardy in that case 18:35 rubenwardy well - soon after 18:35 Krock yes 18:36 kilbith no scroll_container and no state-selection to style[] 18:36 kilbith sucks 18:37 appgurueu no image waypoints 18:37 appgurueu no waypoint precision 18:37 appgurueu no waypoint offset 18:38 rubenwardy none of those are especially high priority 18:38 appgurueu yeah 18:38 rubenwardy scroll container and state selection are fairly high priority on the formspec rework list 18:38 rubenwardy scroll container still has a fairly big bug - scrolling with an item hovered will keep this selection and the tooltip until you move the mouse 18:39 rubenwardy this is because the inventory list GUI element only updates the selection on mouse move, which doesn't happen during scrolling 18:39 kilbith do you know how to fix that? 18:39 Krock https://github.com/minetest/minetest/commit/6958071f497c8f059429343339ad3818ed3cfed1#diff-90993ca3bb550ffc1c77a1578f3545d3L796 18:39 rubenwardy I have some ideas on how to fix it in an unplesant way 18:40 paramat #9296 is not a blocker, however the other core devs may want that in 5.2.0, in which case we cannot freeze right now 18:40 ShadowBot https://github.com/minetest/minetest/issues/9296 -- Add new Mapgen V7 floatland implementation by paramat 18:40 kilbith as fot state selection it has 1 approval 18:40 paramat you might want to add blocker to that, i am neutral 18:40 kilbith but 5.2 without scroll_container would bother me definitely 18:40 rubenwardy I can probably approve state selection this weekend, I hadn't gotten around to reviewing it 18:41 Krock paramat: I'll test the floatlands PR later if you really want that in 5.2.0 bot tbh I don't see a urgent need for it 18:42 Krock s/bot/but/ 18:42 sfan5 agreed 18:42 sfan5 if we may be releasing 5.3 soon after, floatlands isn't high priority for 5.2 18:43 appgurueu I've had a brief look at Monte's Android PR, and it seems fine to me. 18:43 appgurueu Mostly the fact that he got rid of replaced the build script with a gradle config, 18:43 Krock appgurueu: the "seems fine" approach caused enough issues in the past 18:43 rubenwardy appgurueu: have you built it and tested it? 18:43 appgurueu not yet 18:44 sfan5 I have and the built apk crashed on startup 18:44 sfan5 the build scripts changes are good though 18:44 Krock I'll mark the important 5.3.0 PRs 18:46 Krock sfan5: so it's likely a linkage/dependency issue? 18:46 paramat i am neutral about having floatlands at all, so it is up to others =) will remove from milestone then 18:46 kilbith https://github.com/minetest/minetest/pull/8658 is approved too 18:46 kilbith and useful 18:48 sfan5 Krock: dont think so, it crashed (or errored?) in actual minetest code 18:48 kilbith https://github.com/minetest/minetest/pull/8676 approved 18:48 appgurueu Not necessarily. 18:48 paramat appgurueu stop wasting our time with nonsense 18:49 appgurueu realthechnerds bug report is not detailed enough. 18:49 appgurueu * tech 18:49 Krock kilbith: I'd prefer to fix the open bugs for a sane 5.2.0 release rather than introducing potential new bugs 18:50 appgurueu As said, I support that PR, but first I'll test it myself. 18:50 kilbith this is exactly the lack of guts people are complaining about 18:50 Krock that's a general opinion. both linked PRs worked fine, and no issues found 18:50 kilbith merge this shit, we test it extensively during 2 weeks (that's enough) and your release will be sane 18:50 appgurueu ^ 18:50 paramat app, be quiet, you are not competant enough to take part in this meeting 18:51 appgurueu don't you judge my competence, paramat 18:51 appgurueu also, I'm LMD 18:51 Krock okay, let's go through the open issues for 5.2.0? 18:51 Krock I'll note them down in the meeting nodes 18:51 Krock *notse 18:51 appguru_aka_LMD Yeah 18:52 appguru_aka_LMD * notes 18:53 paramat lmd you are not a competant engine dev or a core dev, and most of your comments here are disruptive nonsense. stop pretending to be a core dev 18:54 appguru_aka_LMD I did not pretend to be a core dev 18:54 paramat please someone kick them 18:54 rubenwardy paramat: these meetings are not just for coredevs, and please don't gatekeep like that 18:54 appguru_aka_LMD please paramat calm down 18:54 rubenwardy however, saying "just merge it" isn't particularly helpful 18:54 sfan5 competent* 18:54 appguru_aka_LMD well, I will test Monte's PR 18:54 sfan5 and please stop pointlessly arguing 18:55 paramat i did not say they are only for core devs. the fact is this is pretentious disruption 18:56 Krock okay, I'll test the sky fixes and expand the PR to merge it soon 18:56 Krock the shaders problem needs action from dcbrwn in case they're around 18:57 Krock if not, disable shaders on those entity types 18:58 Krock I've seen some reports regarding the collision. nothing new, but the new PR is now set to 5.3.0 18:58 Krock after some tests I can say it works very good, but entity collisions aren't well tested yet 18:59 Krock i.e. collisions with higher dtime values 19:05 paramat close #9375 ? i have had no collision issues 19:05 ShadowBot https://github.com/minetest/minetest/issues/9375 -- Reminder: Consider reverting collision tweak before 5.2.0 19:05 sfan5 agree 19:06 Krock yes, close that. 19:06 paramat doing 19:06 kilbith I have these small tweaks improving the arm physics (less "lazyness") to ressemble more like MC' physics 19:06 kilbith would that be accepted for 5.2? 19:06 kilbith https://gist.github.com/kilbith/efcbfa726af148c819b9145db88cfe39 19:06 Krock I'd say so yes 19:07 Krock it's only trivial parameter tweaking for something that's unlikely to break the gameplay 19:07 kilbith it's mostly user feedbacks that are expected 19:07 kilbith not bugs 19:08 Krock I'm expecting this very patch originated from user feedback 19:08 Krock s/expecting/assuming/ 19:09 kilbith that was paramat 3 years ago wanting a "quicker" arm 19:09 Krock okay, so what about minetest_game? is there anything special waiting, paramat ? 19:10 Krock no too important bugfixes from what I can see 19:10 sfan5 natural cotton is not planned for 5.2, is it? 19:14 Krock paramat: please check whether this fixes your on-join issue: https://krock-works.uk.to/u/patches/l_get_player_information-fix.diff 19:14 sfan5 merging game#2614 in a few mins 19:14 ShadowBot https://github.com/minetest/minetest_game/issues/2614 -- xpanes:remove unused textures by TumeniNodes 19:15 Krock it's a dirty workaround but might just work as intended 19:16 paramat yes nice, i agree the arm is currently too 'lazy' 19:16 Krock or maybe just patch l_server.cpp so that it never returns early, but sets the "invalid" return values to zero or so 19:17 paramat oh nice, an info fix, i will test that tonight, can make a PR if wanted 19:17 paramat wild cotton is not needed for 5.2.0 19:18 Krock if it works, I'll push that as trivial bugfix. sub-zero RTT values are always handled the same way in the code (checked) 19:19 paramat a workaround is ok for now. hm, marking #9352 as blocker, games crashing isnot good 19:19 ShadowBot https://github.com/minetest/minetest/issues/9352 -- minetest.get_player_information sometimes return nil (running at mod load, in singleplayer) 19:20 paramat 'fix beds' would be nice but i am hopeless with that code game#2566 19:20 ShadowBot https://github.com/minetest/minetest_game/issues/2566 -- Fix beds by An0n3m0us 19:22 paramat i +1ed craftguide but based on testing, do not fully understand the code. i guess is is not a blocker 19:23 paramat .. based on testing, trust and the fact it is fairly harmless and self-contained. but it will need at least one core dev reviewing the code 19:25 sfan5 paramat: although i would have preferred the set_meta solution the code works right now 19:25 Krock I'm wondering more how someone would replace the MTG craft guide once it's merged 19:25 Krock does the sfinv mod provide this function? 19:26 kilbith why would anyone replace craftguide 19:26 kilbith that's the best out there 19:26 Krock kilbith: replace #2395 for your sake 19:26 ShadowBot https://github.com/minetest/minetest/issues/2395 -- Clean up database API and save the local map on an interval by ShadowNinja 19:26 Krock game#2395 19:26 ShadowBot https://github.com/minetest/minetest_game/issues/2395 -- Carts: switching the drivers's yaw to the cart's by yquemener 19:26 Krock ffs game#2396 19:27 ShadowBot https://github.com/minetest/minetest_game/issues/2396 -- Add (simpler) craftguide mod by pauloue 19:27 kilbith oh yeah by the TRUE craftguide 19:27 Krock so you'd probably go for sfinv.override_page to override it 19:27 Krock unified_inventory ignores sfinv entirely so that's not a problem there 19:28 kilbith not a big deal 19:29 kilbith but still less gameplay value added if the progressive mode's gone 19:33 Krock that'll be again a long changelog.. let's see.. 19:37 paramat removing non-blocker feature PRs from 5.2.0 milestones ... #7924 #9411 19:37 ShadowBot https://github.com/minetest/minetest/issues/7924 -- [NO SQUASH] Allow binding dig, place actions to keys; remove LMB/RMB hardcoding by ClobberXD 19:37 ShadowBot https://github.com/minetest/minetest/issues/9411 -- Add starting frame to `animated_image` by v-rob 19:38 GreenXenith No mouse rebindings for 5.2.0? Damn. 19:39 kilbith wait 19:39 GreenXenith Looks like 5.3.0 will be just as anticipated as 5.2.0. 19:39 kilbith #9411 *needs* to be in 5.2 19:39 ShadowBot https://github.com/minetest/minetest/issues/9411 -- Add starting frame to `animated_image` by v-rob 19:39 kilbith clueless idiot 19:40 Krock well then. testing tomorrow and merge if that has to be 19:40 kilbith http://irc.minetest.net/minetest-dev/2020-03-06#i_5648811 19:41 GreenXenith If it would be a breaking change after 5.2 then it should be marked as a blocker, no? 19:42 Krock for simplicity yes 19:42 paramat k behave please 19:43 paramat #9411 looks like a feature to me, there is no 'bug' label or any clue it is urgent in the first post 19:43 ShadowBot https://github.com/minetest/minetest/issues/9411 -- Add starting frame to `animated_image` by v-rob 19:44 Krock paramat: but it'll cause much useless hassle if not merged before 5.2.0 19:44 Andrey01 Thanks, @Krock 19:44 paramat but i accept it may be, just explaining why i did that 19:44 paramat oh ok, no problem 19:45 Krock it would require much compatibility code in order to work for the last stable definition of the animated_image parameters 19:47 paramat ok. apparently i am a 'clueless idiot' for not knowing that even though there is no documentation at all of the need =) 19:47 Andrey01 And other question: why do you inherit UnitSAO and TestSAO from ServerActiveObject classes and then inherit from them already LuaEntitySAO and PlayerSAO? I think it would be possible to do without them 19:47 Krock maybe it was meant for me, since I changed the topic 19:48 Krock Andrey01: old structure. I don't think there's any particular reason 19:49 paramat kilbith, just a warning, you have now been very unpleasant twice in this channel, if this continues i will ban you from this channel (he is ignoring me but needs warning) 19:50 paramat back later 19:50 Krock paramat: directness like yours might also be interpreted as unpleasant FYI 19:50 kilbith shut the hell up already 19:50 Krock like my message as well.. 19:51 kilbith talking about competence I can guarantee you'd never have a developer job in the real world 19:52 benrob0329 Good God kilbith you really don't like making friends 19:52 kilbith I only have a problem with this bitch 19:53 rubenwardy Please chill it 19:53 rubenwardy To both of you 20:01 benrob0329 rubenwardy: What has to happen for the engine direction PR to not die? 20:22 Krock https://dev.minetest.net/Changelog#5.1.0_.E2.86.92_5.2.0 20:22 sfan5 nice 20:23 Krock I ignored most of the bugfixes that were needed after 5.2.0-dev introduced bugs 20:26 rubenwardy That's fair 20:26 rubenwardy I tend to add the bug fixer of regressions to the feature that added the regression 20:27 Krock the credits might need updating sometime 20:27 Krock this: https://github.com/minetest/minetest/blob/master/builtin/mainmenu/tab_credits.lua 20:48 p_gimeno I've read #2395. I've wanted the same for advtrains. Second Life allows both, and I think it can be the way to go. One idea is to have a "magnetic" area: when the angle of the camera is close to being aligned with the angle of the cart, make it tend to that angle (but making it easy to "escape" by moving the mouse fast) 20:48 ShadowBot https://github.com/minetest/minetest/issues/2395 -- Clean up database API and save the local map on an interval by ShadowNinja 20:49 p_gimeno when in that state, the camera angle would follow the vehicle angle 20:50 p_gimeno err game#2395 20:50 ShadowBot https://github.com/minetest/minetest_game/issues/2395 -- Carts: switching the drivers's yaw to the cart's by yquemener 20:56 Krock that was an accidental mention 20:57 Krock also yes, camera needs to be updated, but in a delta value rather than absolute rotation 20:58 p_gimeno I don't like that idea, if you're looking anywhere but forward you will get disconcerted by a 90° turn 20:59 Krock that's what would happen IRL too 20:59 Krock the move would be interpolated anyway so turning the head while it moves should be possible 20:59 p_gimeno except IRL changes are not instant :) 21:00 p_gimeno interpolated, maybe 21:00 Krock imagine a zig-zag diagonal movement. that would be insane to watch 21:00 Krock from what I've seen, minecraft does that too 21:02 p_gimeno with my locking camera idea, if you're looking at the zigzag it won't be insane; if you're looking in the direction of movement letting the camera lock, it probably will 21:04 benrob0329 Krock: do MTG carts still shift the camera offset so that you can't select the cart when going uphill? 21:04 benrob0329 s/do/does 21:04 benrob0329 ^z 21:05 Krock yes, I think that's still the case 21:06 benrob0329 I wonder if the cart could be attached to a bone slightly above so that it shifts when rotating instead to match the player's position 21:07 benrob0329 essentially moving the rotational axis 21:09 benrob0329 What you'd end up with is an animated b3d file with the different rotations, and instead of manually setting the rotation it'd set the frame that the cart's on 21:10 benrob0329 you could technically use that to smooth the change too but that's not the main thing it would be trying to fix 21:49 Andrey01 How to get names of all players on a server in the server list after core.start() call? 22:30 appguru_aka_LMD Andrey01: Could you elaborate? 22:31 appguru_aka_LMD If you're looking for the serverlist JSON, it's at https://servers.minetest.net/list 22:37 Andrey01 I want to output a tooltip with names of all players on any server in the server list when an user hovers over players count. How to know players names? 22:37 appguru_aka_LMD Well, when that list is loaded, it stores player names as well. 22:38 appguru_aka_LMD I suggest another option however: store it as a tree, so that players can see more by clicking "+" 22:38 appguru_aka_LMD #minetest though? 22:39 Andrey01 No, this concerns to the core 22:40 appguru_aka_LMD Well, it actually resembles modding; it's just that you would have to make a PR & change the mainmenu files. 22:41 DS-minetest the mainmenu belongs to builtin, not modding 22:42 appguru_aka_LMD Yeah, it is builtin, but quite similar to modding 22:43 Andrey01 Why are players names needed to be stored as a tree and what do you mean 'see more by clicking "+"'? 22:44 appguru_aka_LMD Well, I consider tooltips impractical (how are mobile users supposed to use them?) 22:45 appguru_aka_LMD In my designs, I lean towards using tables with "spoilers" 22:45 appguru_aka_LMD See https://raw.githubusercontent.com/appgurueu/cmdlib/master/screenshot.png 22:45 DS-minetest mobile players are supposed to swap to umobile, imo 22:47 kilbith #9485 22:47 ShadowBot https://github.com/minetest/minetest/issues/9485 -- Improve arm physics by kilbith 22:47 DS-minetest i thought there was a recent pr for having all client names in main menu but i cant find it; currently there*s only this: https://github.com/minetest/minetest/blob/0e88176db8ce9f3fb631feb56bdd29d4ada054f5/doc/menu_lua_api.txt#L158-L170 22:47 Andrey01 Ok, but my question is how to get player names from a server at all? Does the modding API allow to do it? 22:48 appguru_aka_LMD Yes, of course. 22:49 appguru_aka_LMD In the mainmenu files, the one for the serverlist gets the list using a HTTP request, parses it using minetest.parse_json, and then creates a view using a formspec. 22:49 appguru_aka_LMD All you have to do is modify that view.