Time Nick Message 11:18 p_gimeno I still fail to see why #2328 is a problem. The example reported by bell07 is user error. http://www.formauri.es/personal/pgimeno/pastes/mtg2328.lua works fine. 11:18 ShadowBot https://github.com/minetest/minetest/issues/2328 -- wrapDegrees() group of functions return incorrect values 11:18 p_gimeno sorry, game#2328 11:18 ShadowBot https://github.com/minetest/minetest_game/issues/2328 -- Fix builtin item metatable. by sofar 11:20 p_gimeno last line output: a=, b=, c= A B C 11:25 p_gimeno you can argue that having the metatable be the same table is bad practice, but I don't think it limits the flexibility. And if it ain't broke... 11:25 sfan5 honestly I have no idea what that change even does 11:26 p_gimeno it makes it use a dedicated metatable instead of reusing the table itself as a metatable (the table has an __index field that points to itself) 11:31 p_gimeno http://www.formauri.es/personal/pgimeno/pastes/current-vs-proposed-2328.lua 11:32 p_gimeno like that, but with the difference that the proposed change still has an __index field (for compatibility?) 11:36 sfan5 hmm 19:00 sfan5 merging #9365 in 10m 19:00 ShadowBot https://github.com/minetest/minetest/issues/9365 -- Collision detection tweak #2 by TheTermos 19:00 paramat in a few hours i will merge game#2573 (trivial) and game#2328 (approving based on good advice) unless objections 19:00 ShadowBot https://github.com/minetest/minetest_game/issues/2573 -- [REDO] Accelerate water/river water animations. by Andrey2470T 19:00 ShadowBot https://github.com/minetest/minetest_game/issues/2328 -- Fix builtin item metatable. by sofar 19:04 paramat oh, just seen conflicting advice in logs about merging game 2328 =) 19:05 paramat i will not merge it yet then 19:24 Krock #9392 if there's something wrong with the scaling it should be done in another PR. I don't see any issue in that regard 19:24 ShadowBot https://github.com/minetest/minetest/issues/9392 -- guiHyperText: Fix blinky cursor on link hover by SmallJoker 19:36 Krock will merge #9398 including requested changes 19:36 ShadowBot https://github.com/minetest/minetest/issues/9398 -- Fix param2 set to 240 if liquid source was renewed by Wuzzy2 19:36 Krock in 5 mins or so 22:15 Wuzzy oofff. I just noticed there are 30 PRs with "one approval". oh my! https://github.com/minetest/minetest/labels/One%20approval 22:23 sfan5 merging #9397 in a few minutes 22:23 ShadowBot https://github.com/minetest/minetest/issues/9397 -- Add missing paramtype2 documentation by Wuzzy2 23:58 paramat merging game#2573 as announced earlier 23:58 ShadowBot https://github.com/minetest/minetest_game/issues/2573 -- [REDO] Accelerate water/river water animations. by Andrey2470T