Time Nick Message 12:44 sfan5 #8964 still needs a review + approval 12:44 ShadowBot https://github.com/minetest/minetest/issues/8964 -- set_sky improvements, set_sun, set_moon and set_stars by Jordach 12:48 sfan5 merging #9287 in 5 minutes 12:48 ShadowBot https://github.com/minetest/minetest/issues/9287 -- Formspec: create a new class for inventorylists by DS-Minetest 13:02 sfan5 merging #6993 too 13:02 ShadowBot https://github.com/minetest/minetest/issues/6993 -- Add limit parameter to decompressZlib by bendeutsch 13:42 Krock the sky PR needs squashing and rebasing, afterwards some style fixes. testing it rn 14:05 sfan5 I provided comands to squash + rebase so this can be done at merge time 14:14 sfan5 rubenwardy: you forgot some minor things during 5.1.1 release https://github.com/minetest/minetest/blob/stable-5/misc/net.minetest.minetest.appdata.xml#L65 14:15 sfan5 the script would have done this for you if you had used it 14:16 rubenwardy I did use it 14:16 rubenwardy I relelased the wrong commit 14:17 rubenwardy next time I'll use the github PR feature 14:19 sfan5 oh hm 14:19 sfan5 I remember you mentioning that 14:20 rubenwardy I merged in the wrong remote before pushing to stable-5 14:20 rubenwardy origin rather than upstram 14:20 rubenwardy how do you fast forward to a local branch? 14:21 rubenwardy I guess you could use git reset --hard branchname 14:21 sfan5 git checkout target_branch ; git merge --ff-only local_branch ; git push origin HEAD:target_Branch 14:21 sfan5 not sure if that is what you were thinking of 14:21 rubenwardy ahh, didn't know about --ff-only 14:23 sfan5 oh also 14:24 sfan5 how do you want me to replace the lua_isboolean? 14:56 rubenwardy it should probably just do lua_toboolean 14:57 rubenwardy you can check the number of arguments using lua_gettop() 14:57 rubenwardy with no other alternatives, you could just force them to coerce I gues 14:57 Krock okay, that took quite long to review 14:58 Krock it's definitely not ready for merge in the current state 15:02 sfan5 damn I totally missed the compatibility of new clients on old servers 15:02 Krock that's why we have a two approval rule ;) 15:03 rubenwardy "i totally missed X" makes me think "automation!" 15:04 Krock will merge #8299 in 5 minutes 15:04 ShadowBot https://github.com/minetest/minetest/issues/8299 -- Add table.shuffle by HybridDog 15:04 sfan5 unless whatever default configuration your automation runs at makes use of set_sky(), it would not have caught it 15:04 Krock rubenwardy: gl automating the entire network code, including backwards compatibility 15:04 rubenwardy yeah, mildly late now 15:04 sfan5 for example minetest_game would not trigger this bug 15:09 Krock merging 15:21 sfan5 rubenwardy: ok, replaced it with lua_gettop now 15:23 sfan5 Krock: do you insist on moving it into the sound parameter table? I very much prefer the extra argument due to how often it will be needed. 15:24 Krock no, it was only a suggestion 15:25 sfan5 okay 16:32 rubenwardy I guess the ID ( (s32)-1 ) the server tells the client doesn't matter, because the server will never use that handle 16:33 sfan5 yes 16:33 rubenwardy wait, it's s32 not u32. Weird 16:41 Wuzzy Requestion 2nd dev review for 3 of my PRs that already have won 1 approval: 16:42 Wuzzy #9302, #9294, #9205 16:42 ShadowBot https://github.com/minetest/minetest/issues/9302 -- Fix z-fighting of large stacked plantlike nodes by Wuzzy2 16:42 ShadowBot https://github.com/minetest/minetest/issues/9294 -- Add callbacks for falling and attached nodes by Wuzzy2 16:42 ShadowBot https://github.com/minetest/minetest/issues/9205 -- Falling nodes: Add support for facedir, colorfacedirr, wallmounted, colorwallmounted, color, airlike, signlike, torchlike and glow by Wuzzy2 19:19 sfan5 merging #9342 in 10 minutes 19:19 ShadowBot https://github.com/minetest/minetest/issues/9342 -- API: Ephemeral sounds, Game: dug/place sounds hearable for other players by sfan5 19:20 Krock I'll merge #9340 right afterwards 19:20 ShadowBot https://github.com/minetest/minetest/issues/9340 -- StaticText: reset background on EnrichedString change by SmallJoker 19:31 sfan5 merged ..only 2 minutes late 19:40 Krock Merging too.. only 9 minutes late